Skip to content

Update golang.org/x/sync to v0.18.0 and add Go/Node/Python to default allowed domains #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Update golang.org/x/sync to v0.18.0 and add Go/Node/Python to default allowed domains #3567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe7049e
Initial plan
Copilot Nov 10, 2025
dc052b8
Update golang.org/x/sync to v0.18.0 and add node, python, go domains …
Copilot Nov 10, 2025
c102e4d
Update domains.go documentation to reflect new defaults
Copilot Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ require (
github.com/yosida95/uritemplate/v3 v3.0.2 // indirect
go.uber.org/atomic v1.7.0 // indirect
go.uber.org/multierr v1.9.0 // indirect
golang.org/x/sync v0.17.0 // indirect
golang.org/x/sync v0.18.0 // indirect
golang.org/x/sys v0.38.0 // indirect
golang.org/x/term v0.36.0 // indirect
golang.org/x/text v0.30.0 // indirect
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ go.uber.org/multierr v1.9.0 h1:7fIwc/ZtS0q++VgcfqFDxSBZVv/Xo49/SYnDFupUwlI=
go.uber.org/multierr v1.9.0/go.mod h1:X2jQV1h+kxSjClGpnseKVIxpmcjrj7MNnI0bnlfKTVQ=
golang.org/x/exp v0.0.0-20231006140011-7918f672742d h1:jtJma62tbqLibJ5sFQz8bKtEM8rJBtfilJ2qTU199MI=
golang.org/x/exp v0.0.0-20231006140011-7918f672742d/go.mod h1:ldy0pHrwJyGW56pPQzzkH36rKxoZW1tw7ZJpeKx+hdo=
golang.org/x/sync v0.17.0 h1:l60nONMj9l5drqw6jlhIELNv9I0A4OFgRsG9k2oT9Ug=
golang.org/x/sync v0.17.0/go.mod h1:9KTHXmSnoGruLpwFjVSX0lNNA75CykiMECbovNTZqGI=
golang.org/x/sync v0.18.0 h1:kr88TuHDroi+UVf+0hZnirlk8o8T+4MrK6mr60WkH/I=
golang.org/x/sync v0.18.0/go.mod h1:9KTHXmSnoGruLpwFjVSX0lNNA75CykiMECbovNTZqGI=
golang.org/x/sys v0.0.0-20210809222454-d867a43fc93e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.0.0-20210831042530-f4d43177bf5e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
Expand Down
9 changes: 8 additions & 1 deletion pkg/workflow/data/ecosystem_domains.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,14 @@
"api.snapcraft.io",
"packagecloud.io",
"packages.cloud.google.com",
"packages.microsoft.com"
"packages.microsoft.com",
"golang.org",
"proxy.golang.org",
"sum.golang.org",
"npmjs.org",
"registry.npmjs.org",
"pypi.org",
"files.pythonhosted.org"
],
"containers": [
"ghcr.io",
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/domains.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func getEcosystemDomains(category string) []string {
// Returns empty slice if network permissions configured but no domains allowed (deny all)
// Returns domain list if network permissions configured with allowed domains
// Supports ecosystem identifiers:
// - "defaults": basic infrastructure (certs, JSON schema, Ubuntu, common package mirrors, Microsoft sources)
// - "defaults": basic infrastructure (certs, JSON schema, Ubuntu, common package mirrors, Microsoft sources, Go, Node, Python)
// - "containers": container registries (Docker, GitHub Container Registry, etc.)
// - "dotnet": .NET and NuGet ecosystem
// - "dart": Dart/Flutter ecosystem
Expand Down
10 changes: 7 additions & 3 deletions pkg/workflow/ecosystem_domains_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ func TestEcosystemDomainExpansion(t *testing.T) {
"archive.ubuntu.com", // Ubuntu
"packagecloud.io", // Common Package Mirrors
"packages.microsoft.com", // Microsoft Sources
"golang.org", // Go ecosystem
"proxy.golang.org", // Go proxy
"sum.golang.org", // Go checksum database
"npmjs.org", // Node ecosystem
"registry.npmjs.org", // NPM registry
"pypi.org", // Python ecosystem
"files.pythonhosted.org", // Python files
}

for _, expectedDomain := range expectedDomains {
Expand All @@ -38,9 +45,6 @@ func TestEcosystemDomainExpansion(t *testing.T) {
"ghcr.io", // Container registries
"nuget.org", // .NET
"github.com", // GitHub (not in defaults anymore)
"golang.org", // Go
"npmjs.org", // Node
"pypi.org", // Python
}

for _, excludedDomain := range excludedDomains {
Expand Down
Loading