-
Notifications
You must be signed in to change notification settings - Fork 434
Fix PR link formatting in cli-version-checker workflow #3586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -69,9 +69,10 @@ For each update, analyze intermediate versions: | |||||
| - **Codex**: Fetch release notes from https://github.com/openai/codex/releases/tag/rust-v{VERSION} | ||||||
| - Parse the "Highlights" section for key changes | ||||||
| - Parse the "PRs merged" or "Merged PRs" section for detailed changes | ||||||
| - Extract links to pull requests and issues for context | ||||||
| - **CRITICAL**: Convert PR/issue references (e.g., `#6211`) to full URLs since they refer to external repositories (e.g., `https://github.com/openai/codex/pull/6211`) | ||||||
| - **GitHub MCP Server**: Fetch release notes from https://github.com/github/github-mcp-server/releases/tag/v{VERSION} | ||||||
| - Parse release body for changelog entries | ||||||
| - **CRITICAL**: Convert PR/issue references (e.g., `#1105`) to full URLs since they refer to external repositories (e.g., `https://github.com/github/github-mcp-server/pull/1105`) | ||||||
| - **Copilot CLI**: Repository may be private, skip release notes if inaccessible | ||||||
| - **Claude Code**: No public repository, rely on NPM metadata and CLI help output | ||||||
|
|
||||||
|
|
@@ -124,6 +125,12 @@ Include for each updated CLI: | |||||
| - **INCORRECT**: `https://www.npmjs.com/package/@github/copilot` (has backticks) | ||||||
| - **INCORRECT**: https://www.npmjs.com/package/`@github/copilot` (package name wrapped in backticks) | ||||||
|
|
||||||
| **Pull Request Link Formatting**: | ||||||
| - **CRITICAL**: Always use full URLs for pull requests that refer to external repositories | ||||||
| - **CORRECT**: https://github.com/openai/codex/pull/6211 | ||||||
| - **INCORRECT**: #6211 (relative reference only works for same repository) | ||||||
| - When copying PR references from release notes, convert `#1234` to full URLs like `https://github.com/owner/repo/pull/1234` | ||||||
|
||||||
| - When copying PR references from release notes, convert `#1234` to full URLs like `https://github.com/owner/repo/pull/1234` | |
| - When copying PR/issue references from release notes, convert `#1234` to full URLs like `https://github.com/owner/repo/pull/1234` for PRs or `https://github.com/owner/repo/issues/1234` for issues |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instruction mentions 'PR/issue references' but only provides an example URL format for pull requests (
/pull/). Consider adding an example for issue references as well (e.g.,https://github.com/openai/codex/issues/1234) to cover both cases mentioned in the text.