Skip to content

Remove unsupported docker-image field from cache-memory schema #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Nov 11, 2025
Merged

Remove unsupported docker-image field from cache-memory schema #3597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0028190
Initial plan
Copilot Nov 11, 2025
8e43916
Remove docker-image field from cache-memory schema
Copilot Nov 11, 2025
1a53496
Remove docker-image from all schema files and update tests
Copilot Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/src/content/docs/reference/frontmatter-full.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,10 +1158,6 @@ tools:
# (optional)
description: "Description of the workflow"

# Docker image to use for the memory MCP server (default: mcp/memory)
# (optional)
docker-image: "example-value"

# Number of days to retain uploaded artifacts (1-90 days, default: repository
# setting)
# (optional)
Expand Down
16 changes: 14 additions & 2 deletions pkg/parser/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,13 +1178,13 @@ func TestValidateIncludedFileFrontmatterWithSchema(t *testing.T) {
wantErr: false,
},
{
name: "valid frontmatter with cache-memory with all options",
name: "valid frontmatter with cache-memory with all valid options",
frontmatter: map[string]any{
"tools": map[string]any{
"cache-memory": map[string]any{
"key": "custom-key",
"retention-days": 30,
"docker-image": "custom/memory:latest",
"description": "Test cache description",
},
},
},
Expand Down Expand Up @@ -1214,6 +1214,18 @@ func TestValidateIncludedFileFrontmatterWithSchema(t *testing.T) {
wantErr: true,
errContains: "got 91, want 90",
},
{
name: "invalid cache-memory with unsupported docker-image field",
frontmatter: map[string]any{
"tools": map[string]any{
"cache-memory": map[string]any{
"docker-image": "custom/memory:latest",
},
},
},
wantErr: true,
errContains: "additional properties 'docker-image' not allowed",
},
{
name: "invalid cache-memory with additional property",
frontmatter: map[string]any{
Expand Down
4 changes: 0 additions & 4 deletions pkg/parser/schemas/included_file_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,6 @@
"type": "string",
"description": "Optional description for the cache that will be shown in the agent prompt"
},
"docker-image": {
"type": "string",
"description": "Docker image to use for the memory MCP server (default: mcp/memory)"
},
"retention-days": {
"type": "integer",
"minimum": 1,
Expand Down
4 changes: 0 additions & 4 deletions pkg/parser/schemas/main_workflow_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2038,10 +2038,6 @@
"type": "string",
"description": "Optional description for the cache that will be shown in the agent prompt"
},
"docker-image": {
"type": "string",
"description": "Docker image to use for the memory MCP server (default: mcp/memory)"
},
"retention-days": {
"type": "integer",
"minimum": 1,
Expand Down
Loading