[spec-review] Update Safe Outputs conformance checker for recent spec changes#37757
Merged
pelikhan merged 1 commit intoJun 8, 2026
Merged
Conversation
Add two new checks validating normative requirements introduced in Safe Outputs specification version 1.22.0 (2026-06-06): - TYPE-006: Verifies push_to_pull_request_branch supports the new base-branch configuration parameter in both the JS handler and the Go config struct (Section 7.3). - TYPE-007: Verifies handler git operations enforce GIT_TERMINAL_PROMPT=0 and an enforced timeout in git_helpers.cjs, ensuring credential-less environments fail fast rather than hanging indefinitely (Section 7.3). Also bumps the script version comment from 1.21.0 to 1.22.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Safe Outputs conformance checker script to align with spec v1.22.0 changes (committed in b25d1ae).
Specification Changes Reviewed
b25d1ae: Migrate daily guardrail ET wording to AI Credits — introduced spec v1.22.0 (2026-06-06)📋 Script Updates & Testing Details
Script Updates
Version Bump
1.21.0to1.22.0New Checks Added
push_to_pull_request_branchbase-branch Parameter — validates that the handler readsbase_branchfrom config and that the Go config struct declaresBaseBranch/base-branch(Section 7.3, v1.22.0).git_helpers.cjssetsGIT_TERMINAL_PROMPT=0and enforces a timeout, and thatpush_to_pull_request_branch.cjsimportsgit_helpers.cjs(Section 7.3, v1.22.0).Specification Requirements Covered
base-branchconfig parameter onpush_to_pull_request_branchwith normative resolution order (explicit config → checkout manifest →origin/HEAD→ API default branch).GIT_TERMINAL_PROMPT=0and an enforced timeout so credential-less environments fail fast rather than hanging.Testing
Ran the updated script successfully — all checks passed:
Related Files
docs/src/content/docs/specs/safe-outputs-specification.mdscripts/check-safe-outputs-conformance.sh