Skip to content

[spec-review] Update Safe Outputs conformance checker for recent spec changes#37757

Merged
pelikhan merged 1 commit into
mainfrom
update-safe-outputs-conformance-v1.22.0-81a19fbb43c50067
Jun 8, 2026
Merged

[spec-review] Update Safe Outputs conformance checker for recent spec changes#37757
pelikhan merged 1 commit into
mainfrom
update-safe-outputs-conformance-v1.22.0-81a19fbb43c50067

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates the Safe Outputs conformance checker script to align with spec v1.22.0 changes (committed in b25d1ae).

Specification Changes Reviewed

  • Commit b25d1ae: Migrate daily guardrail ET wording to AI Credits — introduced spec v1.22.0 (2026-06-06)
📋 Script Updates & Testing Details

Script Updates

Version Bump

  • Updated script header version comment from 1.21.0 to 1.22.0

New Checks Added

  • TYPE-006: push_to_pull_request_branch base-branch Parameter — validates that the handler reads base_branch from config and that the Go config struct declares BaseBranch/base-branch (Section 7.3, v1.22.0).
  • TYPE-007: Hang-Safety for Handler Git Operations — validates that git_helpers.cjs sets GIT_TERMINAL_PROMPT=0 and enforces a timeout, and that push_to_pull_request_branch.cjs imports git_helpers.cjs (Section 7.3, v1.22.0).

Specification Requirements Covered

  1. base-branch config parameter on push_to_pull_request_branch with normative resolution order (explicit config → checkout manifest → origin/HEAD → API default branch).
  2. Git operations MUST run with GIT_TERMINAL_PROMPT=0 and an enforced timeout so credential-less environments fail fast rather than hanging.

Testing

Ran the updated script successfully — all checks passed:

Running TYPE-006: push_to_pull_request_branch base-branch Parameter...
[PASS] TYPE-006: push_to_pull_request_branch supports base-branch configuration parameter (Section 7.3 v1.22.0)
Running TYPE-007: Hang-Safety for Handler Git Operations...
[PASS] TYPE-007: Git operations enforce GIT_TERMINAL_PROMPT=0 and timeout for hang-safety (Section 7.3 v1.22.0)

Conformance Check Summary
Critical Failures: 0  High Failures: 0  Medium Failures: 0  Low Failures: 5
PASS: All checks passed

Related Files

  • Specification: docs/src/content/docs/specs/safe-outputs-specification.md
  • Conformance Script: scripts/check-safe-outputs-conformance.sh

Generated by 🔒 Weekly Safe Outputs Specification Review · 826.4 AIC · ⌖ 40.4 AIC · ⊞ 21K ·

  • expires on Jun 14, 2026, 10:09 PM UTC-08:00

Add two new checks validating normative requirements introduced in
Safe Outputs specification version 1.22.0 (2026-06-06):

- TYPE-006: Verifies push_to_pull_request_branch supports the new
  base-branch configuration parameter in both the JS handler and
  the Go config struct (Section 7.3).

- TYPE-007: Verifies handler git operations enforce GIT_TERMINAL_PROMPT=0
  and an enforced timeout in git_helpers.cjs, ensuring credential-less
  environments fail fast rather than hanging indefinitely (Section 7.3).

Also bumps the script version comment from 1.21.0 to 1.22.0.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added automation documentation Improvements or additions to documentation safe-outputs labels Jun 8, 2026
@pelikhan pelikhan merged commit 803ce67 into main Jun 8, 2026
@pelikhan pelikhan deleted the update-safe-outputs-conformance-v1.22.0-81a19fbb43c50067 branch June 8, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation documentation Improvements or additions to documentation safe-outputs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant