Clarify pr-finisher handling for github-actions[bot] review threads#37996
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Update pr-finisher to require handling GitHub Actions bot reviews
Clarify Jun 9, 2026
pr-finisher handling for github-actions[bot] review threads
Copilot created this pull request from a session on behalf of
pelikhan
June 9, 2026 02:19
View session
pelikhan
approved these changes
Jun 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pr-finisher skill documentation to explicitly treat GitHub Actions bot (github-actions[bot]) review threads as in-scope review work, tightening the “Reviews” merge-ready gate and completion criteria.
Changes:
- Clarifies the Reviews merge-ready condition to include unresolved GitHub Actions bot review threads/comments.
- Updates Address Reviews guidance to explicitly require the existing change → validate → commit/push → reply → resolve flow for in-scope bot-authored threads.
- Tightens the Completion standard to require reply + resolve for in-scope bot review threads.
Show a summary per file
| File | Description |
|---|---|
| .github/skills/pr-finisher/SKILL.md | Makes github-actions[bot] review thread handling explicit in merge-ready criteria, workflow guidance, and completion checklist. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 3
| | Condition | Definition | Agent's signal | | ||
| |---|---|---| | ||
| | **Reviews** | Every unresolved review thread is addressed on its merits, replied to, and resolved. Code changes alone do not satisfy this. | `copilot-review` skill + GraphQL `reviewThreads` | | ||
| | **Reviews** | Every unresolved in-scope review thread is addressed on its merits, replied to, and resolved, including GitHub Actions bot threads/comments (`github-actions[bot]`). Code changes alone do not satisfy this. | `copilot-review` skill + GraphQL `reviewThreads` | |
| ### 2. Address Reviews | ||
|
|
||
| Delegate to the `copilot-review` skill. For each unresolved thread: make change → run relevant local validation → commit → push → reply → resolve. A thread is not handled until reply + resolve both succeed. | ||
| Delegate to the `copilot-review` skill. For each unresolved in-scope thread (including `github-actions[bot]`): make change → run relevant local validation → commit → push → reply → resolve. A thread is not handled until reply + resolve both succeed. |
| - `make fmt`, `make lint`, `make test-unit` all pass (or unrelated pre-existing failures explicitly identified). | ||
| - `make test` was run and fixed when it was part of the failing state; wasm goldens regenerated when required. | ||
| - The `copilot-review` skill addressed all in-scope review threads (reply + resolve succeeded for each). | ||
| - The `copilot-review` skill addressed all in-scope review threads, including GitHub Actions bot review comments/threads (`github-actions[bot]`) (reply + resolve succeeded for each). |
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-finisherdid not explicitly call out GitHub Actions bot review feedback as required review work. This update makesgithub-actions[bot]handling explicit so review completion includes comment replies and thread resolution for bot-authored review threads.Review gate clarification
Workflow behavior update
github-actions[bot], with the existingchange → validate → commit/push → reply → resolveflow.Completion criteria tightening