Skip to content

[WIP] Fix failing GitHub Actions job Integration: Workflow Features #38261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Jun 10, 2026
+8 −1
Merged

[WIP] Fix failing GitHub Actions job Integration: Workflow Features #38261

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aef5756
Initial plan
Copilot Jun 10, 2026
1946279
test: handle escaped AWF JSON in copilot base URL integration assertion
Copilot Jun 10, 2026
413a2fc
test: tolerate escaped AWF JSON in copilot base-url integration test
Copilot Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/workflow/allowed_domains_sanitization_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,9 @@ Test workflow with GITHUB_COPILOT_BASE_URL in engine.env.
// The copilot API target should be derived from the env var and present in the
// AWF JSON config (apiProxy.targets.copilot.host) rather than as a --copilot-api-target
// CLI flag, since network/proxy settings are now expressed via --config JSON file.
if !strings.Contains(lockStr, `"copilot":{"host":"copilot-proxy.corp.example.com"}`) {
copilotHostUnescaped := `"copilot":{"host":"copilot-proxy.corp.example.com"}`
copilotHostEscaped := `\"copilot\":{\"host\":\"copilot-proxy.corp.example.com\"}`
if !strings.Contains(lockStr, copilotHostUnescaped) && !strings.Contains(lockStr, copilotHostEscaped) {
t.Error("Expected copilot API target to be derived from GITHUB_COPILOT_BASE_URL in AWF config JSON")
}

Expand All @@ -716,7 +718,12 @@ Test workflow with GITHUB_COPILOT_BASE_URL in engine.env.
// We search for the allowDomains key followed by its opening "[" and verify the hostname
// appears before the closing "]" of that specific array.
allowDomainsPrefix := `"allowDomains":[`
allowDomainsPrefixEscaped := `\"allowDomains\":[`
allowDomainsIdx := strings.Index(lockStr, allowDomainsPrefix)
if allowDomainsIdx < 0 {
allowDomainsPrefix = allowDomainsPrefixEscaped
allowDomainsIdx = strings.Index(lockStr, allowDomainsPrefixEscaped)
Comment on lines +721 to +725
}
if allowDomainsIdx < 0 {
t.Fatal("allowDomains key not found in compiled lock file")
}
Expand Down