-
Notifications
You must be signed in to change notification settings - Fork 495
Suggest permissions.copilot-requests: write in agent failure issue when COPILOT_GITHUB_TOKEN is missing
#38722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4951fda
Customize agent failure issue for missing COPILOT_GITHUB_TOKEN to sug…
Copilot 1dd58de
Use fenced YAML code block for copilot-requests permission snippet
Copilot 9b32bd9
Merge branch 'main' into copilot/customize-agent-failure-issue
pelikhan eb12d13
Merge branch 'main' into copilot/customize-agent-failure-issue
pelikhan 33bfd58
Address PR review feedback on copilot secret guidance
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Copilot-specific reference URL is untested — if it were accidentally removed, all tests would still pass. The implementation appends a
See: https://github.github.com/gh-aw/reference/engines/#github-copilot-defaultline that is unique to the Copilot branch, but no assertion checks for it.💡 Suggested addition
The generic URL (
/engines/) is already covered by theclaudetest above; the Copilot-specific anchor (#github-copilot-default) is not. Adding this closes the coverage gap and locks in the exact link that users are expected to follow.