Skip to content

fix: remove dispatch-repository dash alias from parser #39639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
+3 −28
Closed

fix: remove dispatch-repository dash alias from parser #39639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cd75fd
Initial plan
Copilot Jun 16, 2026
d46d610
fix: remove dispatch-repository dash alias from parser
Copilot Jun 16, 2026
e84a258
Merge branch 'main' into copilot/add-dispatch-repository-dash-alias
pelikhan Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions pkg/workflow/dispatch_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,12 @@ type DispatchRepositoryConfig struct {
}

// parseDispatchRepositoryConfig parses dispatch_repository configuration from the safe-outputs map.
// Accepts both "dispatch_repository" (underscore, preferred) and "dispatch-repository" (dash, alias).
func (c *Compiler) parseDispatchRepositoryConfig(outputMap map[string]any) *DispatchRepositoryConfig {
dispatchRepositoryLog.Print("Parsing dispatch_repository configuration")

var configData any
var exists bool

// Support both underscore and dash variants
if configData, exists = outputMap["dispatch_repository"]; !exists {
if configData, exists = outputMap["dispatch-repository"]; !exists {
return nil
}
configData, exists := outputMap["dispatch_repository"]
if !exists {
return nil
}

configMap, ok := configData.(map[string]any)
Expand Down
19 changes: 0 additions & 19 deletions pkg/workflow/dispatch_repository_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,25 +90,6 @@ func TestParseDispatchRepositoryConfig_MultipleTools(t *testing.T) {
assert.Equal(t, strPtr("2"), notifyService.Max)
}

// TestParseDispatchRepositoryConfig_DashAlias tests that "dispatch-repository" (dash) also works
func TestParseDispatchRepositoryConfig_DashAlias(t *testing.T) {
compiler := NewCompiler(WithVersion("1.0.0"))

outputMap := map[string]any{
"dispatch-repository": map[string]any{
"trigger_ci": map[string]any{
"workflow": "ci.yml",
"event_type": "ci_trigger",
"repository": "org/target-repo",
},
},
}

config := compiler.parseDispatchRepositoryConfig(outputMap)
require.NotNil(t, config, "Config should be parsed from dash form")
require.Len(t, config.Tools, 1, "Should have 1 tool")
}

// TestParseDispatchRepositoryConfig_Absent tests that nil is returned when key is absent
func TestParseDispatchRepositoryConfig_Absent(t *testing.T) {
compiler := NewCompiler(WithVersion("1.0.0"))
Expand Down
Loading