[aw] Harden PR Sous Chef safe-output emission path#39951
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix workflow failure in PR Sous Chef due to no safe outputs
[aw] Harden PR Sous Chef safe-output emission path
Jun 18, 2026
pelikhan
approved these changes
Jun 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens the PR Sous Chef workflow prompt contract to keep all “write” behavior on MCP safe-output tools, preventing successful runs that fail to persist any safe-output actions and reinforcing the required end-of-run signaling.
Changes:
- Adds an explicit rule requiring direct use of safe-output MCP tools and disallowing
gh/safeoutputsshell write wrappers. - Updates the
add_commentexample to match tool-call-shaped payloads. - Adds a concrete end-of-run
nooptool-call summary example.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pr-sous-chef.md | Tightens PR Sous Chef prompt constraints and examples to steer writes through MCP safe-output tools and reinforce end-of-run signaling. |
| .github/workflows/pr-sous-chef.lock.yml | Regenerates the compiled lock metadata to reflect the updated markdown workflow body hash. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
| @@ -178,6 +178,7 @@ Move open non-draft PRs toward a state where a maintainer can investigate quickl | |||
| 6. If a `pr-processor` call returns non-JSON or an error, record `{pr_number: <N>, skip_reason: "sub_agent_error"}` in the `skipped` array of the run-summary noop payload and move to the next PR without retrying. | |||
| 7. Do not fetch full PR diffs or large file lists unless absolutely required for a skip decision. | |||
| 8. **Never finish without at least one safe-output tool call.** If you have not called `add_comment` or `update_pull_request`, you must call the run-summary `noop` (see **Run summary** below) before finishing. | |||
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Sous Chef reported successful runs with no safe outputs because the agent drifted into non-safe-output write paths (
gh/safeoutputsshell usage), so no persisted safe-output action was recorded. This change tightens prompt constraints to keep all write behavior on MCP safe-output tools and preserve the required end-of-run noop summary.Problem framing
Prompt contract hardening
add_comment,update_pull_request,push_to_pull_request_branch,noop, andreport_incompletefor write/signaling behavior.gh pr comment,gh api ... -X POST, andsafeoutputs ...shell wrappers for writes.Example payload alignment
add_commentguidance to show tool-call-shaped payloads.nooptool-call summary example to reinforce final-run signaling format.{"add_comment":{"pr_number":12345,"body":"<!-- gh-aw-pr-sous-chef-nudge -->\n@copilot review all comments and address unresolved review feedback."}}