Skip to content

Enable Smoke Pi safeoutputs CLI mounting and migrate 20 non-smoke workflows to Pi #40375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 6 commits into from
Jun 19, 2026
Merged

Enable Smoke Pi safeoutputs CLI mounting and migrate 20 non-smoke workflows to Pi #40375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a15d3db
Fix Smoke Pi safeoutputs CLI write path configuration
Copilot Jun 19, 2026
11744e6
Allow wazero cache writes in Smoke Pi sandbox
Copilot Jun 19, 2026
cda969a
fix pi mcp config rendering for safeoutputs cli mounting
Copilot Jun 19, 2026
f6eb14b
Remove custom Smoke Pi sandbox mounts
Copilot Jun 19, 2026
dd3a355
Switch 20 non-smoke workflows to Pi engine
Copilot Jun 19, 2026
6bf8621
Fix review threads: escape MCP heredoc env vars, enable Pi firewall, …
Copilot Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
214 changes: 60 additions & 154 deletions .github/workflows/ab-testing-advisor.lock.yml
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion .github/workflows/ab-testing-advisor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ description: Daily A/B testing advisor that picks a random agentic workflow with
emoji: 🧪
engine:
bare: true
id: copilot
id: pi

@github-actions github-actions Bot Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/zoom-out] Migrating 20 non-smoke workflows to an experimental engine in a single PR is a meaningful blast radius. Pi sets GH_AW_INFO_FIREWALL_ENABLED: false and GH_AW_INFO_AWF_VERSION: "" in compiled lock files, meaning all migrated workflows run without the AWF firewall container stack — a significant security posture change compared to Copilot.

No blocking issue if this is intentional policy for Pi, but worth confirming explicitly in the PR description or a follow-up ADR so reviewers don't have to infer it from the lock file diffs.

Copilot AI Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged — the Pi firewall posture gap was unintentional. Fixed in 6bf8621 by adding enableFirewallByDefaultForPi (matching the pattern of enableFirewallByDefaultForCopilot and enableFirewallByDefaultForClaude). All Pi workflows with sandbox: agent: awf now get GH_AW_INFO_FIREWALL_ENABLED: "true" and the AWF firewall stack, putting them on the same security posture as Copilot and Claude workflows.

model: copilot/gpt-5.4
strict: true
timeout-minutes: 30
tools:
Expand Down
232 changes: 85 additions & 147 deletions .github/workflows/agent-persona-explorer.lock.yml
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions .github/workflows/agent-persona-explorer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ description: Explores agentic-workflows custom agent behavior by generating soft
on: daily
max-daily-ai-credits: 10000
engine:
id: copilot
model: gpt-5.4-mini
id: pi
model: copilot/gpt-5.4
permissions:
contents: read
actions: read
Expand Down Expand Up @@ -37,6 +37,8 @@ experiments:
# Note: max-turns not available for default Copilot engine (Claude only)
tools:
cli-proxy: true
github:
mode: gh-proxy
agentic-workflows:
cache-memory: true
safe-outputs:
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/ai-moderator.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 17 additions & 17 deletions .github/workflows/api-consumption-report.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 14 additions & 14 deletions .github/workflows/approach-validator.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 17 additions & 17 deletions .github/workflows/audit-workflows.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading