Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[docs] Self-healing documentation fixes from issue analysis - 2026-06-20 #40402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[docs] Self-healing documentation fixes from issue analysis - 2026-06-20 #40402
Changes from all commits
f4d5f58File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Factual error: the claim that
engine.commanddelegates extension installation to the same executable is incorrect — extensions are silently skipped whenengine.commandis set.💡 What the code actually does
GetInstallationStepsinpkg/workflow/pi_engine.gohas an early-return guard:This causes the function to return an empty step list before it ever reaches the extension-install loop. The
commandName = workflowData.EngineConfig.Commandassignment inside that loop is dead code.A user who sets both
engine.commandandengine.extensionswill find their extensions are never installed — no error is emitted, just silence.Suggested correction:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/grill-with-docs] The claim about
engine.commandis contradicted by the source code — extensions are not installed whenengine.commandis set.💡 Details
pi_engine.go:GetInstallationStepshas an early return whenengine.commandis set:The
commandName = workflowData.EngineConfig.Commandbranch inside the extensions loop (line 206) is therefore dead code — it can never be reached.The last sentence should instead read something like:
This matters for users who supply a custom
engine.commandand expect extensions to be auto-installed.Uh oh!
There was an error while loading. Please reload this page.