Skip to content

Smoke Copilot: require dispatch_workflow.inputs.message for haiku-printer#40550

Merged
pelikhan merged 2 commits into
mainfrom
copilot/fix-smoke-copilot-safety-outputs
Jun 21, 2026
Merged

Smoke Copilot: require dispatch_workflow.inputs.message for haiku-printer#40550
pelikhan merged 2 commits into
mainfrom
copilot/fix-smoke-copilot-safety-outputs

Conversation

Copilot AI commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot’s safe_outputs job can fail when dispatch_workflow targets haiku-printer without the required message input, causing a 422 from the dispatch API and failing the whole safe-output processing step. This change removes that ambiguity at the source by making the required input explicit in the workflow prompt contract.

  • Problem alignment

    • Clarifies the dispatch instruction so the agent must provide inputs.message (non-empty) when calling dispatch_workflow for haiku-printer.
  • Workflow prompt update (.github/workflows/smoke-copilot.md)

    • Updated test requirement Fix orphan removal on "gh aw remove" #11 from a generic “dispatch with a haiku” instruction to an explicit input contract:
      • include inputs.message
      • value must be a non-empty testing/automation haiku
  • Behavioral impact

    • Ensures generated safe output matches haiku-printer.yml’s workflow_dispatch.inputs.message.required: true contract, preventing this specific dispatch-time validation failure.
11. Workflow dispatch: call `dispatch_workflow` for `haiku-printer` and include `inputs.message` with an original testing/automation haiku (non-empty string).

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix safe_outputs job failure in Smoke Copilot Smoke Copilot: require dispatch_workflow.inputs.message for haiku-printer Jun 21, 2026
Copilot AI requested a review from pelikhan June 21, 2026 03:14
@pelikhan pelikhan marked this pull request as ready for review June 21, 2026 03:20
Copilot AI review requested due to automatic review settings June 21, 2026 03:20
@pelikhan pelikhan merged commit fbc8545 into main Jun 21, 2026
1 check passed
@pelikhan pelikhan deleted the copilot/fix-smoke-copilot-safety-outputs branch June 21, 2026 03:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Smoke Copilot workflow prompt contract to prevent a known dispatch_workflow failure mode by explicitly requiring the haiku-printer dispatch to include a non-empty inputs.message.

Changes:

  • Tightened test requirement #11 to require dispatch_workflow.inputs.message when dispatching haiku-printer.
  • Clarified that the haiku must be a non-empty testing/automation haiku.
Show a summary per file
File Description
.github/workflows/smoke-copilot.md Makes the haiku-printer dispatch requirement explicit by requiring inputs.message to avoid dispatch-time validation failures.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment on lines 186 to 189
9. Artifact upload (only if build passes): stage `./gh-aw` at `$RUNNER_TEMP/gh-aw/safeoutputs/upload-artifacts/gh-aw` and call `upload_artifact` with `path: "gh-aw"`.
10. Discussion create: call `create_discussion` in `announcements` with label `ai-generated`, title `copilot was here`, temp ID `aw_smoke_discussion`.
11. Workflow dispatch: call `dispatch_workflow` for `haiku-printer` with an original testing/automation haiku.
11. Workflow dispatch: call `dispatch_workflow` for `haiku-printer` and include `inputs.message` with an original testing/automation haiku (non-empty string).
12. PR review tools: add 1-2 inline `create_pull_request_review_comment` comments, submit review with event `COMMENT`, then reply to most recent existing review comment ID when available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants