Skip to content

Allow Daily Safe Output Integrator to create its temp coverage script - #42028

Merged
pelikhan merged 4 commits into
mainfrom
copilot/investigate-code-simplifier-issues
Jun 28, 2026
Merged

Allow Daily Safe Output Integrator to create its temp coverage script#42028
pelikhan merged 4 commits into
mainfrom
copilot/investigate-code-simplifier-issues

Conversation

Copilot AI commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

The Daily Safe Output Integrator was repeatedly exhausting its shell denial budget instead of completing its safe-output coverage pass. The workflow prompt expected a temporary analysis script under /tmp/gh-aw/agent/, but the shell allowlist did not permit creating that file.

  • Workflow allowlist

    • Adds an explicit shell allowlist entry for creating the temporary Python script the workflow already expects:
      tools:
        bash:
          - cat > /tmp/gh-aw/agent/*.py
          - python3 *
  • Prompt guidance

    • Tightens the workflow instructions to steer the agent toward the allowed /tmp/gh-aw/agent/ path.
    • Clarifies that the agent should not retry alternate shell-redirection paths once this path is available.
  • Regression coverage

    • Adds a focused workflow test that verifies:
      • the markdown source includes the temp-script allowlist entry
      • the compiled lock file carries the corresponding shell(...) permission

This keeps the change scoped to the failing workflow while locking in the expected temp-script creation path in both source and compiled output.


pr-sous-chef run https://github.com/github/gh-aw/actions/runs/28317576838

Generated by 👨‍🍳 PR Sous Chef · 70.2 AIC · ⌖ 1.04 AIC · ⊞ 17.1K ·

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate failures in Code Simplifier workflow Allow Daily Safe Output Integrator to create its temp coverage script Jun 28, 2026
Copilot AI requested a review from pelikhan June 28, 2026 07:53
@pelikhan
pelikhan marked this pull request as ready for review June 28, 2026 08:59
Copilot AI review requested due to automatic review settings June 28, 2026 08:59
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot merge main and recompile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the “Daily Safe Output Integrator” agentic workflow so it can create a temporary Python analysis script under /tmp/gh-aw/agent/ without exhausting its shell-denial budget, and adds a regression test to ensure both the workflow source and compiled lock carry the expected permission.

Changes:

  • Adds a bash tool allowlist entry for cat > /tmp/gh-aw/agent/*.py in the workflow markdown source.
  • Tightens workflow prompt guidance to steer script creation to /tmp/gh-aw/agent/.
  • Adds a Go unit test to assert the source and compiled lock include the expected allowlist/shell(...) permission.
Show a summary per file
File Description
pkg/workflow/daily_safe_output_integrator_workflow_test.go New test asserting the workflow source and lock file include the temp-script allowlist and compiled shell(...) permission.
.github/workflows/daily-safe-output-integrator.md Adds the cat > /tmp/gh-aw/agent/*.py allowlist entry and new prompt guidance for temp script creation.
.github/workflows/daily-safe-output-integrator.lock.yml Compiled workflow update to carry the corresponding --allow-tool shell(cat > /tmp/gh-aw/agent/*.py) permission.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment on lines +90 to +91
- Create that temporary script with the edit tool or the allowed `cat > /tmp/gh-aw/agent/*.py` bash command, then run it with `python3`.
- Do not retry alternate shell-redirection paths; use only the allowed `/tmp/gh-aw/agent/` path.
}

for _, expected := range []string{
"- Create that temporary script with the edit tool or the allowed `cat > /tmp/gh-aw/agent/*.py` bash command, then run it with `python3`.",
Copilot AI and others added 2 commits June 28, 2026 09:13
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, refresh the branch if needed, address any unresolved review feedback, and rerun checks so this PR can move forward.

Generated by 👨‍🍳 PR Sous Chef · 70.2 AIC · ⌖ 1.04 AIC · ⊞ 17.1K ·

@pelikhan
pelikhan merged commit ca4b91c into main Jun 28, 2026
1 check failed
@pelikhan
pelikhan deleted the copilot/investigate-code-simplifier-issues branch June 28, 2026 09:34
Copilot stopped work on behalf of gh-aw-bot due to an error June 28, 2026 09:34
Copilot AI requested a review from gh-aw-bot June 28, 2026 09:34
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.82.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants