Allow Daily Safe Output Integrator to create its temp coverage script - #42028
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot merge main and recompile |
There was a problem hiding this comment.
Pull request overview
This PR updates the “Daily Safe Output Integrator” agentic workflow so it can create a temporary Python analysis script under /tmp/gh-aw/agent/ without exhausting its shell-denial budget, and adds a regression test to ensure both the workflow source and compiled lock carry the expected permission.
Changes:
- Adds a
bashtool allowlist entry forcat > /tmp/gh-aw/agent/*.pyin the workflow markdown source. - Tightens workflow prompt guidance to steer script creation to
/tmp/gh-aw/agent/. - Adds a Go unit test to assert the source and compiled lock include the expected allowlist/
shell(...)permission.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/daily_safe_output_integrator_workflow_test.go |
New test asserting the workflow source and lock file include the temp-script allowlist and compiled shell(...) permission. |
.github/workflows/daily-safe-output-integrator.md |
Adds the cat > /tmp/gh-aw/agent/*.py allowlist entry and new prompt guidance for temp script creation. |
.github/workflows/daily-safe-output-integrator.lock.yml |
Compiled workflow update to carry the corresponding --allow-tool shell(cat > /tmp/gh-aw/agent/*.py) permission. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Low
| - Create that temporary script with the edit tool or the allowed `cat > /tmp/gh-aw/agent/*.py` bash command, then run it with `python3`. | ||
| - Do not retry alternate shell-redirection paths; use only the allowed `/tmp/gh-aw/agent/` path. |
| } | ||
|
|
||
| for _, expected := range []string{ | ||
| "- Create that temporary script with the edit tool or the allowed `cat > /tmp/gh-aw/agent/*.py` bash command, then run it with `python3`.", |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot please run the
|
|
🎉 This pull request is included in a new release. Release: |
The Daily Safe Output Integrator was repeatedly exhausting its shell denial budget instead of completing its safe-output coverage pass. The workflow prompt expected a temporary analysis script under
/tmp/gh-aw/agent/, but the shell allowlist did not permit creating that file.Workflow allowlist
Prompt guidance
/tmp/gh-aw/agent/path.Regression coverage
shell(...)permissionThis keeps the change scoped to the failing workflow while locking in the expected temp-script creation path in both source and compiled output.
pr-sous-chef run https://github.com/github/gh-aw/actions/runs/28317576838