Skip to content

eslint-factory: complete test suite for require-parseInt-radix #42042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jun 28, 2026
Merged

eslint-factory: complete test suite for require-parseInt-radix #42042

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2891a6
Initial plan
Copilot Jun 28, 2026
bdf43ba
eslint-factory: complete test suite for require-parseInt-radix
Copilot Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 38 additions & 10 deletions eslint-factory/src/rules/require-parseInt-radix.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,28 @@ describe("require-parseInt-radix", () => {
it("valid: explicit radix is accepted for direct and computed access", () => {
cjsRuleTester.run("require-parseInt-radix", requireParseIntRadixRule, {
valid: [
`parseInt(value, 10);`,
`Number.parseInt(value, 10);`,
`Number["parseInt"](value, 10);`,
`globalThis.parseInt(value, 10);`,
`globalThis["parseInt"](value, 10);`,
`window.parseInt(value, 10);`,
`window["parseInt"](value, 10);`,
`global.parseInt(value, 10);`,
`global["parseInt"](value, 10);`,
`parseInt(str, 10);`,
`parseInt(str, 16);`,
`Number.parseInt(str, 10);`,
`Number["parseInt"](str, 10);`,
`globalThis.parseInt(str, 10);`,
`globalThis["parseInt"](str, 10);`,
`window.parseInt(str, 10);`,
`window["parseInt"](str, 10);`,
`global.parseInt(str, 10);`,
`global["parseInt"](str, 10);`,
],
invalid: [],
});
});

it("valid: non-parseInt calls are not flagged", () => {
cjsRuleTester.run("require-parseInt-radix", requireParseIntRadixRule, {
valid: [`foo.parseInt(x);`, `parseFloat(x);`],
invalid: [],
});
});

it("valid: aliased and destructured bindings remain out of scope", () => {
esmRuleTester.run("require-parseInt-radix", requireParseIntRadixRule, {
valid: [
Expand All @@ -47,10 +55,30 @@ describe("require-parseInt-radix", () => {
});
});

it("invalid: computed Number.parseInt access without radix is flagged", () => {
it("invalid: global parseInt without radix is flagged", () => {
cjsRuleTester.run("require-parseInt-radix", requireParseIntRadixRule, {
valid: [],
invalid: [
{
code: `parseInt(str);`,
errors: [{ messageId: "requireRadix" }],
},
{
code: `parseInt(str.trim());`,
errors: [{ messageId: "requireRadix" }],
},
],
});
});

it("invalid: Number.parseInt without radix is flagged (direct and computed access)", () => {
cjsRuleTester.run("require-parseInt-radix", requireParseIntRadixRule, {
valid: [],
invalid: [
{
code: `Number.parseInt(str);`,
errors: [{ messageId: "requireRadix" }],
},
{
code: `Number["parseInt"](value);`,
errors: [{ messageId: "requireRadix" }],
Expand Down