eslint-factory: broaden no-unsafe-catch-error-property to flag .status, .cause, .name

[Copilot]

no-unsafe-catch-error-property (and its promise variant) only flagged .message, .stack, .code on unguarded caught error variables — missing .status accesses like if (err.status === 404) that are common in HTTP error handling.

Changes

• Broadened UNSAFE_PROPERTIES in both no-unsafe-catch-error-property and no-unsafe-promise-catch-error-property to include status, cause, and name
• Added typeof err === 'object' as an accepted guard (strict === only; alongside existing instanceof Error and getErrorMessage guards) — real call sites that check typeof err === 'object' before reading .status are no longer false positives
• New RuleTester cases for all three new properties (invalid without guard) and typeof guard variants (valid)

// Now flagged:
try { ... } catch (err) { if (err.status === 404) { } }
//                              ^^^^^^^^^^

// Still suppressed — typeof guard recognized:
try { ... } catch (err) { if (typeof err === 'object') { doSomething(err.status); } }

[Copilot]

Pull request overview

This PR updates the eslint-factory “unsafe catch error property” rules to catch additional common error-property accesses (notably HTTP-style .status) and adds an additional guard pattern (typeof err === 'object') to reduce false positives at real call sites.

Changes:

• Expanded both rules’ UNSAFE_PROPERTIES to include status, cause, and name.
• Added recognition of typeof <errVar> === 'object' (and the reversed literal form) as an accepted guard in both rules.
• Added RuleTester coverage for the new properties and the new typeof guard behavior.

Show a summary per file

File	Description
eslint-factory/src/rules/no-unsafe-promise-catch-error-property.ts	Expands unsafe properties and adds typeof … === 'object' guard detection for .catch() callbacks.
eslint-factory/src/rules/no-unsafe-promise-catch-error-property.test.ts	Adds new valid/invalid cases for .status, .cause, .name, including typeof guard variants.
eslint-factory/src/rules/no-unsafe-catch-error-property.ts	Expands unsafe properties and adds typeof … === 'object' guard detection for catch (err) blocks.
eslint-factory/src/rules/no-unsafe-catch-error-property.test.ts	Adds new valid/invalid cases for .status, .cause, .name, and typeof guard variants (including suggestion expectations).

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 4/4 changed files
• Comments generated: 5
• Review effort level: Low

[github-actions]

🤖 PR Triage — §28376613466

Field	Value
Category	chore (tooling)
Risk	🟢 Low
Priority	🟢 Low
Score	20 / 100
Action	⏸️ defer
Age	1.5h

Score breakdown: Impact 10 + Urgency 5 + Quality 5

Rationale: Broadens the no-unsafe-catch-error-property eslint rule to catch .status, .cause, .name accesses in addition to .message/.stack/.code. Good quality improvement (203+/9−, 4 files) but draft with no CI yet. Non-urgent tooling change — defer until promoted from draft and CI confirms no regressions.

Generated by 🔧 PR Triage Agent · 93.2 AIC · ⌖ 14.6 AIC · ⊞ 5.4K · ◷

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.82.0