pin claude action#44
Merged
Merged
Conversation
dsyme
approved these changes
Aug 13, 2025
pelikhan
added a commit
that referenced
this pull request
Sep 4, 2025
* Add create-discussion safe output type with REST API implementation and validation support (#43) * Initial plan * Add create-discussion safe output type Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Convert create-discussion from GraphQL to REST API and remove discussions:write permission requirement Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add create-discussion validation support to collect_ndjson_output.cjs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Revert package-lock.json name change from gh-aw-copilots back to gh-aw Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com> * Add JSON repair capabilities with graceful error handling for LLM-generated malformed JSON (#42) * Initial plan * Implement JSON repair capabilities for safe-output JSONL parser Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add comprehensive test coverage for JSON repair functionality - Added 16 new test cases covering various JSON repair scenarios - Tests include mixed quote types, bracket issues, Unicode chars, complex nesting - Added graceful failure tests for edge cases beyond repair capabilities - All 190 JavaScript tests now pass, including 41 JSONL parser tests - Tests validate robustness of LLM-generated JSON handling Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Improve JSON parsing error handling: print to console and return undefined instead of throwing exceptions Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Refactor JSON parsing logic: streamline error handling and improve validation for output types * Add JSON repair and parsing functions to handle malformed input * Fix test cases for JSON repair functionality Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com> * Add create-pull-request-review-comment safe-output type with comprehensive validation (#44) * Add prettier integration for automated .cjs file formatting (#46) * Fix Codex execution failure not failing GitHub Actions step (#48) * Add precise JSON path to source location mapping for frontmatter validation errors (#47) * Add network permissions validation and settings generation for Claude * Add conditional task execution for PRs with 'prr' in title for Claude and Codex workflows --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jun 20, 2026
Adds a new custom go/analysis linter that detects the inline anti-pattern
of wrapping fmt.Sprintf inside errors.New:
errors.New(fmt.Sprintf("invalid engine: %s", id))
This should always be replaced with:
fmt.Errorf("invalid engine: %s", id)
Using fmt.Errorf is shorter, avoids a redundant heap allocation for the
intermediate string, and supports %w for error wrapping when needed.
Evidence (found by linter-miner run #44):
- Code-pattern scan identified 4 instances across pkg/workflow:
engine.go, engine_definition.go, engine_validation.go,
runtime_validation.go
- Not covered by any commonly-enabled golangci-lint rule
Implementation follows the largefunc conventions:
- pkg/linters/sprintferrorsnew/sprintferrorsnew.go (Analyzer)
- pkg/linters/sprintferrorsnew/sprintferrorsnew_test.go
- pkg/linters/sprintferrorsnew/testdata/src/sprintferrorsnew/ (fixtures)
- cmd/linters/main.go updated to register the analyzer
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.