fix(designer): add dismiss-pull-request-review to Safe Output Mapping; fix head limits in drift audit#44209
Conversation
…d fix head limits in audit Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
… drift audit Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot merge main and recompile |
…t-audit Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done. Merged main and recompiled — all 258 workflows compiled cleanly with zero errors. |
|
@copilot revert lock.yml file changes |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done. All unrelated lock.yml files restored to |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the agentic workflow designer skill and its drift-audit workflow to better reflect supported PR review actions and to capture more reference/table context during drift checks.
Changes:
- Added a new command-to-action mapping for dismissing a PR review.
- Increased the number of table rows captured by the drift-audit extraction step to reduce missed content.
- Regenerated the gh-aw lockfile to reflect updated source workflow content/hashes.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/data/agentic_workflow_designer_skill.md | Documents the new “dismiss a PR review” capability in the CLI-packaged skill data. |
| .github/workflows/designer-drift-audit.md | Expands extracted table output limits to include more context in drift auditing. |
| .github/workflows/designer-drift-audit.lock.yml | Regenerated lockfile reflecting the updated drift-audit workflow extraction limits/metadata. |
| .github/skills/agentic-workflow-designer/SKILL.md | Documents the new “dismiss a PR review” capability in the designer skill. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Low
| echo "---" | ||
| # Table rows with config keywords | ||
| grep -E '^\|.*\|' "$ref" | grep -ivE '^\|[\s-]+\|' | head -40 | ||
| grep -E '^\|.*\|' "$ref" | grep -ivE '^\|[\s-]+\|' | head -80 |
| echo "---" | ||
| # Decision heuristic tables | ||
| grep -E '^\|.*\|' "$SKILL" | grep -ivE '^\|[\s-]+\|' | head -60 | ||
| grep -E '^\|.*\|' "$SKILL" | grep -ivE '^\|[\s-]+\|' | head -150 |
| run: "mkdir -p /tmp/gh-aw/data\n\n# Core reference docs the designer depends on\nREFS=(\n \".github/aw/syntax.md\"\n \".github/aw/safe-outputs.md\"\n \".github/aw/network.md\"\n \".github/aw/patterns.md\"\n \".github/aw/subagents.md\"\n \".github/aw/token-optimization.md\"\n \".github/aw/triggers.md\"\n \".github/aw/create-agentic-workflow.md\"\n)\n\n# Extract key sections from each reference doc:\n# - H2/H3 headings (structural outline)\n# - YAML frontmatter field names\n# - Table rows containing mapping keywords\nfor ref in \"${REFS[@]}\"; do\n if [ -f \"$ref\" ]; then\n basename=$(basename \"$ref\" .md)\n {\n echo \"=== $ref ===\"\n # Headings\n grep -n '^##' \"$ref\" | head -50\n echo \"---\"\n # Frontmatter keys (between --- delimiters)\n sed -n '/^---$/,/^---$/p' \"$ref\" | grep -E '^\\w+:' | head -30\n echo \"---\"\n # Table rows with config keywords\n grep -E '^\\|.*\\|' \"$ref\" | grep -ivE '^\\|[\\s-]+\\|' | head -80\n echo \"===\"\n } > \"/tmp/gh-aw/data/ref-${basename}.txt\"\n fi\ndone\n" | ||
| - name: Extract designer file metadata | ||
| run: "# Skill file\nSKILL=\".github/skills/agentic-workflow-designer/SKILL.md\"\nif [ -f \"$SKILL\" ]; then\n {\n echo \"=== SKILL.md ===\"\n grep -n '^##' \"$SKILL\" | head -50\n echo \"---\"\n # Decision heuristic tables\n grep -E '^\\|.*\\|' \"$SKILL\" | grep -ivE '^\\|[\\s-]+\\|' | head -60\n echo \"---\"\n # Explicit references to .github/aw/ files\n grep -n '\\.github/aw/' \"$SKILL\" || true\n echo \"===\"\n } > /tmp/gh-aw/data/designer-skill.txt\nfi\n\n# Agent file\nAGENT=\".github/agents/interactive-agent-designer.agent.md\"\nif [ -f \"$AGENT\" ]; then\n {\n echo \"=== interactive-agent-designer.agent.md ===\"\n grep -n '^##' \"$AGENT\" | head -50\n echo \"---\"\n grep -E '^\\|.*\\|' \"$AGENT\" | grep -ivE '^\\|[\\s-]+\\|' | head -60\n echo \"---\"\n grep -n '\\.github/aw/' \"$AGENT\" || true\n echo \"===\"\n } > /tmp/gh-aw/data/designer-agent.txt\nfi\n" | ||
| run: "# Skill file\nSKILL=\".github/skills/agentic-workflow-designer/SKILL.md\"\nif [ -f \"$SKILL\" ]; then\n {\n echo \"=== SKILL.md ===\"\n grep -n '^##' \"$SKILL\" | head -50\n echo \"---\"\n # Decision heuristic tables\n grep -E '^\\|.*\\|' \"$SKILL\" | grep -ivE '^\\|[\\s-]+\\|' | head -150\n echo \"---\"\n # Explicit references to .github/aw/ files\n grep -n '\\.github/aw/' \"$SKILL\" || true\n echo \"===\"\n } > /tmp/gh-aw/data/designer-skill.txt\nfi\n\n# Agent file\nAGENT=\".github/agents/interactive-agent-designer.agent.md\"\nif [ -f \"$AGENT\" ]; then\n {\n echo \"=== interactive-agent-designer.agent.md ===\"\n grep -n '^##' \"$AGENT\" | head -50\n echo \"---\"\n grep -E '^\\|.*\\|' \"$AGENT\" | grep -ivE '^\\|[\\s-]+\\|' | head -60\n echo \"---\"\n grep -n '\\.github/aw/' \"$AGENT\" || true\n echo \"===\"\n } > /tmp/gh-aw/data/designer-agent.txt\nfi\n" |
|
🎉 This pull request is included in a new release. Release: |
Add three new user-facing terms from today's commits: - dismiss-pull-request-review: New safe output capability for dismissing PR reviews authored by the workflow actor (PR #44209) - COPILOT_GITHUB_TOKEN: Fine-grained PAT for Copilot inference, now validated in activation job for OAuth token detection (PR #44204) - restore-memory (jobs.<job-id>.restore-memory): New custom job field for read-only memory store restore in deterministic jobs (PR #44214) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Designer Drift Audit reported two categories of drift in
SKILL.md: one genuinely missing safe output type, and 15 falsely reported missing network ecosystem identifiers caused by a truncation bug in the audit script itself.Changes
Fix: missing
dismiss-pull-request-reviewmapping"dismiss a PR review" → \dismiss-pull-request-review`row to the Safe Output Mapping table in.github/skills/agentic-workflow-designer/SKILL.md`pkg/cli/data/agentic_workflow_designer_skill.md(enforced byTestCheckedInAgenticWorkflowDesignerSkillMatchesEmbeddedTemplate)Fix: audit script truncation causing 15 false-positive network identifiers
The
designer-drift-audit.mdextraction steps usedhead -60for SKILL.md table rows andhead -40for reference docs. With 13 trigger rows + 25 safe output rows + 39+ network rows, the network mapping was silently truncated starting at row 61 — makingbazel,clojure,deno,elixir,fonts,julia,kotlin,lua,node-cdns,ocaml,powershell,r,scala,zig, anddev-toolsinvisible to the LLM auditor.Raised limits:
head -60→head -150head -40→head -80