Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split engine provider selection from harness execution and route Claude/Codex via reflected CAPI endpoints #45490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Split engine provider selection from harness execution and route Claude/Codex via reflected CAPI endpoints #45490
Changes from all commits
74ad4ddb97f50057546cf6b21414ab43990File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/codebase-design]
configureCodexProviderFromReflectrewrites the TOMLbase_urlto a Copilot endpoint, butvalidateCodexOpenAIBaseURLFromReflectimmediately re-reads the file and compares the rewritten value against the expected OpenAI gateway port, causing a spurious validation failure whenprovider=github.💡 Details
After the rewrite the TOML
base_urlpoints to the Copilot endpoint (e.g. port 10002). The existing validation then flags this as unexpected because it still expects the OpenAI port.Fix: skip
validateCodexOpenAIBaseURLFromReflectwhenproviderConfig.configuredis true and the resolved provider is notopenai, or extend the validation function to accept the resolved provider for correct comparison.@copilot please address this.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.