[docs] Self-healing documentation fixes from issue analysis - 2026-07-15#45578
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
Thanks for improving the docs around the Suggested next step: close this PR and open an issue describing the documentation gap and proposed edits so a core team member can land it through the project's agentic workflow.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #45578 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100). |
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. PR #45578 contains only documentation changes (docs/src/content/docs/reference/artifacts.md). Test Quality Sentinel analysis skipped. |
|
✅ PR Code Quality Reviewer completed the code quality review. |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
There was a problem hiding this comment.
Pull request overview
Documents the evals artifact and its CLI access paths.
Changes:
- Adds
evalsto artifact reference tables. - Documents contents, download commands, and
--evals.
Show a summary per file
| File | Description |
|---|---|
docs/src/content/docs/reference/artifacts.md |
Adds evals artifact reference documentation. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Medium
|
|
||
| ### Contents | ||
|
|
||
| - `evals.jsonl` — Per-question BinEval evaluation results (YES/NO records) produced by running the declared evaluation questions against the agent output |
|
|
||
| ```bash | ||
| # Download only the evals artifact | ||
| gh aw logs <run-id> --artifacts evals |
There was a problem hiding this comment.
Documentation additions are accurate and consistent with the codebase: constants.EvalsArtifactName, EvalsResultFilename, and the --evals flag on gh aw audit/gh aw logs all match the documented behavior.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · 14.1 AIC · ⌖ 4.92 AIC · ⊞ 5K
There was a problem hiding this comment.
Documentation additions are accurate and consistent with the source code. The constants.EvalsArtifactName, evals.jsonl filename, and --evals flag behavior all match the implementation in pkg/constants/job_constants.go and pkg/cli/audit.go. New section follows existing artifact documentation patterns correctly.
🔎 Code quality review by PR Code Quality Reviewer · 33.8 AIC · ⌖ 4.27 AIC · ⊞ 5.6K
Comment /review to run again
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — one minor observation on the --evals usage example.
📋 Key Themes & Highlights
Positive Highlights
- ✅ Constants and filenames verified accurate (
EvalsArtifactName,EvalsResultFilename) - ✅ Correct placement in Quick Reference table, Artifact Sets table, and dedicated section
- ✅
--evalsflag behaviour accurately described (skips runs without evals results) - ✅ BinEval terminology consistent with codebase usage
Finding
- The
gh aw audit <run-id> --evalsexample on line 233 implies a run-id is required, but--evalsis primarily a multi-run list filter. See inline comment.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 28.1 AIC · ⌖ 4.44 AIC · ⊞ 6.7K
Comment /matt to run again
|
|
||
| ```bash | ||
| # Audit only runs that contain evals results | ||
| gh aw audit <run-id> --evals |
There was a problem hiding this comment.
[/grill-with-docs] The example gh aw audit <run-id> --evals implies --evals requires a specific run ID, but the flag is primarily a multi-run filter (skip runs without evals results). With a single run-id it still works, but the usage pattern shown here is the less common case.
💡 Suggested revision
Consider showing the multi-run (list) form first, which is the primary use case:
# Audit all runs, skipping those without evals results
gh aw audit --evals
# Or narrow to a specific run
gh aw audit <run-id> --evalsAlso worth noting: gh aw logs supports the same --evals flag (gh aw logs --evals) — adding a cross-reference or example here would make the docs consistent.
@copilot please address this.
Summary
Documents the
evalsartifact in the artifacts reference page.Changes
docs/src/content/docs/reference/artifacts.mdevalsentry to the artifact summary table (constants.EvalsArtifactName, Single-file,evals.jsonl).evalsrow to the--artifactsfilter alias table.## evalssection: conditional upload (only whenevalsdeclared in frontmatter), contents (evals.jsonlBinEval YES/NO records), access commands, andgh aw audit --evalsflag behaviour.Type
docs— documentation only, no code changes.Affected components
docs/src/content/docs/reference/artifacts.mdNotes
No code or test changes. Adds missing reference documentation for the
evalsartifact.