ci: enforce bytesbufferstring, ioutildeprecated, mapdeletecheck linters - #45631
Merged
Conversation
5 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add three clean, type-resolved linters to CI enforcement
ci: enforce bytesbufferstring, ioutildeprecated, mapdeletecheck linters
Jul 15, 2026
pelikhan
marked this pull request as ready for review
July 15, 2026 05:06
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI enforcement for three existing custom Go analyzers.
Changes:
- Enables
bytesbufferstring,ioutildeprecated, andmapdeletecheck. - Applies enforcement to native and WASM lint runs.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Adds all three analyzers to both custom-linter invocations. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three analyzers in the registry had zero production violations and met the full enforcement bar (type-resolved, nolint suppression, test-file skip, autofix golden coverage where applicable) but were not gated in CI — allowing silent regressions.
Changes
.github/workflows/cgo.yml— adds-bytesbufferstring -ioutildeprecated -mapdeletechecktoLINTER_FLAGSon both the default run and theGOOS=js GOARCH=wasmrunbytesbufferstringstring(buf.Bytes())→buf.String()(value receiver only)ioutildeprecatedio/ioutilusagemapdeletecheckif _, ok := m[k]; ok { delete(m, k) }→delete(m, k)