Skip to content

Update root help test to stop rejecting newly added commands#45683

Merged
pelikhan merged 3 commits into
mainfrom
copilot/fix-issue-in-help-output
Jul 15, 2026
Merged

Update root help test to stop rejecting newly added commands#45683
pelikhan merged 3 commits into
mainfrom
copilot/fix-issue-in-help-output

Conversation

Copilot AI commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

CI on main was failing in TestMainFunction/root_command_help because the test still asserted that bootstrap and setup must not appear in gh aw --help, which is no longer true after CLI command additions. This change removes those stale constraints so the test tracks real regressions instead of blocking valid command-surface growth.

  • Problem alignment

    • cmd/gh-aw/main_entry_test.go had hard-coded negative assertions for command tokens that are now legitimately present in root help output.
  • Test behavior change

    • Removed brittle NotContains checks for " bootstrap " and " setup " from TestMainFunction/root_command_help.
    • Kept existing assertions that the help command executes successfully and emits output.
  • Why this improves durability

    • Prevents false CI failures when command inventory evolves.
    • Keeps the test focused on help-path correctness, not static command vocabulary.
require.NoError(t, err, "root command help should execute successfully")
assert.NotEmpty(t, output, "root command help should produce output")
// Removed stale negative assertions for " bootstrap " and " setup "

Copilot AI linked an issue Jul 15, 2026 that may be closed by this pull request
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix help output for TestMainFunction in CI Update root help test to stop rejecting newly added commands Jul 15, 2026
Copilot AI requested a review from pelikhan July 15, 2026 08:44
@pelikhan
pelikhan marked this pull request as ready for review July 15, 2026 08:52
Copilot AI review requested due to automatic review settings July 15, 2026 08:52
@pelikhan
pelikhan merged commit 2fddf49 into main Jul 15, 2026
20 checks passed
@pelikhan
pelikhan deleted the copilot/fix-issue-in-help-output branch July 15, 2026 08:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the root help test to allow legitimate CLI command growth.

Changes:

  • Removes stale negative assertions for bootstrap and setup.
  • Retains help execution and non-empty output checks.
Show a summary per file
File Description
cmd/gh-aw/main_entry_test.go Removes obsolete root-help constraints.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.82.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow Health Dashboard - 2026-07-15

3 participants