Update root help test to stop rejecting newly added commands#45683
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix help output for TestMainFunction in CI
Update root help test to stop rejecting newly added commands
Jul 15, 2026
pelikhan
marked this pull request as ready for review
July 15, 2026 08:52
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the root help test to allow legitimate CLI command growth.
Changes:
- Removes stale negative assertions for
bootstrapandsetup. - Retains help execution and non-empty output checks.
Show a summary per file
| File | Description |
|---|---|
cmd/gh-aw/main_entry_test.go |
Removes obsolete root-help constraints. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
This was referenced Jul 15, 2026
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIonmainwas failing inTestMainFunction/root_command_helpbecause the test still asserted thatbootstrapandsetupmust not appear ingh aw --help, which is no longer true after CLI command additions. This change removes those stale constraints so the test tracks real regressions instead of blocking valid command-surface growth.Problem alignment
cmd/gh-aw/main_entry_test.gohad hard-coded negative assertions for command tokens that are now legitimately present in root help output.Test behavior change
NotContainschecks for" bootstrap "and" setup "fromTestMainFunction/root_command_help.Why this improves durability