Route workshop landing to org-scoped path (/workshop/hackathon-blue-bat-18/) - #46579
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
@copilot Update url path from singular ( |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Updated to the plural, date-based path: |
There was a problem hiding this comment.
Pull request overview
Attempts to move the workshop landing page to an organization-scoped route, but currently generates a different plural, date-prefixed URL.
Changes:
- Adds a parameterized static workshop route.
- Updates workshop links, validation, and Playwright navigation.
- Rewrites workshop-local deep-link prefixes.
Show a summary per file
| File | Description |
|---|---|
docs/tests/workshop.spec.ts |
Updates tested workshop URLs. |
docs/src/pages/workshops/[org].astro |
Adds the static workshop route. |
docs/src/content/docs/index.mdx |
Updates the homepage workshop link. |
docs/src/components/workshop/WorkshopExperience.astro |
Updates internal-link recognition. |
docs/scripts/sync-workshop-content.js |
Updates generated deep-link prefixes. |
docs/astro.config.mjs |
Updates the link-validator exclusion. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Medium
|
@copilot Do not hard code, the structure is: |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Done in commit |
|
@copilot Note that we can have multiple of these, given that we will have past and present workshops. |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Done in commit |
|
@copilot Address all remaining review comments. |
|
@copilot please run the Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "pi.dev"See Network Configuration for more information.
|
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
The one remaining unresolved review thread (marked outdated) flagged that the slug should be used consistently. Addressed in the latest commit by importing |
|
🎉 This pull request is included in a new release. Release: |
The workshop entry URL previously stopped at
/workshop/, which broke the intended org-scoped landing path. This update aligns docs, route generation, and in-app workshop links on/workshop/hackathon-blue-bat-18/.Landing URL and docs entrypoint
/gh-aw/workshop/hackathon-blue-bat-18/.Workshop internal link prefixing
/gh-aw/workshop/?__gh_aw_workshop_local__=to/gh-aw/workshop/hackathon-blue-bat-18/?__gh_aw_workshop_local__=in the workshop experience, content sync script, and docs link validator allowlist.Route shape
/docs/src/pages/workshop/[org].astro) and statically generated thehackathon-blue-bat-18path.Workshop navigation tests
/gh-aw/workshop/to use/gh-aw/workshop/hackathon-blue-bat-18/.