Skip to content

Route workshop landing to org-scoped path (/workshop/hackathon-blue-bat-18/) - #46579

Merged
mnkiefer merged 7 commits into
mainfrom
copilot/include-hackathon-blue-bat-18-in-url
Jul 19, 2026
Merged

Route workshop landing to org-scoped path (/workshop/hackathon-blue-bat-18/)#46579
mnkiefer merged 7 commits into
mainfrom
copilot/include-hackathon-blue-bat-18-in-url

Conversation

Copilot AI commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

The workshop entry URL previously stopped at /workshop/, which broke the intended org-scoped landing path. This update aligns docs, route generation, and in-app workshop links on /workshop/hackathon-blue-bat-18/.

  • Landing URL and docs entrypoint

    • Updated the homepage workshop card link to /gh-aw/workshop/hackathon-blue-bat-18/.
  • Workshop internal link prefixing

    • Switched workshop-local deep-link prefix usage from /gh-aw/workshop/?__gh_aw_workshop_local__= to /gh-aw/workshop/hackathon-blue-bat-18/?__gh_aw_workshop_local__= in the workshop experience, content sync script, and docs link validator allowlist.
  • Route shape

    • Replaced the event-named page file with a parameterized route (/docs/src/pages/workshop/[org].astro) and statically generated the hackathon-blue-bat-18 path.
  • Workshop navigation tests

    • Updated workshop Playwright navigations that targeted /gh-aw/workshop/ to use /gh-aw/workshop/hackathon-blue-bat-18/.
// before
await page.goto('/gh-aw/workshop/');

// after
await page.goto('/gh-aw/workshop/hackathon-blue-bat-18/');

Copilot AI and others added 2 commits July 19, 2026 08:36
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer

Copy link
Copy Markdown
Collaborator

@copilot Update url path from singular (/gh-aw/workshop/) to plural (/gh-aw/workshops/)

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>

Copilot AI commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Update url path from singular (/gh-aw/workshop/) to plural (/gh-aw/workshops/)

Updated to the plural, date-based path: /gh-aw/workshops/2026-07-24-hackathon-blue-bat-18/ across docs links, workshop-local link prefixing, route generation, and workshop Playwright navigations in commit 35e0f24.

Copilot AI requested a review from mnkiefer July 19, 2026 09:07
@mnkiefer
mnkiefer marked this pull request as ready for review July 19, 2026 09:11
Copilot AI review requested due to automatic review settings July 19, 2026 09:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Attempts to move the workshop landing page to an organization-scoped route, but currently generates a different plural, date-prefixed URL.

Changes:

  • Adds a parameterized static workshop route.
  • Updates workshop links, validation, and Playwright navigation.
  • Rewrites workshop-local deep-link prefixes.
Show a summary per file
File Description
docs/tests/workshop.spec.ts Updates tested workshop URLs.
docs/src/pages/workshops/[org].astro Adds the static workshop route.
docs/src/content/docs/index.mdx Updates the homepage workshop link.
docs/src/components/workshop/WorkshopExperience.astro Updates internal-link recognition.
docs/scripts/sync-workshop-content.js Updates generated deep-link prefixes.
docs/astro.config.mjs Updates the link-validator exclusion.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 6/6 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread docs/src/pages/workshops/[org].astro Outdated
@mnkiefer

mnkiefer commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

@copilot Do not hard code, the structure is: /workshops/[YYYY-MM-DD-org-name]. For the upcoming workshop case, the becomes /workshops/2026-07-24-hackathon-blue-bat-18.

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>

Copilot AI commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Do not hard code, the structure is: /workshops/[YYYY-MM-DD-org-name]. For the upcoming workshop case, the becomes /workshops/2026-07-24-hackathon-blue-bat-18.

Done in commit refactor: extract WORKSHOP_ORG_SLUG constant. The slug is now defined once in docs/src/lib/workshop/config.ts as WORKSHOP_ORG_SLUG = '2026-07-24-hackathon-blue-bat-18' and imported wherever the path is constructed. The sync script follows the existing env-var-with-default pattern (GH_AW_WORKSHOP_ORG_SLUG || '2026-07-24-hackathon-blue-bat-18').

@mnkiefer

Copy link
Copy Markdown
Collaborator

@copilot Note that we can have multiple of these, given that we will have past and present workshops.

Copilot AI and others added 2 commits July 19, 2026 09:35
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>

Copilot AI commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Note that we can have multiple of these, given that we will have past and present workshops.

Done in commit refactor: support multiple workshop slugs via WORKSHOP_SLUGS list. config.ts now exports a WORKSHOP_SLUGS array (newest-first) — adding a new workshop is a single prepend to that list. getStaticPaths generates a route for every entry, and WorkshopExperience receives the current route's org slug as a prop so each page's local-link prefix is derived from its own URL. The homepage card uses a CURRENT_WORKSHOP_SLUG = WORKSHOP_SLUGS[0] derived export.

@mnkiefer

Copy link
Copy Markdown
Collaborator

@copilot Address all remaining review comments.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address the remaining maintainer feedback in the latest comment thread, update the branch if needed, and rerun checks once finished.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • pi.dev

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "pi.dev"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · 13.5 AIC · ⌖ 6.01 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>

Copilot AI commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Address all remaining review comments.

The one remaining unresolved review thread (marked outdated) flagged that the slug should be used consistently. Addressed in the latest commit by importing CURRENT_WORKSHOP_SLUG from config.ts into workshop.spec.ts and replacing the five hardcoded '/gh-aw/workshops/2026-07-24-hackathon-blue-bat-18/' literals with a WORKSHOP_URL constant derived from it — so updating the current workshop slug in config.ts is the only change needed going forward.

Copilot AI requested a review from mnkiefer July 19, 2026 10:04
@mnkiefer
mnkiefer merged commit f984ec1 into main Jul 19, 2026
2 of 3 checks passed
@mnkiefer
mnkiefer deleted the copilot/include-hackathon-blue-bat-18-in-url branch July 19, 2026 10:08
Copilot stopped work on behalf of gh-aw-bot due to an error July 19, 2026 10:09
Copilot AI requested a review from gh-aw-bot July 19, 2026 10:09
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.82.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants