Skip to content

[rendering-scripts] fix(copilot-parser): strip 'Resume' CLI footer hint from rendered reasoning #46581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Jul 19, 2026
Merged

[rendering-scripts] fix(copilot-parser): strip 'Resume' CLI footer hint from rendered reasoning #46581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34edb5c
fix(copilot-parser): strip 'Resume' CLI footer hint from rendered rea…
github-actions[bot] Jul 19, 2026
f7879c5
Merge branch 'main' into fix-copilot-resume-footer-leak-b258573b68749780
pelikhan Jul 19, 2026
8af2452
fix(copilot-parser): narrow Resume footer regex to exact CLI command …
Copilot Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions actions/setup/js/parse_copilot_log.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,12 @@ function parsePrettyPrintFormat(logContent) {
const MODEL_BREAKDOWN_RE = /^Breakdown by AI model:/;
const MODEL_LINE_RE = /^ +(\S+)\s+([\d.]+k?)\s+in,\s+([\d.]+k?)\s+out(?:,\s+([\d.]+k?)\s+cached)?/;
// Recognise both legacy ("Total usage est:" / "API time spent:" / …) and the
// newer Copilot CLI footer ("Changes +N -N", "Duration Ns", "Tokens ↑N ↓N (cached)").
// The newer footer omits a colon and uses arrow glyphs, so we extend the regex rather than
// relying on the legacy "Total …:" prefix alone.
const USAGE_LINES_RE = /^(?:Total usage est:|API time spent:|Total session time:|Total code changes:|Changes\s+[+-]?\d|Duration\s+\d|Tokens\s+[↑↓])/;
// newer Copilot CLI footer ("Changes +N -N", "Duration Ns", "Tokens ↑N ↓N (cached)",
// "Resume copilot --resume=…"). The newer footer omits a colon and uses arrow glyphs, so we
// extend the regex rather than relying on the legacy "Total …:" prefix alone. The "Resume"
// hint is matched against the exact CLI command syntax to avoid false-positives on prose
// that happens to start with "Resume ".
const USAGE_LINES_RE = /^(?:Total usage est:|API time spent:|Total session time:|Total code changes:|Changes\s+[+-]?\d|Duration\s+\d|Tokens\s+[↑↓]|Resume\s{2,}copilot\s+--resume=)/;

const parseTokenCount = s => {
const n = parseFloat(s);
Expand Down
22 changes: 22 additions & 0 deletions actions/setup/js/parse_copilot_log.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,28 @@ describe("parse_copilot_log.cjs", () => {
expect(result.markdown).toContain("375,000");
});

it("strips the columnar 'Resume' footer hint from rendered pretty-print output", () => {
// Copilot CLI footer includes a "Resume copilot --resume=<id>" line aligned in the
// same column block as Changes/Duration/Tokens. It is CLI chrome, not agent reasoning,
// and must not leak into the rendered reasoning/agent-text section.
const prettyLog = [
"● Bash",
" └ ok",
"The work is done.",
"",
"Changes +0 -0",
"Duration 1m 0s",
"Tokens ↑ 195.4k (166.2k cached) • ↓ 2.9k",
"Resume copilot --resume=d21d3356-9296-4d1b-a392-49e5069e4e3f",
].join("\n");

const result = parseCopilotLog(prettyLog);

expect(result.markdown).toContain("The work is done.");
expect(result.markdown).not.toContain("--resume=");
expect(result.markdown).not.toMatch(/^Resume\s+copilot/m);

@github-actions github-actions Bot Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/tdd] The test suite is missing a boundary case: a line like Resume copilot --resume=... (single space) should not be stripped. Adding this would confirm the \s{2,} discriminator is doing its job and prevent a regression if the regex is ever tightened.

💡 Suggested additional assertion 
it('does not strip Resume line with only one space (not CLI footer)', () => {
  const prettyLog = [
    '● Bash',
    '    └ ok',
    'Resume copilot --resume=abc',  // single space — should be kept as agent text
  ].join('\n');
  const result = parseCopilotLog(prettyLog);
  expect(result.markdown).toContain('Resume copilot');
});

This directly exercises the {2,} quantifier that distinguishes columnar chrome from prose.

@copilot please address this.

});

it("handles the new footer without a cached segment", () => {
const prettyLog = ["● Bash", " └ ok", "", "Tokens ↑ 1.2k • ↓ 50"].join("\n");

Expand Down
Loading