Rename CLI firewall PolicyRule to FirewallPolicyRule

[Copilot]

pkg/cli defined a firewall ACL rule as PolicyRule, which collided conceptually with the unrelated intent execution-policy PolicyRule in pkg/intent. This change makes the firewall type explicit without changing the intent policy model.

• Type rename in firewall policy code

  • Renames pkg/cli's firewall rule struct from PolicyRule to FirewallPolicyRule
  • Updates PolicyManifest, RuleHitStats, sorting, matching, and helper signatures to use the new name

• Reference cleanup in pkg/cli

  • Rewrites all in-package call sites and fixtures to use FirewallPolicyRule
  • Leaves pkg/intent/policy.go unchanged so the intent-policy PolicyRule remains distinct

• Package documentation

  • Updates the exported-type table in pkg/cli/README.md to reflect the new name

Example:

type PolicyManifest struct {
    Rules []FirewallPolicyRule `json:"rules"`
}

type FirewallPolicyRule struct {
    ID          string   `json:"id"`
    Order       int      `json:"order"`
    Action      string   `json:"action"`
    ACLName     string   `json:"aclName"`
    Protocol    string   `json:"protocol"`
    Domains     []string `json:"domains"`
    Description string   `json:"description"`
}

• Fixes [Code Quality] Rename PolicyRule in pkg/cli/firewall_policy.go to FirewallPolicyRule #46944

[Copilot]

Pull request overview

Renames the firewall ACL rule type to distinguish it from the intent policy model.

Changes:

• Renames PolicyRule to FirewallPolicyRule.
• Updates firewall logic, tests, fixtures, and documentation.

Show a summary per file

File	Description
pkg/cli/README.md	Updates the exported-type listing.
pkg/cli/firewall_policy.go	Renames the firewall rule type and usages.
pkg/cli/firewall_policy_test.go	Updates test fixtures for the renamed type.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Medium

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.82.15