Enforce sprintfbool in cgo custom-linter CI gates - #46987
Merged
Conversation
4 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add sprintfbool linter to enforce readiness
Enforce Jul 21, 2026
sprintfbool in cgo custom-linter CI gates
pelikhan
marked this pull request as ready for review
July 21, 2026 06:36
Contributor
There was a problem hiding this comment.
Pull request overview
Adds sprintfbool enforcement to existing production custom-linter CI gates.
Changes:
- Enables
-sprintfboolfor default Go builds. - Enables it for the wasm package subset.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Adds sprintfbool to both custom-linter invocations. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sprintfboolis already clean and enforce-ready (no production findings), but CI was not enforcing it. This change wires the analyzer into the two existing custom-linter gates so future regressions are blocked in both default and wasm scopes.What changed
-sprintfboolto theLINTER_FLAGSused by:Run custom linters(default build)Run custom linters (wasm)(GOOS=js GOARCH=wasmpackage subset)CI enforcement surface
-test=false) withsprintfbool.