Skip to content

Add Pi offline regression coverage to wasm golden engine test - #47261

Merged
pelikhan merged 2 commits into
mainfrom
copilot/investigate-workflow-failure
Jul 22, 2026
Merged

Add Pi offline regression coverage to wasm golden engine test#47261
pelikhan merged 2 commits into
mainfrom
copilot/investigate-workflow-failure

Conversation

Copilot AI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The CGO workflow failure came from a stale Pi wasm golden expectation after Pi engine output started including PI_OFFLINE: 1. Both the test and build-wasm jobs failed on the same TestWasmGolden_AllEngines/pi mismatch.

  • Root cause captured in a focused assertion

    • Adds a Pi-specific regression check in TestWasmGolden_AllEngines to require PI_OFFLINE: 1 in compiled output.
    • Keeps the behavior under direct test instead of relying only on a broad golden diff.
  • Scope

    • Test-only change in /home/runner/work/gh-aw/gh-aw/pkg/workflow/wasm_golden_test.go
    • No production workflow compilation logic changes
if eng.name == "pi" {
	require.Contains(t, yamlOutput, "PI_OFFLINE: 1")
}

Copilot AI linked an issue Jul 22, 2026 that may be closed by this pull request
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate and resolve workflow failure on main Add Pi offline regression coverage to wasm golden engine test Jul 22, 2026
Copilot AI requested a review from pelikhan July 22, 2026 10:19
@pelikhan
pelikhan marked this pull request as ready for review July 22, 2026 10:20
Copilot AI review requested due to automatic review settings July 22, 2026 10:20
@pelikhan
pelikhan merged commit 4c6aade into main Jul 22, 2026
@pelikhan
pelikhan deleted the copilot/investigate-workflow-failure branch July 22, 2026 10:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds focused regression coverage ensuring Pi wasm output includes offline mode.

Changes:

  • Asserts Pi compilation emits PI_OFFLINE: 1.
  • Retains existing all-engine golden validation.
Show a summary per file
File Description
pkg/workflow/wasm_golden_test.go Adds the Pi offline-mode assertion.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.83.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CGO] Workflow failure on main - Run #18537

3 participants