fix: create agentic failure issue when engine secret validation fails by Copilot · Pull Request #47893 · github/gh-aw

Copilot · 2026-07-25T03:20:02Z

When the validate-secret step fails (missing engine secret), the activation job fails and the agent job is skipped — not failure. The handle_agent_failure.cjs early-return guard only checked agentConclusion !== "failure", so it bailed out silently and never created a failure issue.

Changes

`handle_agent_failure.cjs`

Fix: adds hasSecretVerificationFailed to the early-return guard so the failure handler proceeds when GH_AW_SECRET_VERIFICATION_RESULT === "failed", even when the agent job was skipped
Replaces the hardcoded engineId === "copilot" check in buildSecretVerificationContext with a data-driven GH_AW_ENGINE_SECRET_FAILURE_MESSAGE env var

Go compiler — per-engine secret failure message

Adds GetSecretFailureMessage(workflowData *WorkflowData) string to WorkflowExecutor; BaseEngine returns ""

CopilotEngine overrides it with the permissions: copilot-requests: write alternative:

**Alternative**: If your organization has a Copilot subscription, you can avoid the need
for a personal access token by adding a top-level `permissions` block to your workflow file.

permissions:
  copilot-requests: write

Compiler emits GH_AW_ENGINE_SECRET_FAILURE_MESSAGE in the conclusion job when the engine has a validate-secret step and a non-empty message

Tests (`secret_verification_output_test.go`)

TestCopilotEngineSecretFailureMessageWiredInConclusionJob — compiled lock file includes GH_AW_ENGINE_SECRET_FAILURE_MESSAGE with copilot-requests: write for the Copilot engine
TestNonCopilotEngineHasNoSecretFailureMessage — engines without a custom message (e.g. Claude) do not emit the env var

Run: https://github.com/github/gh-aw/actions/runs/30143146258

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 8.03 AIC · ⌖ 8.45 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

- Add GetSecretFailureMessage to WorkflowExecutor interface with BaseEngine no-op default - CopilotEngine overrides GetSecretFailureMessage with copilot-requests: write guidance - Compiler emits GH_AW_ENGINE_SECRET_FAILURE_MESSAGE in conclusion job when engine has validate-secret step and a custom message - Fix handle_agent_failure.cjs: add hasSecretVerificationFailed to early return guard so a failure issue is created when the secret validation step fails and the agent is skipped - Update buildSecretVerificationContext to use GH_AW_ENGINE_SECRET_FAILURE_MESSAGE instead of hardcoded engineId check - Add compiled tests: TestCopilotEngineSecretFailureMessageWiredInConclusionJob, TestNonCopilotEngineHasNoSecretFailureMessage - Recompile all 261 workflow lock files Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-25T03:22:30Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

github-actions · 2026-07-25T03:22:38Z

✅ Test Quality Sentinel completed test quality analysis.

github-actions · 2026-07-25T03:22:45Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-07-25T03:22:54Z

✅ PR Code Quality Reviewer completed the code quality review.

Copilot

Pull request overview

Fixes failure reporting when secret validation fails before the agent job runs.

Changes:

Allows secret-validation failures to bypass the failure-handler guard.
Adds engine-specific remediation guidance.
Regenerates affected Copilot workflow lock files and adds compiler tests.

Show a summary per file

File	Description
`actions/setup/js/handle_agent_failure.cjs`	Handles secret-validation failures and engine guidance.
`pkg/workflow/agentic_engine.go`	Adds the engine guidance interface.
`pkg/workflow/copilot_engine_installation.go`	Provides Copilot-specific remediation.
`pkg/workflow/notify_comment_conclusion_helpers.go`	Emits remediation into the conclusion job.
`pkg/workflow/secret_verification_output_test.go`	Tests compiler output.
`.github/workflows/workflow-skill-extractor.lock.yml`	Regenerates conclusion environment.
`.github/workflows/workflow-normalizer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/workflow-health-manager.lock.yml`	Regenerates conclusion environment.
`.github/workflows/workflow-generator.lock.yml`	Regenerates conclusion environment.
`.github/workflows/weekly-safe-outputs-spec-review.lock.yml`	Regenerates conclusion environment.
`.github/workflows/weekly-issue-summary.lock.yml`	Regenerates conclusion environment.
`.github/workflows/weekly-editors-health-check.lock.yml`	Regenerates conclusion environment.
`.github/workflows/weekly-blog-post-writer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/visual-regression-checker.lock.yml`	Regenerates conclusion environment.
`.github/workflows/video-analyzer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/update-astro.lock.yml`	Regenerates conclusion environment.
`.github/workflows/uk-ai-operational-resilience.lock.yml`	Regenerates conclusion environment.
`.github/workflows/ubuntu-image-analyzer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/tidy.lock.yml`	Regenerates conclusion environment.
`.github/workflows/terminal-stylist.lock.yml`	Regenerates conclusion environment.
`.github/workflows/technical-doc-writer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/super-linter.lock.yml`	Regenerates conclusion environment.
`.github/workflows/sub-issue-closer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/stale-repo-identifier.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-workflow-call.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-workflow-call-with-inputs.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-test-tools.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-temporary-id.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-service-ports.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-project.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-otel-backends.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-multi-pr.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-copilot.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-copilot-small.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-copilot-sdk.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-copilot-mai.lock.yml`	Regenerates conclusion environment.
`.github/workflows/smoke-copilot-arm.lock.yml`	Regenerates conclusion environment.
`.github/workflows/slide-deck-maintainer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/sighthound-security-scan.lock.yml`	Regenerates conclusion environment.
`.github/workflows/security-compliance.lock.yml`	Regenerates conclusion environment.
`.github/workflows/research.lock.yml`	Regenerates conclusion environment.
`.github/workflows/repository-quality-improver.lock.yml`	Regenerates conclusion environment.
`.github/workflows/repo-tree-map.lock.yml`	Regenerates conclusion environment.
`.github/workflows/repo-audit-analyzer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/release.lock.yml`	Regenerates conclusion environment.
`.github/workflows/refiner.lock.yml`	Regenerates conclusion environment.
`.github/workflows/q.lock.yml`	Regenerates conclusion environment.
`.github/workflows/python-data-charts.lock.yml`	Regenerates conclusion environment.
`.github/workflows/pr-triage-agent.lock.yml`	Regenerates conclusion environment.
`.github/workflows/pr-nitpick-reviewer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/pr-description-caveman.lock.yml`	Regenerates conclusion environment.
`.github/workflows/plan.lock.yml`	Regenerates conclusion environment.
`.github/workflows/pdf-summary.lock.yml`	Regenerates conclusion environment.
`.github/workflows/outcome-collector.lock.yml`	Regenerates conclusion environment.
`.github/workflows/org-health-report.lock.yml`	Regenerates conclusion environment.
`.github/workflows/objective-impact-report.lock.yml`	Regenerates conclusion environment.
`.github/workflows/notion-issue-summary.lock.yml`	Regenerates conclusion environment.
`.github/workflows/metrics-collector.lock.yml`	Regenerates conclusion environment.
`.github/workflows/mergefest.lock.yml`	Regenerates conclusion environment.
`.github/workflows/mcp-inspector.lock.yml`	Regenerates conclusion environment.
`.github/workflows/layout-spec-maintainer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/jsweep.lock.yml`	Regenerates conclusion environment.
`.github/workflows/issue-triage-agent.lock.yml`	Regenerates conclusion environment.
`.github/workflows/gpclean.lock.yml`	Regenerates conclusion environment.
`.github/workflows/glossary-maintainer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/github-remote-mcp-auth-test.lock.yml`	Regenerates conclusion environment.
`.github/workflows/functional-pragmatist.lock.yml`	Regenerates conclusion environment.
`.github/workflows/firewall.lock.yml`	Regenerates conclusion environment.
`.github/workflows/example-permissions-warning.lock.yml`	Regenerates conclusion environment.
`.github/workflows/example-failure-category-filter.lock.yml`	Regenerates conclusion environment.
`.github/workflows/designer-drift-audit.lock.yml`	Regenerates conclusion environment.
`.github/workflows/deployment-incident-monitor.lock.yml`	Regenerates conclusion environment.
`.github/workflows/dependabot-go-checker.lock.yml`	Regenerates conclusion environment.
`.github/workflows/dependabot-burner.lock.yml`	Regenerates conclusion environment.
`.github/workflows/dataflow-pr-discussion-dataset.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-windows-terminal-integration-builder.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-team-status.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-skill-optimizer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-sentrux-report.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-security-observability.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-regulatory.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-performance-summary.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-model-resolution.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-model-inventory.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-issues-report.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-firewall-report.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-credit-limit-test.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-compiler-threat-spec-optimizer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-community-attribution.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-cli-tools-tester.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-ambient-context-optimizer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/daily-agent-of-the-day-blog-writer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/copilot-opt.lock.yml`	Regenerates conclusion environment.
`.github/workflows/contribution-check.lock.yml`	Regenerates conclusion environment.
`.github/workflows/constraint-solving-potd.lock.yml`	Regenerates conclusion environment.
`.github/workflows/code-simplifier.lock.yml`	Regenerates conclusion environment.
`.github/workflows/bot-detection.lock.yml`	Regenerates conclusion environment.
`.github/workflows/agentic-token-trend-audit.lock.yml`	Regenerates conclusion environment.
`.github/workflows/agentic-token-optimizer.lock.yml`	Regenerates conclusion environment.
`.github/workflows/agentic-token-audit.lock.yml`	Regenerates conclusion environment.
`.github/workflows/ace-editor.lock.yml`	Regenerates conclusion environment.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

actions/setup/js/handle_agent_failure.cjs:3154

The core regression path is not covered by a behavior test: the added Go tests only inspect compiler output. Add a main() test with GH_AW_AGENT_CONCLUSION=skipped and GH_AW_SECRET_VERIFICATION_RESULT=failed that verifies an issue is created and contains the secret-verification context; otherwise a later early return can silently reintroduce the original failure.

Files reviewed: 101/101 changed files
Comments generated: 2
Review effort level: Medium

 * @returns {string} Formatted context string, or empty string if verification did not fail
 */
-function buildSecretVerificationContext(secretVerificationResult, engineId) {
+function buildSecretVerificationContext(secretVerificationResult, engineSecretFailureMessage) {


github-actions

The fix is correct and well-structured. Root cause addressed: hasSecretVerificationFailed is now included in the early-return guard, so a skipped agent job (from a failed validate-secret step) correctly proceeds to failure issue creation. Design: Replacing the engineId === copilot hardcode with a data-driven GH_AW_ENGINE_SECRET_FAILURE_MESSAGE env var is a clean extensibility improvement. Tests: Both cases covered.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 21 AIC · ⌖ 4.48 AIC · ⊞ 5K

github-actions · 2026-07-25T03:28:10Z

🧪 Test Quality Sentinel Report

⚠️ Test Quality Score: 75/100 — Acceptable

Analyzed 2 test(s): 2 design, 0 implementation, 0 violation(s).

📊 Metrics (2 tests)

Metric	Value
Analyzed	2 (Go: 2, JS: 0)
✅ Design	2 (100%)
⚠️ Implementation	0 (0%)
Edge/error coverage	1 (50%)
Duplicate clusters	0
Inflation	YES (88 test lines vs 22 production lines, 4:1 ratio)
🚨 Violations	0

Test	File	Classification	Issues
`TestCopilotEngineSecretFailureMessageWiredInConclusionJob`	`secret_verification_output_test.go`	`design_test` · `behavioral_contract`	None
`TestNonCopilotEngineHasNoSecretFailureMessage`	`secret_verification_output_test.go`	`design_test` · `behavioral_contract`	None

Verdict

✅ Passed. 0% implementation tests (threshold: 30%). Build tag present, no mock violations. The two new tests verify complementary behavioral contracts: (1) that GH_AW_ENGINE_SECRET_FAILURE_MESSAGE with Copilot-specific guidance is emitted for the Copilot engine, and (2) that it is absent for non-Copilot engines (Claude). Both are genuine design tests covering a meaningful engine-dispatch invariant. Inflation flag noted but not disqualifying — compiler output tests require full compilation scaffolding per case.

🧪 Test quality analysis by Test Quality Sentinel · sonnet46 · 42.1 AIC · ⌖ 7.71 AIC · ⊞ 7K · ◷
_{Comment /review to run again}

github-actions

✅ Test Quality Sentinel: 75/100 — Acceptable. 0% implementation tests (threshold: 30%). No violations.

…message Auto-generated by the Design Decision Gate agent.

github-actions · 2026-07-25T03:28:48Z

🏗️ Design Decision Gate — ADR Required

This PR makes significant changes to core business logic (>100 new lines) but does not have a linked Architecture Decision Record (ADR).

📄 Draft ADR committed: docs/adr/47893-data-driven-engine-secret-failure-message.md — review and complete it before merging.

🔒 This PR cannot merge until an ADR is linked in the PR body.

📋 What to do next

Review the draft ADR committed to your branch — it was generated from the PR diff
Complete the missing sections — add context the AI could not infer, refine the decision rationale, and list real alternatives you considered
Commit the finalized ADR to docs/adr/ on your branch
Reference the ADR in this PR body by adding a line such as:

ADR: ADR-47893: Data-Driven Engine Secret Failure Message

Once an ADR is linked in the PR body, this gate will re-run and verify the implementation matches the decision.

❓ Why ADRs Matter

"AI made me procrastinate on key design decisions. Because refactoring was cheap, I could always say 'I'll deal with this later.' Deferring decisions corroded my ability to think clearly."

ADRs create a searchable, permanent record of why the codebase looks the way it does. Future contributors (and your future self) will thank you.

📋 Michael Nygard ADR Format Reference

An ADR must contain these four sections to be considered complete:

Context — What is the problem? What forces are at play?
Decision — What did you decide? Why?
Alternatives Considered — What else could have been done?
Consequences — What are the trade-offs (positive and negative)?

All ADRs are stored in docs/adr/ as Markdown files numbered by PR number (e.g., 47893-data-driven-engine-secret-failure-message.md for PR #47893).

🏗️ ADR gate enforced by Design Decision Gate 🏗️ · sonnet46 · 75.8 AIC · ⌖ 9.98 AIC · ⊞ 8.5K · ◷
_{Comment /review to run again}

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd — requesting changes on one test-correctness issue. The fix logic itself is clean and the Go-side design is solid.

📋 Key Themes & Highlights

Key Issues

Stale JS unit tests: buildSecretVerificationContext tests were not updated to match the new parameter contract — they still pass engine ID strings ("copilot", "claude") instead of formatted message strings. The tests pass by coincidence and no longer verify the right behaviour.
Missing JS integration test for the core guard: there is no JS-level test asserting that hasSecretVerificationFailed bypasses the early-return when agentConclusion === "skipped", which is the exact bug this PR fixes.

Positive Highlights

✅ Core fix is correct — hasSecretVerificationFailed is extracted cleanly and wired into both the early-return guard and downstream calls.
✅ Data-driven design: replacing the hardcoded engineId === "copilot" check with GH_AW_ENGINE_SECRET_FAILURE_MESSAGE is a clear improvement in extensibility.
✅ GetSecretFailureMessage() on WorkflowExecutor + BaseEngine default follows the existing engine interface pattern.
✅ Go-level tests (TestCopilotEngineSecretFailureMessageWiredInConclusionJob, TestNonCopilotEngineHasNoSecretFailureMessage) are well-structured and cover both the positive and negative cases.
✅ %q encoding via fmt.Sprintf produces valid YAML double-quoted strings where \n is correctly interpreted as newlines by the YAML parser.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 61.4 AIC · ⌖ 4.81 AIC · ⊞ 6.7K
_{Comment /matt to run again}

Done

pelikhan · 2026-07-25T03:33:39Z

@copilot run pr-finisher skill
Recompile

github-actions

REQUEST_CHANGES — Two bypass guards missing `!hasSecretVerificationFailed`

The fix correctly adds !hasSecretVerificationFailed to the primary early-return guard (line 3151), but two subsequent auto-suppression guards (hasOnlyNoopOutputs at line 3182, hasCompletedDespiteJobFailure at line 3192) do not include the same check. An agent job that runs with a missing/invalid secret (it is not gated out when secret verification fails — the agent if: condition only blocks on daily_ai_credits_exceeded) could still trigger one of those bypass paths and silently suppress the failure issue this PR was written to fix.

Rest of diff — no issues

buildSecretVerificationContext parameter rename from engineId to engineSecretFailureMessage is clean and data-driven.
Go interface addition (GetSecretFailureMessage) and BaseEngine + CopilotEngine overrides are correct.
%q format in notify_comment_conclusion_helpers.go produces Go-escaped strings that YAML double-quoted parser correctly interprets as newlines — verified.
Lock file churn (96 files, 1 line each) is expected for a compiled output.
Test coverage for the compiler side is solid.

🔎 Code quality review by PR Code Quality Reviewer · sonnet46 · 129.1 AIC · ⌖ 4.88 AIC · ⊞ 5.7K
_{Comment /review to run again}

Comments that could not be inline-anchored

actions/setup/js/handle_agent_failure.cjs:3182

hasOnlyNoopOutputs bypass does not check !hasSecretVerificationFailed, allowing a failed secret-verification scenario to be silently dropped: If the agent runs while the secret is absent/invalid (the agent job if: condition only blocks on daily_ai_credits_exceeded, not on secret failure), exits with failure, and somehow produces only noop safe-outputs, this guard returns early and no failure issue is ever created — even though hasSecretVerificationFailed === true.

<details>
<su…

actions/setup/js/handle_agent_failure.cjs:3192

Same bypass gap applies to hasCompletedDespiteJobFailure: this guard also lacks !hasSecretVerificationFailed, meaning an agent that ran with a bad secret, logged terminal_reason: completed (e.g. it managed to call noop before failing), and produced valid non-noop outputs could slip through without triggering a failure issue.

<details>
<summary>💡 Suggested fix</summary>

if (hasCompletedDespiteJobFailure &amp;&amp; !hasReportIncomplete &amp;&amp; !hasCacheMissMisconfiguration &amp;&amp; !hasSecretVe…

</details>

…date JS tests to use message text Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Done

Copilot · 2026-07-25T03:48:21Z

@copilot run pr-finisher skill
Recompile

Done in 1ad5f5f. Two issues addressed:

GetSecretFailureMessage now checks ResolveLLMProvider before returning the copilot-requests: write guidance — returns "" when the provider is openai or anthropic. A new compiler test (TestCopilotEngineWithNonGitHubProviderHasNoSecretFailureMessage) covers the openai case.
JS unit tests in handle_agent_failure.test.cjs updated to pass actual message text (not engine ID strings "copilot" / "claude") to buildSecretVerificationContext, matching the current function signature.

gh-aw-bot · 2026-07-25T04:05:58Z

@copilot please run the skill, confirm the branch is up to date, address unresolved review feedback, and rerun or retrigger checks as needed on the latest HEAD.

Unresolved review feedback:

github-actions review: fix: create agentic failure issue when engine secret validation fails #47893

Run: https://github.com/github/gh-aw/actions/runs/30143146258

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 8.03 AIC · ⌖ 8.45 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-25T04:17:37Z

@copilot please run the skill, confirm the branch is up to date, address unresolved review feedback, and rerun or retrigger checks as needed on the latest HEAD.

Unresolved review feedback:...

Branch is confirmed up to date (merge commit 0d8eb5f pulled main in). All tests pass:

311 JS tests (including the updated buildSecretVerificationContext tests that now pass message text instead of engine ID strings)
All Go tests pass including TestCopilotEngineSecretFailureMessageWiredInConclusionJob, TestNonCopilotEngineHasNoSecretFailureMessage, TestCopilotEngineWithNonGitHubProviderHasNoSecretFailureMessage, and the conclusion-condition regression tests

The unresolved review thread on handle_agent_failure.cjs:2280 was addressed in 1ad5f5f — the tests at lines 1435–1454 now pass actual message text (not "copilot" engine ID strings) to buildSecretVerificationContext, matching the updated function signature. The CI checks showing action_required are workflow approval gates, not test failures.

github-actions · 2026-07-25T11:50:03Z

🎉 This pull request is included in a new release.

Release: v0.83.3

Copilot AI assigned Copilot and pelikhan Jul 25, 2026

Copilot AI changed the title ~~fix: create agentic failure issue when validate engine secret fails~~ fix: create agentic failure issue when engine secret validation fails Jul 25, 2026

Copilot created this pull request from a session on behalf of pelikhan July 25, 2026 03:20 View session

Copilot finished work on behalf of pelikhan July 25, 2026 03:20

Copilot AI requested a review from pelikhan July 25, 2026 03:20

pelikhan marked this pull request as ready for review July 25, 2026 03:21

Copilot AI review requested due to automatic review settings July 25, 2026 03:21

Copilot started reviewing on behalf of pelikhan July 25, 2026 03:22 View session

Copilot AI reviewed Jul 25, 2026

View reviewed changes

github-actions Bot approved these changes Jul 25, 2026

View reviewed changes

docs(adr): add draft ADR-47893 for data-driven engine secret failure …

8a9b60e

…message Auto-generated by the Design Decision Gate agent.

github-actions Bot previously requested changes Jul 25, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jul 25, 2026

[aw] Matt Pocock Skills Reviewer failed #47898

Closed

Copilot started work on behalf of pelikhan July 25, 2026 03:34 View session

github-actions Bot previously requested changes Jul 25, 2026

View reviewed changes

fix: scope copilot secret failure message to GitHub provider only; up…

1ad5f5f

…date JS tests to use message text Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan July 25, 2026 03:48

Merge branch 'main' into copilot/update-compiler-and-agent-validation

0d8eb5f

github-actions Bot mentioned this pull request Jul 25, 2026

[pr-sous-chef] PR Sous Chef run report - 2026-07-25T00:16:35Z #47879

Closed

Copilot started work on behalf of gh-aw-bot July 25, 2026 04:06 View session

Copilot finished work on behalf of gh-aw-bot July 25, 2026 04:17

Copilot AI requested a review from gh-aw-bot July 25, 2026 04:17

pelikhan merged commit a9bb635 into main Jul 25, 2026
32 checks passed

pelikhan deleted the copilot/update-compiler-and-agent-validation branch July 25, 2026 04:30

Uh oh!

Conversation

Copilot AI commented Jul 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

handle_agent_failure.cjs

Go compiler — per-engine secret failure message

Tests (secret_verification_output_test.go)

Uh oh!

github-actions Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 25, 2026

🧪 Test Quality Sentinel Report

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 25, 2026

🏗️ Design Decision Gate — ADR Required

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Issues

Positive Highlights

Uh oh!

pelikhan commented Jul 25, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

REQUEST_CHANGES — Two bypass guards missing !hasSecretVerificationFailed

Comments that could not be inline-anchored

Uh oh!

Copilot AI commented Jul 25, 2026

Uh oh!

gh-aw-bot commented Jul 25, 2026

Uh oh!

Copilot AI commented Jul 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 25, 2026 •

edited by github-actions Bot

Loading

`handle_agent_failure.cjs`

Tests (`secret_verification_output_test.go`)

github-actions Bot commented Jul 25, 2026 •

edited

Loading

github-actions Bot commented Jul 25, 2026 •

edited

Loading

github-actions Bot commented Jul 25, 2026 •

edited

Loading

github-actions Bot commented Jul 25, 2026 •

edited

Loading

REQUEST_CHANGES — Two bypass guards missing `!hasSecretVerificationFailed`