Skip to content

Soft-fail verified-signatures branch-update rejections in update_pull_request - #47961

Closed
pelikhan with Copilot wants to merge 2 commits into
mainfrom
copilot/aw-failures-fix-update-pull-request
Closed

Soft-fail verified-signatures branch-update rejections in update_pull_request#47961
pelikhan with Copilot wants to merge 2 commits into
mainfrom
copilot/aw-failures-fix-update-pull-request

Conversation

Copilot AI commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

PR Sous Chef was failing safe_outputs when update_pull_request.update_branch hit a non-retryable branch-protection rejection from GitHub’s update-branch API. In repos enforcing verified signatures, the synthetic merge commit for “branch from base” is rejected even though the rest of the safe outputs succeed.

  • Behavior change

    • Extend update_pull_request non-fatal handling to recognize the verified-signatures ruleset failure:
      • Repository rule violations found
      • Commits must have verified signatures
    • When this specific updateBranch call is rejected, the handler now warns and continues instead of failing the whole safe-output batch.
  • Scope

    • Applies only to the branch-from-base sub-operation of update_pull_request.
    • Leaves other update_pull_request failures unchanged.
  • Why this is safe

    • The branch update is best-effort metadata maintenance; it should not block unrelated safe outputs such as comment creation, issue creation, or PR field updates.
    • Existing soft-fail cases (already up to date, merge conflict, workflow-permission refusal) continue to use the same path.
  • Coverage

    • Add focused tests for:
      • update_branch-only requests hitting verified-signatures rejection
      • mixed requests where branch update is rejected but title/body updates should still apply
const hasVerifiedSignaturesRuleViolation =
  message.includes("repository rule violations found") &&
  /commits?\s+must\s+have\s+verified\s+signatures\b/i.test(message);

return (
  message.includes("there are no new commits on the base branch") ||
  message.includes("merge conflict between base and head") ||
  hasWorkflowsPermissionError ||
  hasVerifiedSignaturesRuleViolation
);

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix PR Sous Chef's update_pull_request path to prevent job failure Soft-fail verified-signatures branch-update rejections in update_pull_request Jul 25, 2026
Copilot AI requested a review from pelikhan July 25, 2026 09:07
@pelikhan pelikhan closed this Jul 25, 2026
@github-actions
github-actions Bot deleted the copilot/aw-failures-fix-update-pull-request branch August 2, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants