Skip to content

fix(daily-github-docs-seo-optimizer): allow bash to unblock safeoutputs and sub-agents #47979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Jul 25, 2026
Merged

fix(daily-github-docs-seo-optimizer): allow bash to unblock safeoutputs and sub-agents #47979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
137fc50
Initial plan
Copilot Jul 25, 2026
b93dcdf
Initial plan for fixing daily-github-docs-seo-optimizer
Copilot Jul 25, 2026
f2a1410
fix: allow bash in daily-github-docs-seo-optimizer workflow
Copilot Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/daily-github-docs-seo-optimizer.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/daily-github-docs-seo-optimizer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ strict: true
timeout-minutes: 30
tools:
github: false
bash: false
bash: ["*"]
edit: false
safe-outputs:
mentions: false
Expand Down
13 changes: 2 additions & 11 deletions eslint-factory/src/rules/require-fetch-try-catch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,7 @@ export const requireFetchTryCatchRule = createRule({
// Check for the directly-awaited inline callback pattern:
// await someWrapper(async () => { await fetch(...) })
// ancestors[i-1] must be the CallExpression, ancestors[i-2] the AwaitExpression.
if (
i >= 2 &&
ancestors[i - 1].type === AST_NODE_TYPES.CallExpression &&
ancestors[i - 2].type === AST_NODE_TYPES.AwaitExpression
) {
if (i >= 2 && ancestors[i - 1].type === AST_NODE_TYPES.CallExpression && ancestors[i - 2].type === AST_NODE_TYPES.AwaitExpression) {
const outerAwait = ancestors[i - 2];
// Now search ancestors outward from i-3 to see if the outer AwaitExpression
// is inside a try block (stopping at the next function boundary).
Expand All @@ -151,12 +147,7 @@ export const requireFetchTryCatchRule = createRule({
}
if (outer.type === AST_NODE_TYPES.TryStatement && outer.handler != null) {
const block = outer.block;
if (
outerAwait.range != null &&
block.range != null &&
outerAwait.range[0] >= block.range[0] &&
outerAwait.range[1] <= block.range[1]
) {
if (outerAwait.range != null && block.range != null && outerAwait.range[0] >= block.range[0] && outerAwait.range[1] <= block.range[1]) {
return true;
}
}
Expand Down