Skip to content

Remove root .github/workflows/*.md-specific Go tests from pkg/workflow - #48693

Merged
pelikhan merged 3 commits into
mainfrom
copilot/remove-go-tests-workflows
Jul 28, 2026
Merged

Remove root .github/workflows/*.md-specific Go tests from pkg/workflow#48693
pelikhan merged 3 commits into
mainfrom
copilot/remove-go-tests-workflows

Conversation

Copilot AI commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This change removes Go tests that were coupled to specific root workflow markdown files under .github/workflows/*.md. The goal is to eliminate workflow-file-specific assertions while preserving broader compiler and behavior tests.

  • Scope reduction: root workflow fixture tests removed

    • Deleted dedicated test files in pkg/workflow that directly read/assert root workflow sources and compiled lock outputs:
      • daily_model_inventory_workflow_test.go
      • daily_agentrx_trace_optimizer_workflow_test.go
      • daily_compiler_quality_workflow_test.go
      • daily_byok_ollama_workflow_test.go
      • daily_safe_output_integrator_workflow_test.go
      • detection_workflow_frontmatter_test.go
      • audit_workflows_repo_memory_test.go
  • Mixed test cleanup

    • Removed TestCampaignGeneratorWorkflow from pkg/workflow/campaign_trigger_test.go since it directly targeted .github/workflows/agentic-campaign-generator.md.
  • What remains unchanged

    • Generic workflow compilation/trigger behavior tests and non-root-workflow-path coverage remain in place.

Example of removed test pattern:

sourceContent, err := os.ReadFile("../../.github/workflows/daily-model-inventory.md")
if err != nil {
    t.Fatalf("failed to read workflow source: %v", err)
}

Run: https://github.com/github/gh-aw/actions/runs/30381484988

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 11.6 AIC · ⌖ 6.08 AIC · ⊞ 7.2K ·
Comment /souschef to run again

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Remove Go tests for root .github/workflows markdown workflows Remove root .github/workflows/*.md-specific Go tests from pkg/workflow Jul 28, 2026
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request . delete the files

Copilot AI requested a review from pelikhan July 28, 2026 16:47
@pelikhan
pelikhan marked this pull request as ready for review July 28, 2026 16:56
Copilot AI review requested due to automatic review settings July 28, 2026 16:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes tests coupled to repository-root workflow fixtures while retaining generic workflow compiler coverage.

Changes:

  • Deleted seven root-workflow-specific test files.
  • Removed the campaign-generator fixture test.
  • Preserved generic campaign-trigger compilation tests.
Show a summary per file
File Description
pkg/workflow/detection_workflow_frontmatter_test.go Removes detection workflow fixture assertions.
pkg/workflow/daily_safe_output_integrator_workflow_test.go Removes safe-output workflow fixture assertions.
pkg/workflow/daily_model_inventory_workflow_test.go Removes model-inventory fixture assertions.
pkg/workflow/daily_compiler_quality_workflow_test.go Removes compiler-quality fixture assertions.
pkg/workflow/daily_byok_ollama_workflow_test.go Removes Ollama workflow fixture assertions.
pkg/workflow/daily_agentrx_trace_optimizer_workflow_test.go Removes AgentRx workflow fixture assertions.
pkg/workflow/campaign_trigger_test.go Removes the root campaign workflow test while preserving generic trigger coverage.
pkg/workflow/audit_workflows_repo_memory_test.go Removes audit-workflow fixture assertions.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 8/8 changed files
  • Comments generated: 0
  • Review effort level: Medium

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request . delete the files

Resolved the merge conflicts and kept the workflow test file deletion as requested in commit 17d4352675.

@pelikhan
pelikhan merged commit b6197dd into main Jul 28, 2026
@pelikhan
pelikhan deleted the copilot/remove-go-tests-workflows branch July 28, 2026 17:26
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.83.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants