Remove root .github/workflows/*.md-specific Go tests from pkg/workflow - #48693
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Remove Go tests for root .github/workflows markdown workflows
Remove root Jul 28, 2026
.github/workflows/*.md-specific Go tests from pkg/workflow
Collaborator
|
@copilot resolve the merge conflicts in this pull request . delete the files |
Copilot created this pull request from a session on behalf of
pelikhan
July 28, 2026 16:47
View session
pelikhan
marked this pull request as ready for review
July 28, 2026 16:56
Contributor
There was a problem hiding this comment.
Pull request overview
Removes tests coupled to repository-root workflow fixtures while retaining generic workflow compiler coverage.
Changes:
- Deleted seven root-workflow-specific test files.
- Removed the campaign-generator fixture test.
- Preserved generic campaign-trigger compilation tests.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/detection_workflow_frontmatter_test.go |
Removes detection workflow fixture assertions. |
pkg/workflow/daily_safe_output_integrator_workflow_test.go |
Removes safe-output workflow fixture assertions. |
pkg/workflow/daily_model_inventory_workflow_test.go |
Removes model-inventory fixture assertions. |
pkg/workflow/daily_compiler_quality_workflow_test.go |
Removes compiler-quality fixture assertions. |
pkg/workflow/daily_byok_ollama_workflow_test.go |
Removes Ollama workflow fixture assertions. |
pkg/workflow/daily_agentrx_trace_optimizer_workflow_test.go |
Removes AgentRx workflow fixture assertions. |
pkg/workflow/campaign_trigger_test.go |
Removes the root campaign workflow test while preserving generic trigger coverage. |
pkg/workflow/audit_workflows_repo_memory_test.go |
Removes audit-workflow fixture assertions. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 8/8 changed files
- Comments generated: 0
- Review effort level: Medium
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Resolved the merge conflicts and kept the workflow test file deletion as requested in commit |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes Go tests that were coupled to specific root workflow markdown files under
.github/workflows/*.md. The goal is to eliminate workflow-file-specific assertions while preserving broader compiler and behavior tests.Scope reduction: root workflow fixture tests removed
pkg/workflowthat directly read/assert root workflow sources and compiled lock outputs:daily_model_inventory_workflow_test.godaily_agentrx_trace_optimizer_workflow_test.godaily_compiler_quality_workflow_test.godaily_byok_ollama_workflow_test.godaily_safe_output_integrator_workflow_test.godetection_workflow_frontmatter_test.goaudit_workflows_repo_memory_test.goMixed test cleanup
TestCampaignGeneratorWorkflowfrompkg/workflow/campaign_trigger_test.gosince it directly targeted.github/workflows/agentic-campaign-generator.md.What remains unchanged
Example of removed test pattern:
Run: https://github.com/github/gh-aw/actions/runs/30381484988