Improve forecast command output - #48839
Merged
Merged
Conversation
- Remove Engines and Triggers columns from the summary table - Only show detailed per-run samples table when specific workflows are requested - Compute TOTAL row even when NA values are present (skip NaN/Inf, sum Runs) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f275d7e4-4d62-4ea3-8fb3-2bc485d0e2bf
Copilot stopped reviewing on behalf of
pelikhan due to an error
July 29, 2026 10:38
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refines the forecast CLI table output by simplifying displayed columns and making summary calculations more robust when projections are unreliable.
Changes:
- Remove Engines/Triggers columns from forecast table output.
- Prevent NaN/Inf projected values from corrupting weekly/monthly total aggregates.
- Add Total Runs to the TOTAL row and limit run-sample details to targeted workflow queries.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/forecast_types.go | Removes Engines/Triggers fields from the table row schema to simplify rendered output. |
| pkg/cli/forecast_render.go | Skips NaN/Inf in totals, adds total run count, gates sample details rendering, and removes now-unused formatting helpers/import. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Low
Comment on lines
70
to
71
| WeeklyP50: formatForecastAIC(weeklyP50), | ||
| MonthlyP50: formatForecastAIC(monthlyP50), |
Comment on lines
+56
to
+62
| // Skip NaN/Inf so a single unreliable projection can't poison the totals. | ||
| if !math.IsNaN(weeklyP50) && !math.IsInf(weeklyP50, 0) { | ||
| totalWeeklyP50 += weeklyP50 | ||
| } | ||
| if !math.IsNaN(monthlyP50) && !math.IsInf(monthlyP50, 0) { | ||
| totalMonthlyP50 += monthlyP50 | ||
| } |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the
gh aw forecastcommand's console table output by removing theEnginesandTriggerscolumns, adds aRunstotal row, guards against NaN/Inf poisoning aggregated totals, and limits the detailed per-run samples section to explicit workflow selections.Changes
pkg/cli/forecast_render.goEnginesandTriggerscolumns from the rendered forecast table.formatEngineList()andformatTriggerList()helper functions (and thestringsimport they required).totalRunscounter, now displayed in theTOTALrow.totalWeeklyP50/totalMonthlyP50accumulation againstNaN/Infvalues so a single unreliable projection can't poison the totals.printRunSamplesSection) is now only printed when specific--workflowIDs are passed viaconfig.WorkflowIDs, instead of always.pkg/cli/forecast_types.goEnginesandTriggersfields (and theirconsole/jsontags) from theforecastTableRowstruct used for table rendering.Impact
forecastTableRowno longer exposesEngines/Triggers— any code or tests depending on those fields will need updating.gh aw forecastwithout specific workflow IDs no longer prints the per-run samples section, reducing default output verbosity.Files changed
pkg/cli/forecast_render.gopkg/cli/forecast_types.go