feat: wrap skill install step summary in progressive disclosure details block by Copilot · Pull Request #48905 · github/gh-aw

Copilot · 2026-07-29T14:24:18Z

The skills installation section of the activation job step summary was rendered flat, unlike other sections which use collapsible <details> blocks.

Changes

install_frontmatter_skills.cjs — writeSkillSummary now emits a single addRaw call wrapping all install details (directory, requested refs, installed count, failures) in a <details><summary>Skill install details</summary>…</details> block under the ### Frontmatter skills installed h3. Also removes the ⚠️ emoji from the failures sub-heading per project convention.
install_frontmatter_skills.test.cjs — adds assertion that addRaw is called with a string containing <details>.

### Frontmatter skills installed

<details>
<summary>Skill install details</summary>

- Engine skill directory: `.claude/skills`
- Requested references: `[...]`
- Installed SKILL.md files: 3

</details>

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 10 AIC · ⌖ 6.62 AIC · ⊞ 7.8K · ◷
_{Comment /souschef to run again}

…ive disclosure Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Wraps frontmatter skill installation details in a collapsible GitHub Actions step-summary section for consistency.

Changes:

Adds a <details> block around installation results.
Removes the emoji from the failure heading and verifies disclosure markup.

Show a summary per file

File	Description
`actions/setup/js/install_frontmatter_skills.cjs`	Builds and renders the collapsible skill summary.
`actions/setup/js/install_frontmatter_skills.test.cjs`	Verifies the summary includes disclosure markup.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 2/2 changed files
Comments generated: 0
Review effort level: Medium

github-actions · 2026-07-29T14:36:02Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-07-29T14:36:22Z

✅ Test Quality Sentinel completed test quality analysis.

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

github-actions · 2026-07-29T14:36:33Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (0 additions detected in default business directories).

github-actions · 2026-07-29T14:36:42Z

✅ PR Code Quality Reviewer completed the code quality review.

github-actions

Skills-Based Review 🧠

Applied /codebase-design — the changes are clean and consistent with the project's progressive disclosure conventions. LGTM.

📋 Review Notes

Positive Highlights

✅ Single addRaw call replaces the previous multi-call pattern — simpler interface, richer behaviour
✅ <details> wrapping is consistent with how other step-summary sections are rendered
✅ Regression test updated to assert <details> is present
✅ Removing the ⚠️ emoji from the failures sub-heading aligns with project conventions

Minor Observation

The new test assertion (stringContaining('<details>')) covers the happy path. There is no existing test that exercises the failures code-path after the refactor (to confirm the failure lines still appear inside the block). This is low risk given the logic is straightforward, but a complementary assertion in a failure scenario would fully close the gap.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 19.2 AIC · ⌖ 4.82 AIC · ⊞ 6.8K
_{Comment /matt to run again}

github-actions

The change correctly wraps skill install details in a details block for cleaner step summaries. One non-blocking but notable issue: skill install failures are now hidden inside the collapsed block, and the warning emoji was removed — reducing their visibility. Consider rendering failures outside the details block or using 'details open' when failures are present.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 13.5 AIC · ⌖ 4.8 AIC · ⊞ 5.1K

github-actions · 2026-07-29T14:40:51Z

+  core.summary.addRaw(`### Frontmatter skills installed\n\n<details>\n<summary>Skill install details</summary>\n\n${body}\n</details>\n\n`);
  await core.summary.write();
 }



Skill install failures are now hidden inside the collapsed <details> block by default, and the ⚠️ warning emoji was also removed. If skills fail to install, a user scanning the step summary won't notice without expanding the block.

Consider either:

Keeping failures visible outside the <details> block (only collapse the success detail), or

Reopening the <details> block by default when failures exist: <details open>

@copilot please address this.

Fixed in the latest commit — writeSkillSummary now uses <details open> when failures.length > 0, so failures are visible by default without needing to expand the block. A test assertion for this behavior was added to the failure test case.

github-actions

Verdict: no blocking issues

Simple, correct refactor: builds a body string then wraps it once in a <details> block, matching the existing pattern used elsewhere. Test coverage for the new <details> wrapper was added.

Notes considered

The grumpy sub-agent flagged that f.skill/f.error values are interpolated unsanitized into the raw HTML/markdown body, which could theoretically break out of the <details> block if a skill spec or error message contained markdown/HTML-breaking sequences. This is pre-existing behavior carried over unchanged from the original addRaw calls (same interpolation, just built differently), not a regression introduced by this diff, so it's out of scope for this review — the diff itself is low risk.

Minor, non-blocking suggestion: consider adding a test for the empty-failures case to lock in that the #### Skill install failures section is omitted correctly inside the new wrapper, but this isn't required for merge.

🔎 Code quality review by PR Code Quality Reviewer · aut00 · 23.2 AIC · ⌖ 7.07 AIC · ⊞ 7.5K
_{Comment /review to run again}

github-actions · 2026-07-29T14:41:55Z

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

🧪 Test Quality Sentinel Report

⚠️ Test Quality Score: 70/100 — Acceptable

Analyzed 1 test(s): 1 design, 0 implementation, 0 violation(s).

📊 Metrics (1 test)

Metric	Value
Analyzed	1 (Go: 0, JS: 1)
✅ Design	1 (100%)
⚠️ Implementation	0 (0%)
Edge/error coverage	0 (0%)
Duplicate clusters	0
Inflation	No
🚨 Violations	0

Test	File	Classification	Issues
`reads skill specs...`	`install_frontmatter_skills.test.cjs:112`	`design_test / behavioral_contract / high_value`	Happy-path only; no edge/error assertions

Verdict

✅ passed. 0% implementation tests (threshold: 30%). The added assertion directly verifies the <details> progressive disclosure wrapper in the step summary output, matching the production change.

🧪 Test quality analysis by Test Quality Sentinel · sonnet46 · 33.9 AIC · ⊞ 8.1K · ◷
_{Comment /review to run again}

github-actions

✅ Test Quality Sentinel: 70/100. 0% implementation tests (threshold: 30%).

pelikhan · 2026-07-29T15:36:43Z

@copilot run pr-finisher skill

gh-aw-bot · 2026-07-29T15:42:18Z

@copilot please run the pr-finisher skill, address unresolved review feedback, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 10 AIC · ⌖ 6.62 AIC · ⊞ 7.8K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-29T21:02:45Z

🎉 This pull request is included in a new release.

Release: v0.84.0

feat: wrap skill install step summary in details element for progress…

5486611

…ive disclosure Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI assigned Copilot and pelikhan Jul 29, 2026

Copilot AI changed the title ~~feat: wrap skill install step summary in details element for progressive disclosure~~ feat: wrap skill install step summary in progressive disclosure details block Jul 29, 2026

Copilot created this pull request from a session on behalf of pelikhan July 29, 2026 14:24 View session

Copilot finished work on behalf of pelikhan July 29, 2026 14:24

Copilot AI requested a review from pelikhan July 29, 2026 14:24

pelikhan marked this pull request as ready for review July 29, 2026 14:26

Copilot AI review requested due to automatic review settings July 29, 2026 14:26

Copilot started reviewing on behalf of pelikhan July 29, 2026 14:26 View session

Copilot AI reviewed Jul 29, 2026

View reviewed changes

github-actions Bot approved these changes Jul 29, 2026

View reviewed changes

github-actions Bot reviewed Jul 29, 2026

View reviewed changes

github-actions Bot approved these changes Jul 29, 2026

View reviewed changes

github-actions Bot added the needs-review label Jul 29, 2026

Merge branch 'main' into copilot/add-progressive-disclosure-details

63d1aa4

Copilot started work on behalf of pelikhan July 29, 2026 15:37 View session

github-actions Bot mentioned this pull request Jul 29, 2026

[pr-sous-chef] pr-sous-chef run report #48748

Closed

fix: use <details open> when skill install failures exist for visibility

e5d682c

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot stopped work on behalf of pelikhan due to an error July 29, 2026 15:44
Workflow completed but conclusion is not available. This may indicate rate limiting or API issues.

Copilot started work on behalf of gh-aw-bot July 29, 2026 15:51 View session

pelikhan merged commit 18ed0b6 into main Jul 29, 2026
8 of 9 checks passed

pelikhan deleted the copilot/add-progressive-disclosure-details branch July 29, 2026 15:56

Copilot stopped work on behalf of gh-aw-bot due to an error July 29, 2026 15:56
The session was cancelled by the user.

Copilot AI requested a review from gh-aw-bot July 29, 2026 15:56

github-actions Bot mentioned this pull request Jul 29, 2026

[aw] No-Op Runs #48838

Open

Uh oh!

Conversation

Copilot AI commented Jul 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Positive Highlights

Minor Observation

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Verdict: no blocking issues

Uh oh!

github-actions Bot commented Jul 29, 2026

🧪 Test Quality Sentinel Report

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Jul 29, 2026

Uh oh!

gh-aw-bot commented Jul 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 29, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jul 29, 2026 •

edited

Loading

github-actions Bot commented Jul 29, 2026 •

edited

Loading

github-actions Bot commented Jul 29, 2026 •

edited

Loading

github-actions Bot commented Jul 29, 2026 •

edited

Loading