Closed
fix(test): normalize AWF models block in golden tests to decouple from model alias changes#48938
Conversation
…ilures
- Add testModelsBlockRE to normalizeOutput in wasm_golden_test.go, replacing
the \"models\":{...} AWF config section with a stable placeholder so golden
tests are resilient to future model alias changes (e.g. adding/removing
entries like fable from the large group).
- Regenerate all 9 affected golden files via make update-wasm-golden.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
fix: normalize models block in wasm golden tests to fix build-wasm failures
fix(test): normalize AWF models block in golden tests to decouple from model alias changes
Jul 29, 2026
Copilot created this pull request from a session on behalf of
pelikhan
July 29, 2026 16:07
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestWasmGolden_AllEnginesandTestWasmGolden_CompileFixtureswere failing because the full"models":{...}blob is embedded verbatim in compiled AWF configs — any change todata/model_aliases.json(in this case, removingfablefromlarge) caused all 9 golden files to diverge.Changes
wasm_golden_test.go— addstestModelsBlockREand applies it innormalizeOutput, replacing the\"models\":{...}section with a stable placeholder before golden comparison:This follows the same pattern already used for version numbers, container pins, and default model fallbacks.
9 golden files regenerated via
make update-wasm-goldento use the normalized form.Future changes to model aliases will no longer require golden file updates.