[WIP] Fix failing GitHub Actions job Integration: CMD Tests - #49110
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…llel subtests Cobra v1.10.2's Commands() method has a non-thread-safe lazy sort. When t.Parallel() subtests all call rootCmd.Commands() concurrently before the first sort has completed, multiple goroutines can corrupt the internal commands slice, causing commands to appear "missing". Fix by building a command lookup map once (serially) before any subtest calls t.Parallel(), so Commands() is invoked exactly once and the resulting map is read-only in all parallel subtests. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Attempts to fix flaky command-group integration tests by avoiding Cobra command lookups inside parallel subtests.
Changes:
- Precomputes command lookup maps before parallel subtests.
- Replaces repeated command scans with map access.
Show a summary per file
| File | Description |
|---|---|
cmd/gh-aw/command_groups_test.go |
Precomputes command maps to reduce concurrent Cobra sorting. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
cmd/gh-aw/command_groups_test.go:149
- This second lookup is built by another top-level test that also calls
t.Parallel(), so it can race with the lookup construction inTestCommandGroupAssignments. Moving the call ahead of only the parallel subtests does not prevent concurrentCommands()sorting across the two parent tests; use one shared pre-parallel lookup or make these parent tests run serially.
commandMap := make(map[string]*cobra.Command, len(rootCmd.Commands()))
for _, cmd := range rootCmd.Commands() {
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
Comment on lines
+76
to
+77
| commandMap := make(map[string]*cobra.Command, len(rootCmd.Commands())) | ||
| for _, cmd := range rootCmd.Commands() { |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.