Skip to content

feat: support sbx bounded-query runtime - #49247

Merged
lpcox merged 18 commits into
mainfrom
lpcox-add-sbx-query-runtime
Aug 2, 2026
Merged

feat: support sbx bounded-query runtime#49247
lpcox merged 18 commits into
mainfrom
lpcox-add-sbx-query-runtime

Conversation

@lpcox

@lpcox lpcox commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • accept tools.github.bounded-queries.runtime: sbx and emit the exact AWF boundedQueries.runtime: "sbx" contract
  • keep bounded-query runtime independent from sandbox.agent.runtime, with table-driven coverage for all nine Docker/gVisor/sbx combinations and no fallback
  • document and warn that sbx query execution is experimental, uses a fresh VM per query, and is capability-gated by AWF's fail-closed host preflight
  • update frontmatter/AWF schemas, autocomplete/reference artifacts, import-merge behavior, version gates, and invalid-value diagnostics

Dependency order

This compiler slice depends on the gh-aw-firewall bounded-query stack (#6762, #6763, #6764, and the final matrix PR) merging and shipping in AWF v0.28.0+ before runtime use. Current Docker Sandboxes v0.37.1 hosts remain unsupported by AWF preflight because mandatory isolation controls and a digest-pinned Python-only template are unavailable; neither gh-aw nor AWF rewrites or falls back to Docker/gVisor.

Validation

  • make build && make build-wasm
  • make golint
  • go test ./pkg/parser ./pkg/workflow -count=1
  • JSON/schema and generated-reference checks

The full pre-PR gate reached lint-cjs but the configured Microsoft npm proxy returned 404 for vite-8.1.0.tgz. make test-all also encountered unrelated existing/environment-sensitive failures outside the changed parser/workflow packages.


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 5.52 AIC · ⊞ 8.7K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Run: https://github.com/github/gh-aw/actions/runs/30606477668

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 7.91 AIC · ⊞ 8.7K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 7.69 AIC · ⊞ 5.7K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Run: https://github.com/github/gh-aw/actions/runs/30623846078

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 8.37 AIC · ⊞ 8.1K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Run: https://github.com/github/gh-aw/actions/runs/30627168508

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 10.8 AIC · ⊞ 5.7K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 16.7 AIC · ⊞ 8.1K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 6.21 AIC · ⊞ 8.1K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 6.38 AIC · ⊞ 5.7K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.19 AIC · ⊞ 8.1K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.88 AIC · ⊞ 8.1K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 8.29 AIC · ⊞ 8.1K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Run details: https://github.com/github/gh-aw/actions/runs/30678610470

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 18.9 AIC · ⊞ 5.7K ·
Comment /souschef to run again


Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

run_url: https://github.com/github/gh-aw/actions/runs/30683195966

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 20 AIC · ⊞ 8.1K ·
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · gpt54 · 20.6 AIC · ⌖ 7.02 AIC · ⊞ 8.1K ·
Comment /souschef to run again


Run URL: https://github.com/github/gh-aw/actions/runs/30719603092

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 4.21 AIC · ⌖ 6.88 AIC · ⊞ 8.1K ·
Comment /souschef to run again

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 31, 2026 02:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds experimental sbx support for bounded-query execution while keeping it independent from the primary agent sandbox.

Changes:

  • Extends parsing, validation, schemas, and AWF configuration with sbx.
  • Adds runtime-matrix, version-gate, merge, and compilation tests.
  • Documents capability gating, fail-closed behavior, and lack of fallback.
Show a summary per file
File Description
pkg/workflow/tools_types.go Defines bounded-query runtime constants.
pkg/workflow/tools_parser.go Parses the runtime type.
pkg/workflow/schemas/awf-config.schema.json Adds sbx to the AWF contract.
pkg/workflow/sandbox_validation.go Validates sbx and updates diagnostics.
pkg/workflow/compiler_validators.go Emits the experimental-runtime warning.
pkg/workflow/bounded_queries_test.go Updates parsing and JSON tests.
pkg/workflow/bounded_queries_runtime_test.go Adds runtime matrix and compilation tests.
pkg/workflow/awf_config.go Emits the typed runtime verbatim.
pkg/parser/schemas/main_workflow_schema.json Adds frontmatter schema support.
pkg/parser/frontmatter_merge_test.go Tests imported runtime merging.
docs/src/content/docs/reference/frontmatter-full.md Regenerates frontmatter reference documentation.
docs/public/editor/autocomplete-data.json Adds bounded-query autocomplete metadata.
.github/aw/syntax-agentic.md Documents syntax and isolation behavior.
.github/aw/create-agentic-workflow.md Adds workflow-authoring guidance.
.changeset/minor-add-sbx-bounded-query-runtime.md Records the minor feature.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 15/15 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment on lines +161 to +174
compiler := NewCompiler()
require.NoError(t, compiler.CompileWorkflow(testFile))

lockContent, err := os.ReadFile(filepath.Join(workflowsDir, "test-sbx-bounded-query.lock.yml"))
require.NoError(t, err)
assert.Contains(t, string(lockContent), "sbx")
assert.NotContains(t, string(lockContent), `"runtime":"docker-sbx"`)
assert.True(t, usesSbxBoundedQueryRuntime(&WorkflowData{
ParsedTools: &ToolsConfig{
GitHub: &GitHubToolConfig{
BoundedQueries: &BoundedQueriesConfig{Runtime: BoundedQueryRuntimeSbx},
},
},
}))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thread concerns were addressed in commit 618a592. TestSbxBoundedQueryFrontmatterCompilation now:

  1. Runs the full compiler (compiler.CompileWorkflow) rather than the direct helper, so the warning path is exercised.
  2. Captures stderr via captureStderrOutput and asserts "runtime: sbx is experimental" is emitted.
  3. Asserts the exact double-quote–escaped AWF JSON fragments (\"runtime\":\"sbx\" and \"boundedQueries\":{\"enabled\":true) in the lock file, not the loose "sbx" substring that could match the heading.

This thread is also marked outdated by GitHub since the code at lines 161-174 was rewritten in the same commit.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

@copilot please run the pr-finisher skill on this PR, fix the failing lint-go check (https://github.com/github/gh-aw/actions/runs/30600323549/job/91061347407), and then rerun the relevant checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 5.52 AIC · ⊞ 8.7K ·
Comment /souschef to run again

Copilot AI and others added 2 commits July 31, 2026 04:17
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[!WARNING]
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding....

Fixed the lint-go failure in commit fix: remove unnecessary type conversions flagged by unconvert linter. The unconvert linter flagged 4 unnecessary conversions (all in files changed by this PR) — because BoundedQueryRuntime is a type alias (= string), the string() and BoundedQueryRuntime() casts were identity no-ops:

  • bounded_queries_runtime_test.go:36string(queryRuntime)queryRuntime
  • bounded_queries_runtime_test.go:105string(runtime)runtime
  • sandbox_validation.go:345string(bq.Runtime)bq.Runtime
  • tools_parser.go:465BoundedQueryRuntime(runtime)runtime

make golint now passes with 0 issues; pkg/workflow and pkg/parser tests all pass. CI needs a human re-trigger to confirm.

Copilot AI requested a review from gh-aw-bot July 31, 2026 04:30
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

@copilot this PR needs maintainer follow-up. Please run the pr-finisher skill, bring the branch up to date, address any remaining review feedback, and rerun checks once ready. The PR is currently dirty and may need branch reconciliation before checks can pass.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 7.91 AIC · ⊞ 8.7K ·
Comment /souschef to run again

…untime

# Conflicts:
#	.github/workflows/ab-testing-advisor.lock.yml
#	.github/workflows/ace-editor.lock.yml
#	.github/workflows/agent-performance-analyzer.lock.yml
#	.github/workflows/agent-persona-explorer.lock.yml
#	.github/workflows/agentic-token-audit.lock.yml
#	.github/workflows/agentic-token-optimizer.lock.yml
#	.github/workflows/agentic-token-trend-audit.lock.yml
#	.github/workflows/archie.lock.yml
#	.github/workflows/architecture-guardian.lock.yml
#	.github/workflows/artifacts-summary.lock.yml
#	.github/workflows/auto-triage-issues.lock.yml
#	.github/workflows/bot-detection.lock.yml
#	.github/workflows/breaking-change-checker.lock.yml
#	.github/workflows/chaos-pr-bundle-fuzzer.lock.yml
#	.github/workflows/ci-coach.lock.yml
#	.github/workflows/cli-consistency-checker.lock.yml
#	.github/workflows/code-scanning-fixer.lock.yml
#	.github/workflows/code-simplifier.lock.yml
#	.github/workflows/commit-changes-analyzer.lock.yml
#	.github/workflows/constraint-solving-potd.lock.yml
#	.github/workflows/contribution-check.lock.yml
#	.github/workflows/copilot-centralization-drilldown.lock.yml
#	.github/workflows/copilot-centralization-optimizer.lock.yml
#	.github/workflows/copilot-cli-deep-research.lock.yml
#	.github/workflows/copilot-opt.lock.yml
#	.github/workflows/copilot-pr-merged-report.lock.yml
#	.github/workflows/copilot-pr-nlp-analysis.lock.yml
#	.github/workflows/copilot-pr-prompt-analysis.lock.yml
#	.github/workflows/craft.lock.yml
#	.github/workflows/daily-agent-of-the-day-blog-writer.lock.yml
#	.github/workflows/daily-ambient-context-optimizer.lock.yml
#	.github/workflows/daily-architecture-diagram.lock.yml
#	.github/workflows/daily-assign-issue-to-user.lock.yml
#	.github/workflows/daily-awf-spec-compiler-surfacing.lock.yml
#	.github/workflows/daily-byok-ollama-test.lock.yml
#	.github/workflows/daily-cli-performance.lock.yml
#	.github/workflows/daily-cli-tools-tester.lock.yml
#	.github/workflows/daily-community-attribution.lock.yml
#	.github/workflows/daily-compiler-quality.lock.yml
#	.github/workflows/daily-compiler-threat-spec-optimizer.lock.yml
#	.github/workflows/daily-credit-limit-test.lock.yml
#	.github/workflows/daily-doc-updater.lock.yml
#	.github/workflows/daily-experiment-report.lock.yml
#	.github/workflows/daily-file-diet.lock.yml
#	.github/workflows/daily-firewall-report.lock.yml
#	.github/workflows/daily-formal-spec-verifier.lock.yml
#	.github/workflows/daily-function-namer.lock.yml
#	.github/workflows/daily-geo-optimizer.lock.yml
#	.github/workflows/daily-github-docs-seo-optimizer.lock.yml
#	.github/workflows/daily-go-test-parallelizer.lock.yml
#	.github/workflows/daily-graft-intelligence.lock.yml
#	.github/workflows/daily-hippo-learn.lock.yml
#	.github/workflows/daily-issues-report.lock.yml
#	.github/workflows/daily-malicious-code-scan.lock.yml
#	.github/workflows/daily-max-ai-credits-test.lock.yml
#	.github/workflows/daily-mcp-concurrency-analysis.lock.yml
#	.github/workflows/daily-model-inventory.lock.yml
#	.github/workflows/daily-model-resolution.lock.yml
#	.github/workflows/daily-multi-device-docs-tester.lock.yml
#	.github/workflows/daily-news.lock.yml
#	.github/workflows/daily-performance-summary.lock.yml
#	.github/workflows/daily-regulatory.lock.yml
#	.github/workflows/daily-repo-chronicle.lock.yml
#	.github/workflows/daily-safe-output-integrator.lock.yml
#	.github/workflows/daily-secrets-analysis.lock.yml
#	.github/workflows/daily-security-observability.lock.yml
#	.github/workflows/daily-semgrep-scan.lock.yml
#	.github/workflows/daily-sentrux-report.lock.yml
#	.github/workflows/daily-skill-optimizer.lock.yml
#	.github/workflows/daily-spdd-spec-planner.lock.yml
#	.github/workflows/daily-spending-forecast.lock.yml
#	.github/workflows/daily-squid-image-scan.lock.yml
#	.github/workflows/daily-syntax-error-quality.lock.yml
#	.github/workflows/daily-team-status.lock.yml
#	.github/workflows/daily-testify-uber-super-expert.lock.yml
#	.github/workflows/daily-windows-terminal-integration-builder.lock.yml
#	.github/workflows/daily-workflow-updater.lock.yml
#	.github/workflows/dataflow-pr-discussion-dataset.lock.yml
#	.github/workflows/dead-code-remover.lock.yml
#	.github/workflows/delight.lock.yml
#	.github/workflows/dependabot-burner.lock.yml
#	.github/workflows/dependabot-go-checker.lock.yml
#	.github/workflows/deployment-incident-monitor.lock.yml
#	.github/workflows/designer-drift-audit.lock.yml
#	.github/workflows/dev-hawk.lock.yml
#	.github/workflows/dictation-prompt.lock.yml
#	.github/workflows/discussion-task-miner.lock.yml
#	.github/workflows/docs-noob-tester.lock.yml
#	.github/workflows/draft-pr-cleanup.lock.yml
#	.github/workflows/eslint-miner.lock.yml
#	.github/workflows/eslint-monster.lock.yml
#	.github/workflows/evoskill-evolver.lock.yml
#	.github/workflows/example-failure-category-filter.lock.yml
#	.github/workflows/example-permissions-warning.lock.yml
#	.github/workflows/firewall-escape.lock.yml
#	.github/workflows/firewall.lock.yml
#	.github/workflows/functional-pragmatist.lock.yml
#	.github/workflows/github-remote-mcp-auth-test.lock.yml
#	.github/workflows/glossary-maintainer.lock.yml
#	.github/workflows/gpclean.lock.yml
#	.github/workflows/impeccable-skills-reviewer.lock.yml
#	.github/workflows/issue-monster.lock.yml
#	.github/workflows/issue-triage-agent.lock.yml
#	.github/workflows/jsweep.lock.yml
#	.github/workflows/layout-spec-maintainer.lock.yml
#	.github/workflows/lint-monster.lock.yml
#	.github/workflows/linter-miner.lock.yml
#	.github/workflows/mattpocock-skills-reviewer.lock.yml
#	.github/workflows/mcp-inspector.lock.yml
#	.github/workflows/mergefest.lock.yml
#	.github/workflows/metrics-collector.lock.yml
#	.github/workflows/notion-issue-summary.lock.yml
#	.github/workflows/objective-impact-report.lock.yml
#	.github/workflows/org-health-report.lock.yml
#	.github/workflows/outcome-collector.lock.yml
#	.github/workflows/pdf-summary.lock.yml
#	.github/workflows/plan.lock.yml
#	.github/workflows/poem-bot.lock.yml
#	.github/workflows/pr-code-quality-reviewer.lock.yml
#	.github/workflows/pr-description-caveman.lock.yml
#	.github/workflows/pr-nitpick-reviewer.lock.yml
#	.github/workflows/pr-sous-chef.lock.yml
#	.github/workflows/pr-triage-agent.lock.yml
#	.github/workflows/python-data-charts.lock.yml
#	.github/workflows/q.lock.yml
#	.github/workflows/refactoring-cadence.lock.yml
#	.github/workflows/refiner.lock.yml
#	.github/workflows/release.lock.yml
#	.github/workflows/repo-audit-analyzer.lock.yml
#	.github/workflows/repo-tree-map.lock.yml
#	.github/workflows/repository-quality-improver.lock.yml
#	.github/workflows/research.lock.yml
#	.github/workflows/schema-consistency-checker.lock.yml
#	.github/workflows/security-compliance.lock.yml
#	.github/workflows/security-review.lock.yml
#	.github/workflows/sighthound-security-scan.lock.yml
#	.github/workflows/skillet.lock.yml
#	.github/workflows/slide-deck-maintainer.lock.yml
#	.github/workflows/smoke-copilot-aoai-apikey.lock.yml
#	.github/workflows/smoke-copilot-aoai-entra.lock.yml
#	.github/workflows/smoke-copilot-arm.lock.yml
#	.github/workflows/smoke-copilot-auto.lock.yml
#	.github/workflows/smoke-copilot-mai.lock.yml
#	.github/workflows/smoke-copilot-sdk.lock.yml
#	.github/workflows/smoke-copilot-small.lock.yml
#	.github/workflows/smoke-copilot-sub-agents.lock.yml
#	.github/workflows/smoke-copilot.lock.yml
#	.github/workflows/smoke-create-cross-repo-pr.lock.yml
#	.github/workflows/smoke-multi-pr.lock.yml
#	.github/workflows/smoke-otel-backends.lock.yml
#	.github/workflows/smoke-pi.lock.yml
#	.github/workflows/smoke-project.lock.yml
#	.github/workflows/smoke-service-ports.lock.yml
#	.github/workflows/smoke-temporary-id.lock.yml
#	.github/workflows/smoke-test-tools.lock.yml
#	.github/workflows/smoke-update-cross-repo-pr.lock.yml
#	.github/workflows/smoke-workflow-call-with-inputs.lock.yml
#	.github/workflows/smoke-workflow-call.lock.yml
#	.github/workflows/spec-enforcer.lock.yml
#	.github/workflows/spec-extractor.lock.yml
#	.github/workflows/spec-librarian.lock.yml
#	.github/workflows/stale-pr-cleanup.lock.yml
#	.github/workflows/stale-repo-identifier.lock.yml
#	.github/workflows/sub-issue-closer.lock.yml
#	.github/workflows/super-linter.lock.yml
#	.github/workflows/technical-doc-writer.lock.yml
#	.github/workflows/terminal-stylist.lock.yml
#	.github/workflows/test-quality-sentinel.lock.yml
#	.github/workflows/tidy.lock.yml
#	.github/workflows/ubuntu-image-analyzer.lock.yml
#	.github/workflows/uk-ai-operational-resilience.lock.yml
#	.github/workflows/unbloat-docs.lock.yml
#	.github/workflows/update-astro.lock.yml
#	.github/workflows/video-analyzer.lock.yml
#	.github/workflows/visual-regression-checker.lock.yml
#	.github/workflows/weekly-blog-post-writer.lock.yml
#	.github/workflows/weekly-editors-health-check.lock.yml
#	.github/workflows/weekly-issue-summary.lock.yml
#	.github/workflows/weekly-safe-outputs-spec-review.lock.yml
#	.github/workflows/workflow-generator.lock.yml
#	.github/workflows/workflow-health-manager.lock.yml
#	.github/workflows/workflow-normalizer.lock.yml
#	.github/workflows/workflow-skill-extractor.lock.yml

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved. All 183 conflicts were in .lock.yml files — the 98b3a9c commit on main normalized GH_AW_COMPILED_VERSION to dev for non-release builds, which conflicted with the version embedded in the branch's lock files. Merged origin/main, kept main's lock files, recompiled all 266 workflows (266/266 succeeded), confirmed make golint → 0 issues and all pkg/workflow + pkg/parser tests pass.

@pelikhan

Copy link
Copy Markdown
Collaborator

/review

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

⚠️ PR Code Quality Reviewer failed during code quality review.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot rename to "tools.micro-vms"?

@github-actions

Copy link
Copy Markdown
Contributor

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

🧪 Test Quality Sentinel Report

Test Quality Score: 90/100 — Excellent

Analyzed 3 test(s): 3 design, 0 implementation, 0 violation(s).

📊 Metrics (3 tests)
Metric Value
Analyzed 3 (Go: 3, JS: 0)
✅ Design 3 (100%)
⚠️ Implementation 0 (0%)
Edge/error coverage 2 (67%)
Duplicate clusters 0
Inflation No
🚨 Violations 0
Test File Classification Issues
TestBoundedQueryRuntimeMatrix bounded_queries_runtime_test.go:17 design_test, behavioral_contract, high_value None
TestBoundedQueryRuntimeVersionGate bounded_queries_runtime_test.go:99 design_test, behavioral_contract, high_value None
TestSbxBoundedQueryFrontmatterCompilation bounded_queries_runtime_test.go:133 design_test, behavioral_contract, high_value None

Modified tests in bounded_queries_test.go and frontmatter_merge_test.go add sbx runtime cases to existing table-driven suites.

Verdict

passed. 0% implementation tests (threshold: 30%). All 3 new tests enforce behavioral contracts: the runtime matrix test validates 3×3 agent/query runtime combinations with proper JSON output assertions; the version gate test enforces the minimum-version error path; the frontmatter compilation test does end-to-end compile verification. Build tags present on all new files. No mock library violations.

🧪 Test quality analysis by Test Quality Sentinel · sonnet46 · 50.1 AIC · ⊞ 8.4K ·
Comment /review to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Test Quality Sentinel: 90/100. 0% implementation tests (threshold: 30%). All 3 new tests are behavioral contracts with proper build tags and no mock library violations.

…nd-to-end contract assertions

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[!WARNING]
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding....

Addressed the review feedback in the latest commit. TestSbxBoundedQueryFrontmatterCompilation now:

  1. Captures compilation stderr via captureStderrOutput and asserts the experimental-sbx warning ("runtime: sbx is experimental") is emitted by the compiler warning path.
  2. Asserts the exact AWF JSON contract — checks for \"runtime\":\"sbx\" and \"boundedQueries\":{\"enabled\":true in the lock file's embedded printf payload (double-quote–escaped, as produced by shellEscapeArgWithVarsPreserved), rather than the loose "sbx" substring that could match the heading.
  3. Removes the direct usesSbxBoundedQueryRuntime helper call that bypassed the compiler, replacing it with the full compilation + lock-file inspection path.

Copilot AI commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

[!WARNING]
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding....

Branch is already up to date with origin/main (merge base = d2f373c). make golint passes with 0 issues.

Review thread (#discussion_r3687749528) — Marked outdated by GitHub; concerns were addressed in 618a592. A maintainer must click "Resolve conversation" to close it.

Rename question — Still awaiting @pelikhan's clarification. No code change will be made until the intended scope is confirmed (asked in a previous reply).

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

@copilot please run make merge-main to resolve conflicts and continue with the pr-finisher skill. The branch still needs maintainer follow-up on the unresolved review thread and the open clarification about whether sbx should be renamed to tools.micro-vms. If the branch is already current after make merge-main, confirm that state, keep the clarification request focused, and rerun the relevant checks once ready. Run details: https://github.com/github/gh-aw/actions/runs/30680808859

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 6.35 AIC · ⊞ 8.1K ·
Comment /souschef to run again

…untime

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

[!WARNING]
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding....

Merged latest main (b5ab73e). make agent-report-progress-no-test passes: 0 lint errors, 266/266 workflows compiled, lock files in sync.

Review thread (#discussion_r3687749528) — Marked outdated by GitHub; concerns were addressed in 618a592. A maintainer must click "Resolve conversation" to close it.

Rename question — Still awaiting @pelikhan's clarification. No code change will be made until the intended scope is confirmed.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

@copilot please run the pr-finisher skill and keep the maintainer follow-up focused.

Current context:

  • a reviewer thread already has a reply but remains unresolved
  • the open maintainer question about whether sbx should be renamed to tools.micro-vms is still blocking further code changes
  • no failed checks are listed in the compact candidate data

Please confirm branch freshness, identify any unresolved review thread IDs that are ready to resolve, and summarize exactly what clarification or maintainer action is still needed before handoff.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 20 AIC · ⊞ 8.1K ·
Comment /souschef to run again

Copilot AI commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

[!WARNING]
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding....

Branch freshness — ✅ Current with main. HEAD 79bbcd5 includes main through a9137e1 (the latest commit). No conflicts.

Local validation — ✅ make agent-report-progress-no-test passes: 0 lint errors, 266/266 workflows compiled, lock files in sync.


Unresolved review thread ready for maintainer resolution:

Thread ID File Status
PRRT_kwDOPc1QR86VTfUy (discussion_r3687749528) pkg/workflow/bounded_queries_runtime_test.go Outdated · Copilot replied (r3689611237) · awaiting maintainer click "Resolve conversation"

The reply (r3689611237) is substantive: it confirms all three concerns (end-to-end compiler path, stderr capture + warning assertion, exact AWF JSON fragment) were addressed in commit 618a592. The thread is marked outdated by GitHub because the code at the reviewed lines was rewritten. The agent cannot programmatically resolve review threads; a maintainer must click "Resolve conversation" in the GitHub UI.


Remaining maintainer action before handoff:

  1. Resolve the thread above — click "Resolve conversation" on discussion_r3687749528. No code change needed.

  2. Clarify the tools.micro-vms rename scope@pelikhan asked rename to "tools.micro-vms"? but the question is ambiguous. No code change will be made until one of these is confirmed:

    • A — rename only the runtime value (runtime: sbxruntime: micro-vms)
    • B — restructure the section (tools.github.bounded-queriestools.micro-vms.bounded-queries)
    • C — new sibling key alongside the existing bounded-queries block
  3. Re-trigger CI — a copilot check was running at triage time (started 04:12 UTC). CI does not re-run after agent pushes; a maintainer must re-trigger (close/reopen PR, workflow_dispatch, or a new push) once (1) and (2) are resolved.


Summary:

  • ✅ Reviews — thread PRRT_kwDOPc1QR86VTfUy has a complete Copilot reply; resolution requires a maintainer click
  • ✅ Checks (local) — 0 lint errors, 266/266 compiled, lock files in sync
  • ❓ Checks (CI) — stale after agent push; needs human re-trigger. Prior failures (lint-go) were fixed in committed code.
  • ✅ Mergeable — branch is current, no conflicts; mergeStateStatus: unstable reflects the in-progress check, not a conflict

Actions taken this run: none (branch already current, local validation already green, no new addressable review feedback).
Still needed: maintainer to (1) resolve the outdated thread, (2) confirm tools.micro-vms rename scope or close the question, (3) re-trigger CI.

@pelikhan

pelikhan commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved. The only conflict was in the auto-generated docs/src/content/docs/reference/frontmatter-full.md — both branches had added content. Resolved by regenerating the file from the merged schema (make generate-schema-docs), then recompiling all 266 workflows. Pushed as merge commit Merge branch 'main' into lpcox-add-sbx-query-runtime.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot quick triage for this PR:

  • Merge conflicts are blocking merge. Please run make merge-main, resolve the conflicts cleanly, rerun any impacted validation, and summarize the conflict resolution in your reply.
  • After conflicts are resolved, run the pr-finisher skill and summarize remaining maintainer-facing blockers before handoff.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 20.6 AIC · ⌖ 7.02 AIC · ⊞ 8.1K ·
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@copilot quick triage for this PR:

  • Merge conflicts are blocking merge. Please run make merge-main, resolve the conflicts cleanly, rerun any impacted validation, and summarize the conflict resoluti...

Resolved. One conflict in .github/workflows/daily-byok-ollama-test.lock.yml — main added "detection" and "evals" model aliases that weren't in the branch. Since lock files are auto-generated, accepted main's version and recompiled all 268 workflows (268/268 succeeded, lock files in sync).

Remaining maintainer blockers:

  1. Resolve review threaddiscussion_r3687749528 is outdated and has a complete reply. A maintainer must click "Resolve conversation" in the GitHub UI.

  2. Clarify tools.micro-vms rename scope@pelikhan asked rename to "tools.micro-vms"? but intent is ambiguous. No code change will be made until confirmed:

    • A — rename only the runtime value (runtime: sbxruntime: micro-vms)
    • B — restructure the section key (tools.github.bounded-queriestools.micro-vms.bounded-queries)
    • C — add a new sibling tools.micro-vms key alongside the existing block
  3. Re-trigger CI after (1) and (2) are resolved.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot
Please investigate this PR and move it toward merge readiness.
Please refresh the branch if needed, address any unresolved review feedback, and run the pr-finisher skill.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 4.21 AIC · ⌖ 6.88 AIC · ⊞ 8.1K ·
Comment /souschef to run again

Copilot AI commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@copilot
Please investigate this PR and move it toward merge readiness.
Please refresh the branch if needed, address any unresolved review feedback, and run the pr-finisher skill....

Branch is current with main (HEAD 1688fb6). Local validation is green:

  • make fmt — ✅ no changes
  • make lint — ✅ 0 errors (164 existing warnings, pre-existing and unrelated to this PR)
  • go test ./pkg/parser ./pkg/workflow — ✅ both packages pass

  • Reviews — The only unresolved review thread (PRRT_kwDOPc1QR86VTfUy, discussion_r3687749528) was substantively answered in a prior Copilot session (r3689611237) and is marked outdated by GitHub. The agent cannot programmatically resolve review threads — a maintainer must click "Resolve conversation" in the UI.
  • Checks (local) — All make targets pass on the current HEAD.
  • Checks (CI) — Stale after agent push; needs human re-trigger. The "copilot" check shown as in_progress is this session; dependabot check succeeded.
  • Mergeable — Not CONFLICTING, not BEHIND. mergeable_state: unstable reflects the in-progress CI check, not a structural issue.

Still needed before merge:

  1. @pelikhan — clarify (or close) the tools.micro-vms rename question (comment 5139692206). A prior Copilot reply asked which of three options was intended (A: rename the sbx value to micro-vms; B: restructure the section key; C: add a sibling key). No answer has been provided. No code change will be made until confirmed.
  2. Maintainer — resolve the outdated review thread via the GitHub UI.
  3. CI re-trigger — close/reopen the PR, push, or use workflow_dispatch to get a fresh green run.

@lpcox
lpcox merged commit 2145135 into main Aug 2, 2026
9 checks passed
@lpcox
lpcox deleted the lpcox-add-sbx-query-runtime branch August 2, 2026 00:16
@github-actions github-actions Bot mentioned this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants