-
Notifications
You must be signed in to change notification settings - Fork 477
Fix evals judge parser dropping YES/NO answers as UNKNOWN for Claude engine output #49323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a90ac3f
Initial plan
Copilot eaf56ef
Fix evals answer extraction for Claude native assistant JSONL events
Copilot 4ce71a6
Add regression tests for Claude assistant JSONL evals extraction fix
Copilot 03ce9f6
Merge branch 'main' into copilot/evals-daily-reports-2026-07-31
github-actions[bot] 7147347
Apply remaining changes
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/diagnosing-bugs] The two
ifbranches are independent, notelse if— anassistantevent with bothmessage.contentarray and a flatobj.contentstring would push text twice. In practice this shape doesn't appear, but usingelse ifmakes the mutual-exclusivity explicit and defends against unexpected future payloads.💡 Suggested fix
Using
else ifdocuments the intent that these two shapes are mutually exclusive and prevents double-counting if a future schema change produces an object with both fields.@copilot please address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in 7147347 — changed to
else ifso the two branches are mutually exclusive.