Fix `gh aw logs` discarding all processed runs due to variable shadowing by Copilot · Pull Request #49332 · github/gh-aw

Copilot · 2026-07-31T12:36:25Z

The daily token-audit workflow reported zero runs despite gh aw logs visibly downloading artifacts for ~100 runs over 7 minutes. The collection window was fine — gh aw logs was silently dropping every processed run.

In collectProcessedWorkflowRuns, the batch results were assigned with := inside the for body. Since the loop body is its own scope, this declared a new processedRuns that shadowed the function-level accumulator, so each batch's results were discarded at the end of the iteration:

for iteration < MaxIterations {
    ...
    // shadows the outer processedRuns — results never accumulate
    processedRuns, batchProcessed, allRunsConsumed, timedOut := processWorkflowRunBatch(
        runtime.activeCtx, batch, processedRuns, ...)
}

The knock-on effects: len(processedRuns) stayed at 0, so the count cap never tripped and the loop paginated through every available run, then exited via handleEmptyProcessedRuns with No workflow runs with artifacts found matching the specified criteria and .runs == [] in JSON output.

Changes

pkg/cli/logs_orchestrator_download.go — pre-declare the batch outputs and assign with = so runs accumulate across iterations. The batch flag is renamed to batchTimedOut to avoid colliding with the timedOut already declared earlier in the same block.
Test seams — logsFetchWorkflowRunBatch and logsProcessWorkflowRunBatch package vars, following the existing forecastListWorkflowRunsPaginated pattern, so the collection loop can be exercised without the GitHub API.
pkg/cli/logs_orchestrator_unit_test.go — TestCollectProcessedWorkflowRunsAccumulatesBatches drives two batches through the loop and asserts all three runs survive. It reproduces the bug on the pre-fix code (should have 3 item(s), but has 0).
Changeset — patch entry.

.github/workflows/agentic-token-audit.md is upstream-managed (source: githubnext/agentic-ops@…) and is deliberately untouched; the defect was in the CLI.

Worth noting for reviewers: the skip paths in shouldSkipProcessedWorkflowRun are verbose-gated, which is why the failure surfaced as a plausible-looking "empty window" rather than an error. No linter in .golangci.yml currently catches this class of shadowing.

Fixes [agentic-token-audit] 2026-07-31 — Empty log collection window, no AIC data to report #49331

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 16.7 AIC · ⊞ 8.1K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-31T12:56:30Z

PR Triage

Category: bug (log-collection fix)
Risk: low
Priority: 25/100 (impact 10, urgency 5, quality 10)
Recommended action: defer

Rationale: PR is marked [WIP], is a draft, has 0 diff (no committed changes yet), and CI check copilot is still in_progress. No files changed yet, nothing to review. Revisit once the fix is pushed and CI completes.

Labels applied: pr-type:bug, pr-risk:low, pr-priority:low, pr-action:defer, pr-agent:copilot.

Generated by 🔧 PR Triage Agent · auto · 38.1 AIC · ⌖ 7.66 AIC · ⊞ 7.9K · ◷

Copilot

Pull request overview

Fixes gh aw logs dropping processed runs because of loop-scoped variable shadowing.

Changes:

Preserves accumulated runs across batches.
Adds injectable test seams and a regression test.
Adds a patch changeset.

Show a summary per file

File	Description
`pkg/cli/logs_orchestrator_download.go`	Corrects batch-result assignment.
`pkg/cli/logs_orchestrator_unit_test.go`	Verifies multi-batch accumulation.
`.changeset/fix-logs-processed-runs-shadowing.md`	Documents the user-facing fix.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 3/3 changed files
Comments generated: 0
Review effort level: Balanced

gh-aw-bot · 2026-07-31T13:11:05Z

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

@copilot please run the pr-finisher skill on this PR. The branch refresh was requested from sous-chef run https://github.com/github/gh-aw/actions/runs/30632990067. Then confirm whether any remaining follow-up is needed before merge.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 16.7 AIC · ⊞ 8.1K · ◷
_{Comment /souschef to run again}

github-actions · 2026-07-31T13:22:07Z

✅ PR Code Quality Reviewer completed the code quality review.

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

github-actions · 2026-07-31T13:22:11Z

✅ Test Quality Sentinel completed test quality analysis.

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

github-actions · 2026-07-31T13:22:20Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #49332 does not have the implementation label and has only 59 new lines of code in business logic directories (threshold: 100).

github-actions · 2026-07-31T13:22:25Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Copilot · 2026-07-31T13:25:06Z

[!WARNING]
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding....

Ran the pr-finisher pass. No code changes were needed.

Branch is already current with main (behind=0 on 16f7657).
No unresolved review threads are present.
Local make fmt, make lint, make test-unit, and make test all passed.
The referenced sous-chef run had no failed jobs; the threat-detection note looks like a tooling-only failure.

Remaining follow-up before merge: let the current copilot check on this PR finish. If that completes successfully, I don’t see any other agent-actionable blocker.

github-actions

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

The fix is correct and the approach is clean.

The root cause (:= shadowing the outer processedRuns accumulator) is accurately identified and the fix (pre-declare + plain =) is the right minimal change.
The test seam pattern (logsFetchWorkflowRunBatch / logsProcessWorkflowRunBatch package vars with t.Cleanup restore) follows the existing convention and the regression test faithfully reproduces the bug.
batchTimedOut rename cleanly resolves the name collision.

No blocking issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 12.9 AIC · ⊞ 5.3K

github-actions · 2026-07-31T13:28:04Z

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

🎉 Great work! This PR looks ready for review. The variable shadowing bug is clearly identified and fixed, with a well-designed regression test that validates the batch accumulation across loop iterations. The changeset documentation is precise, and the refactoring (introducing test seams via logsFetchWorkflowRunBatch and logsProcessWorkflowRunBatch) follows the existing patterns in the codebase (like forecastListWorkflowRunsPaginated).

A few observations for maintainers:

Test design — The test effectively reproduces the original bug by verifying that runs from both batches accumulate (asserting len(runs) == 3 with specific DatabaseIDs from different batches).
Variable shadowing — Renaming timedOut to batchTimedOut avoids the collision and makes the code self-documenting.
Linter coverage — Worth noting that no existing linter in .golangci.yml catches this class of shadowing, which could be a future improvement.

The PR is small, focused, and ready to merge.

Generated by ✅ Contribution Check · auto · 56.6 AIC · ⊞ 8.7K · ◷

github-actions · 2026-07-31T13:28:31Z

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

🧪 Test Quality Sentinel Report

✅ Test Quality Score: 86/100 — Excellent

Analyzed 7 test(s): 7 design, 0 implementation, 0 violation(s).

📊 Metrics (7 tests)

Metric	Value
Analyzed	7 (Go: 7, JS: 0)
✅ Design	7 (100%)
⚠️ Implementation	0 (0%)
Edge/error coverage	6 (86%)
Duplicate clusters	0
Inflation	YES (test +46 lines vs prod +13 lines = 3.5:1)
🚨 Violations	0

Test	File	Classification	Issues
`TestIsDeadlineExceeded`	`logs_orchestrator_unit_test.go`	behavioral_contract, design_test	None
`TestNoRunsMessage`	`logs_orchestrator_unit_test.go`	behavioral_contract, design_test	None
`TestParseFilterDate`	`logs_orchestrator_unit_test.go`	behavioral_contract, design_test	None
`TestBuildContinuationIfNeeded`	`logs_orchestrator_unit_test.go`	behavioral_contract, design_test	None
`TestComputeLogsBatchSize`	`logs_orchestrator_unit_test.go`	behavioral_contract, design_test	None
`TestHandleEmptyWorkflowRunBatch`	`logs_orchestrator_unit_test.go`	behavioral_contract, design_test	None
`TestCollectProcessedWorkflowRunsAccumulatesBatches`	`logs_orchestrator_unit_test.go`	behavioral_contract, design_test	None

⚠️ Flagged (1 — inflation only)

Inflation (pkg/cli/logs_orchestrator_unit_test.go) — test file added 46 lines vs 13 in the production file (3.5:1). This exceeds the 2:1 threshold but is justified: the PR fixes a variable-shadowing bug and the tests cover multiple distinct behavioral contracts (deadline detection, message generation, date parsing, continuation cursor, batch sizing, pagination).

Verdict

✅ passed. 0% implementation tests (threshold: 30%). The regression test TestCollectProcessedWorkflowRunsAccumulatesBatches directly verifies the fixed bug using injected function vars, confirming runs accumulate across pagination iterations. All 7 tests carry descriptive assertion messages and cover error/edge paths.

🧪 Test quality analysis by Test Quality Sentinel · sonnet46 · 45.9 AIC · ⊞ 8.4K · ◷
_{Comment /review to run again}

github-actions

✅ Test Quality Sentinel: 86/100. 0% implementation tests (threshold: 30%).

github-actions

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Verdict: Approve — no blocking issues

Correct, minimal, well-tested fix for the := shadowing bug that discarded processedRuns on every batch.

Review notes

Fix: pre-declaring batchProcessed, allRunsConsumed, batchTimedOut and assigning with = correctly restores accumulation into the outer processedRuns. Verified no other := shadowing of this pattern exists elsewhere in the file.
Test seam: logsFetchWorkflowRunBatch / logsProcessWorkflowRunBatch package-level var indirection follows the existing forecastListWorkflowRunsPaginated convention in this package — consistent style, no other direct callers of fetchWorkflowRunBatch/processWorkflowRunBatch bypass it.
Regression test TestCollectProcessedWorkflowRunsAccumulatesBatches reproduces the bug pre-fix and passes post-fix. No t.Parallel() in this file, so the shared package-level var swap-and-restore via t.Cleanup is safe from cross-test races.
Renaming timedOut to batchTimedOut avoids the naming collision with the outer-scope timedOut, reducing future shadowing risk in this same function.

A background grumpy-coder sub-agent pass and my own independent review of the diff found no additional correctness, concurrency, or maintainability issues within the changed lines.

🔎 Code quality review by PR Code Quality Reviewer · auto · 54.7 AIC · ⊞ 7.8K
_{Comment /review to run again}

github-actions

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd — approving. The root cause is correctly identified and fixed, and the regression test faithfully reproduces the original failure.

📋 Key Themes & Highlights

Key Themes

Root cause fixed, not just the symptom — the := shadowing is eliminated by pre-declaring variables before the loop and using = assignment
Regression test covers the exact failure mode — TestCollectProcessedWorkflowRunsAccumulatesBatches would have caught this before the bad code shipped
Test seams follow the established forecastListWorkflowRunsPaginated pattern — consistent and easy to navigate

Positive Highlights

✅ Informative inline comment explaining why = is used (not :=) — prevents future contributors from reintroducing the bug
✅ batchTimedOut rename avoids a collision with the outer timedOut; clearer scope separation
✅ Changeset entry is accurate and user-facing
✅ Test uses t.Cleanup to restore the package-level vars — safe for parallel future tests

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 38.7 AIC · ⊞ 7K
_{Comment /matt to run again}

github-actions · 2026-07-31T14:15:02Z

🎉 This pull request is included in a new release.

Release: v0.84.1

Initial plan

a1df179

Copilot AI assigned Copilot and pelikhan Jul 31, 2026

Copilot AI linked an issue Jul 31, 2026 that may be closed by this pull request

[agentic-token-audit] 2026-07-31 — Empty log collection window, no AIC data to report #49331

Closed

Copilot started work on behalf of pelikhan July 31, 2026 12:37 View session

Copilot AI and others added 2 commits July 31, 2026 12:52

Fix gh aw logs discarding processed runs due to variable shadowing

e450957

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Add changeset for logs processed-runs fix

16f7657

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix empty log collection for agentic token audit~~ Fix gh aw logs discarding all processed runs due to variable shadowing Jul 31, 2026

Copilot AI requested a review from pelikhan July 31, 2026 12:55

Copilot finished work on behalf of pelikhan July 31, 2026 12:55

github-actions Bot added pr-action:defer pr-agent:copilot pr-priority:low pr-risk:low pr-type:bug labels Jul 31, 2026

github-actions Bot mentioned this pull request Jul 31, 2026

[PR Triage Report] PR Triage Report — 2026-07-31 (Run 30631968625) #49335

Closed

pelikhan marked this pull request as ready for review July 31, 2026 13:02

Copilot AI review requested due to automatic review settings July 31, 2026 13:02

Copilot started reviewing on behalf of pelikhan July 31, 2026 13:03 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jul 31, 2026

[pr-sous-chef] pr-sous-chef run report - 2026-07-31T04:08:00Z #49257

Closed

Copilot started work on behalf of gh-aw-bot July 31, 2026 13:11 View session

Copilot AI requested a review from gh-aw-bot July 31, 2026 13:25

Copilot finished work on behalf of gh-aw-bot July 31, 2026 13:25

github-actions Bot approved these changes Jul 31, 2026

View reviewed changes

This was referenced Jul 31, 2026

[Contribution Check Report] Contribution Check — 2026-07-31 #49244

Closed

[aw] No-Op Runs #48838

Open

github-actions Bot approved these changes Jul 31, 2026

View reviewed changes

github-actions Bot reviewed Jul 31, 2026

View reviewed changes

github-actions Bot approved these changes Jul 31, 2026

View reviewed changes

github-actions Bot added the needs-review label Jul 31, 2026

pelikhan merged commit ccf88b8 into main Jul 31, 2026
86 of 96 checks passed

pelikhan deleted the copilot/agentic-token-audit-2026-07-31 branch July 31, 2026 13:33

This was referenced Jul 31, 2026

[aw] Daily Fact reported incomplete result #49356

Closed

Smoke Test: MAI-Code-1-Flash - 30689986700 #49532

Closed

Uh oh!

Conversation

Copilot AI commented Jul 31, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

github-actions Bot commented Jul 31, 2026

PR Triage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

gh-aw-bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Jul 31, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

🧪 Test Quality Sentinel Report

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Verdict: Approve — no blocking issues

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 31, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jul 31, 2026 •

edited

Loading

github-actions Bot commented Jul 31, 2026 •

edited

Loading

github-actions Bot commented Jul 31, 2026 •

edited

Loading

github-actions Bot commented Jul 31, 2026 •

edited

Loading