SPDD spec sync: fixture traceability, outcome-eval crosswalk, and OTLP credential redaction norms - #49596
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Nice work on the spec sync! 👏 This PR tightens the traceability between formal specs and test coverage across intent-attribution, replace-label compliance, outcome evaluation, and OTel observability—exactly what the SPDD daily review flagged. The changes are:
This looks ready for review!
|
PR Triage
Draft; SPDD spec sync incl. OTel outcome/redaction norms. OTEL-FLAGGED.
|
|
cc
|
There was a problem hiding this comment.
Pull request overview
Aligns SPDD specifications across fixture traceability, outcome evaluation, provenance, and OTLP credential handling.
Changes:
- Adds fixture and compliance-test cross-references.
- Clarifies bot/app provenance and outcome taxonomy.
- Strengthens OTLP credential-redaction requirements.
Show a summary per file
| File | Description |
|---|---|
specs/safe-output-outcome-evaluation.md |
Adds provenance rules, test mapping, and changelog. |
specs/replace-label-spec.md |
Maps test IDs to compliance fixtures. |
specs/replace-label-compliance/README.md |
Records behavioral coverage parity. |
specs/otel-observability-spec.md |
Aligns outcome attributes and redaction norms. |
specs/intent-attribution-agent-governance.md |
Adds explicit fixture paths. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 5
- Review effort level: Balanced
| @@ -3,7 +3,7 @@ title: Safe Output Outcome Evaluation Specification | |||
| version: 1.0.0 | |||
| | §1 | `create_pull_request` | `pkg/cli/outcome_eval_formal_test.go` | covered | | ||
| | §2 | `create_issue` | `pkg/cli/outcome_eval_formal_test.go` | covered | | ||
| | §3 | `add_comment` | `pkg/cli/outcome_eval_formal_test.go` | covered | |
|
|
||
| Fixture linkage check (2026-08-01): | ||
|
|
||
| - [x] T-RL-020 covered by `specs/replace-label-compliance/rl-001-glob-semantics.yaml` |
| - [x] T-RL-020 covered by `specs/replace-label-compliance/rl-001-glob-semantics.yaml` | ||
| - [x] T-RL-021 covered by `specs/replace-label-compliance/rl-001-glob-semantics.yaml` | ||
| - [x] T-RL-022 covered by `specs/replace-label-compliance/rl-001-glob-semantics.yaml` | ||
| - [x] T-RL-023 covered by `specs/replace-label-compliance/rl-001-glob-semantics.yaml` and `specs/replace-label-compliance/rl-003-blocklist-ordering.yaml` |
| - `explicit-intent-wins.yaml` | ||
| - `ambiguous-root-closing-issues.yaml` | ||
| - `unlinked-pr-fail-closed.yaml` | ||
| - `specs/intent-attribution-compliance/explicit-intent-wins.yaml` |
|
🎉 This pull request is included in a new release. Release: |
Daily SPDD review flagged sync drift risks across intent-attribution, replace-label compliance, and outcome-evaluation/OTel specs. This PR tightens spec-to-fixture/spec-to-test traceability and aligns provenance + outcome semantics across the related documents.
Intent-attribution fixture traceability
specs/intent-attribution-agent-governance.mdRFC 2119 fixture list to reference explicit fixture paths underspecs/intent-attribution-compliance/to keep governance and conformance artifacts directly linked.Replace-label compliance parity documentation
specs/replace-label-compliance/README.mdconfirming Behavioral Coverage Map parity withpkg/workflow/replace_label_formal_test.go(P1–P15 + 3 edge cases).specs/replace-label-spec.md§9.2 mappingT-RL-020…T-RL-025torl-001/rl-002/rl-003fixtures.Outcome evaluation spec crosswalk + provenance clarification
specs/safe-output-outcome-evaluation.md, clarified Provenance Limits for GitHub App/bot-visible activity handling inhuman_*fields.not-started.OTel outcome semantics + security tightening
specs/otel-observability-spec.md§13, aligned outcome attributes towardgh-aw.outcome.repo(with compatibility alias guidance) and referenced canonical outcome taxonomy.OTEL_EXPORTER_OTLP_HEADERSand equivalent credential-bearing headers in direct-export mode.