-
Notifications
You must be signed in to change notification settings - Fork 495
refactor: extract shared pi-agent-core driver helpers to eliminate duplication #49665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+59
−45
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9ba0f79
Initial plan
Copilot 16b41b9
refactor: extract shared emitJsonl/getApiKey into pi_agent_core_drive…
Copilot cc5ae0d
Merge branch 'main' into copilot/duplicate-code-fix
github-actions[bot] 70d4751
Merge branch 'main' into copilot/duplicate-code-fix
github-actions[bot] acff48f
fix: resolve sample driver helper via RUNNER_TEMP runtime path
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| // @ts-check | ||
|
|
||
| /** | ||
| * Shared helpers for pi-agent-core drivers. | ||
| * | ||
| * Consumed by both the built-in driver (pi_agent_core_driver.cjs) and the | ||
| * sample driver (.github/drivers/pi_agent_core_driver_sample_node.cjs) so | ||
| * that JSONL formatting and provider key resolution have a single source of | ||
| * truth. | ||
| */ | ||
|
|
||
| "use strict"; | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // JSONL emitter | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| /** @param {unknown} obj */ | ||
| function emitJsonl(obj) { | ||
| process.stdout.write(JSON.stringify(obj) + "\n"); | ||
| } | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // Built-in provider API key resolution | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| /** | ||
| * Resolve an API key for the given provider name from well-known environment | ||
| * variables. Returns `undefined` when no matching variable is set. | ||
| * | ||
| * @param {string} provider | ||
| * @returns {string|undefined} | ||
| */ | ||
| function getApiKey(provider) { | ||
| switch (provider) { | ||
| case "github-copilot": | ||
| case "copilot": | ||
| return process.env.COPILOT_GITHUB_TOKEN || process.env.GITHUB_TOKEN; | ||
| case "anthropic": | ||
| return process.env.ANTHROPIC_API_KEY; | ||
| case "openai": | ||
| case "codex": | ||
| return process.env.CODEX_API_KEY || process.env.OPENAI_API_KEY; | ||
| default: | ||
| return undefined; | ||
| } | ||
| } | ||
|
|
||
| module.exports = { emitJsonl, getApiKey }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/codebase-design] The exported name
getApiKeydoes not signal that it only covers built-in providers. The main driver already aliases it asgetBuiltinApiKeyat the import site, which is the clearer name — rename the export to match so the public surface is self-documenting and the alias is unnecessary.💡 Suggested rename
Consistent naming prevents future callers from confusing the helper with a fully generic key resolver.
@copilot please address this.