Increase Metrics Collector repo-memory patch cap to prevent push_repo_memory gate failures by Copilot · Pull Request #49970 · github/gh-aw

Copilot · 2026-08-03T12:14:48Z

Metrics Collector’s push_repo_memory job failed when a daily metrics update generated a ~131KB patch against a 10KB cap (12KB effective with overhead). This change raises the workflow’s patch-size limit to accommodate current metrics payload size while preserving existing retention/pruning behavior.

Scope: Repo-memory cap adjustment (Metrics Collector)
- Updated .github/workflows/metrics-collector.md to set a higher repo-memory patch limit:
  - tools.repo-memory.max-patch-size: 131072 (128KB)
Scope: Compiled workflow parity
- Recompiled .github/workflows/metrics-collector.lock.yml so runtime config matches source:
  - Safe-outputs push_repo_memory.memories[].max_patch_size now 131072
  - push_repo_memory env MAX_PATCH_SIZE now 131072
  - Generated memory-constraints text now reflects 128KB
Scope: No behavioral change outside cap
- 30-day pruning logic for metrics/daily/*.json is unchanged.

tools:
  repo-memory:
    branch-name: memory/meta-orchestrators
    file-glob: "metrics/**"
    max-patch-size: 131072

Fixes [aw-failures] Metrics Collector push_repo_memory hard-fails on 131KB patch vs 10KB cap #49931

Run: https://github.com/github/gh-aw/actions/runs/30820387900

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 13.2 AIC · ⌖ 5.18 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-08-03T13:04:39Z

@copilot review push_repo_memory patch size computation and ensure it does not measure the entire changes, just the diff. Reuse heleprs from push_evals_state

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-08-03T13:20:09Z

@copilot review push_repo_memory patch size computation and ensure it does not measure the entire changes, just the diff. Reuse heleprs from push_evals_state

Updated in 154bd8c.

push_repo_memory now scopes status/staging to managed memory pathspecs and computes patch size from staged diff bytes via getStagedPatchDiffSizeBytes with explicit cwd, so it measures only the intended diff rather than unrelated workspace changes. I also updated tests to cover the pathspec-based staging/status behavior.

github-actions · 2026-08-03T13:24:27Z

✅ Test Quality Sentinel completed test quality analysis.

github-actions · 2026-08-03T13:24:31Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-08-03T13:24:42Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has 0 new lines of code in business logic directories.

github-actions · 2026-08-03T13:25:24Z

⚠️ PR Code Quality Reviewer failed during code quality review.

github-actions · 2026-08-03T13:25:53Z

🔍 PR Triage

Category: chore · Risk: low · Total score: 40/100

Impact	Urgency	Quality
18/50	12/30	10/20

Raises Metrics Collector repo-memory patch-size cap (10KB → 128KB) to fix push_repo_memory gate failures. PR is currently marked draft.

Recommended action: defer — small config fix, low urgency; convert out of draft before merging.

Generated by 🔧 PR Triage Agent · auto · 55.7 AIC · ⌖ 4.24 AIC · ⊞ 8K · ◷

Copilot

Pull request overview

Raises Metrics Collector’s repo-memory patch cap to handle larger daily snapshots.

Changes:

Raises the cap to 128KB and recompiles the workflow.
Changes global repo-memory Git staging behavior and tests.
Adds an unrelated workflow-skill reference.

Show a summary per file

File	Description
`.github/workflows/metrics-collector.md`	Configures the larger patch cap.
`.github/workflows/metrics-collector.lock.yml`	Propagates the cap into generated runtime configuration.
`actions/setup/js/push_repo_memory.cjs`	Scopes Git operations to copied memory paths.
`actions/setup/js/push_repo_memory.test.cjs`	Updates source assertions for scoped Git operations.
`.github/skills/agentic-workflows/SKILL.md`	Adds an observability-document reference.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 5/5 changed files
Comments generated: 3
Review effort level: Balanced

  }

-  // Check if we have any changes to commit
+  const changedPathspecs = Array.from(new Set(filesToCopy.map(file => file.relativePath))).sort();


-  // Check if we have any changes to commit
+  const changedPathspecs = Array.from(new Set(filesToCopy.map(file => file.relativePath))).sort();
+
+  // Check if we have any changes to commit, scoped to managed memory files only.


github-actions

The changes are correct and consistent across all layers.

The 128KB patch cap is a reasonable fix for observed gate failures on large daily metrics snapshots.
Scoping git status --porcelain and git add --sparse to changedPathspecs is a correctness improvement that avoids accidentally counting or staging files outside the managed memory scope.
The cwd parameter is already accepted by getStagedPatchDiffSizeBytes, so that wiring is correct.
The empty-pathspecs fallback (git add --sparse .) preserves existing behavior.
Tests accurately reflect the new code paths.
Lock file is consistent with the workflow source.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 22.7 AIC · ⌖ 10.3 AIC · ⊞ 5.4K

github-actions · 2026-08-03T13:29:40Z

🧪 Test Quality Sentinel Report

✅ Test Quality Score: 100/100 — Excellent

Analyzed 2 test(s): 2 design, 0 implementation, 0 violation(s).

📊 Metrics (2 tests)

Metric	Value
Analyzed	2 (JavaScript/vitest)
✅ Design	2 (100%)
⚠️ Implementation	0 (0%)
Edge/error coverage	2 (100%)
Duplicate clusters	0
Inflation	No (0.29:1 ratio)
🚨 Violations	0

Test	File	Classification	Focus
`should use git add --sparse to handle sparse-checkout on orphan branch creation`	push_repo_memory.test.cjs:1060	design_test	Pathspec-scoped git staging safety
`should enforce MAX_FILE_COUNT against changed files...`	push_repo_memory.test.cjs:1559	design_test	File count enforcement with pathspec limits

Key Observations

Both tests are source verification tests that validate the production implementation matches critical security and functional invariants:

Test 1 verifies that git add --sparse uses pathspec-scoped staging (fixes sparse-checkout failures)
Test 2 verifies that file counting uses pathspec-limited git status (prevents counting unrelated files)

Test changes align with production changes: The assertions were updated to reflect the new pathspec-scoped architecture (using ...changedPathspecs) while maintaining coverage of the critical design invariants.

Verdict

✅ passed. 0% implementation tests (threshold: 30%). All tests verify behavioral contracts, not implementation details.

🧪 Test quality analysis by Test Quality Sentinel · haiku45 · 14.8 AIC · ⌖ 4.92 AIC · ⊞ 8.5K · ◷
_{Comment /review to run again}

github-actions

✅ Test Quality Sentinel: 100/100. 0% implementation tests (threshold: 30%). All tests verify behavioral contracts.

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd — one minor dead-code finding; overall the fix is clean and well-reasoned.

📋 Key Themes & Highlights

Key Themes

Root cause properly addressed: The 10KB cap was genuinely too small for ~131KB daily metrics snapshots; raising to 128KB is a rational, measured increase.
Pathspec-scoped git ops: Refactoring git status and git add to target only managed memory paths is the right defensive move for sparse-checkout environments.
Dead branch: The else { addArgs.push(".") } fallback in git add is unreachable (noted in inline comment).

Positive Highlights

✅ PR description clearly documents the root cause with concrete byte counts.
✅ metrics-collector.lock.yml recompiled in sync — no config drift.
✅ cwd: workspaceDir consistently threaded through all git calls.
✅ Tests updated to assert the new pathspec-based behavior rather than just removing the old assertion.
✅ Comment in metrics-collector.md explains why 128KB is needed, which helps future reviewers reason about the cap.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 37.9 AIC · ⌖ 8.03 AIC · ⊞ 7.1K
_{Comment /matt to run again}

github-actions · 2026-08-03T13:32:07Z

+    const addArgs = ["add", "--sparse"];
+    if (changedPathspecs.length > 0) {
+      addArgs.push("--", ...changedPathspecs);
+    } else {


[/diagnosing-bugs] Dead code: the else { addArgs.push(".") } branch (lines 546–548) is unreachable — filesToCopy is guaranteed non-empty at this point (line 400 returns early when it is empty), so changedPathspecs will always be non-empty here.

💡 Suggestion

Remove the dead branch and rely on the early-return guarantee:

// changedPathspecs is always non-empty here (filesToCopy emptiness is checked at line 400) addArgs.push("--", ...changedPathspecs);

Leaving the fallback "." in place makes the sparse-checkout safety invariant harder to reason about and could mask a future regression if the early-return is ever removed.

@copilot please address this.

gh-aw-bot · 2026-08-03T14:05:48Z

@copilot sous-chef triage:

Failed checks:

agent: https://github.com/github/gh-aw/actions/runs/30817695295/job/91700123879

Please refresh the branch if needed and then run the skill.

Generated by 👨🍳 PR Sous Chef · run: https://github.com/github/gh-aw/actions/runs/30820387900

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 13.2 AIC · ⌖ 5.18 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

github-actions · 2026-08-04T18:04:42Z

🎉 This pull request is included in a new release.

Release: v0.84.4

Initial plan

2811ace

Copilot AI assigned Copilot and pelikhan Aug 3, 2026

Copilot started work on behalf of pelikhan August 3, 2026 12:24 View session

Copilot AI linked an issue Aug 3, 2026 that may be closed by this pull request

[aw-failures] Metrics Collector push_repo_memory hard-fails on 131KB patch vs 10KB cap #49931

Closed

Increase Metrics Collector repo-memory patch cap

45c3bd9

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix push_repo_memory patch-size cap breach in Metrics Collector~~ Increase Metrics Collector repo-memory patch cap to prevent push_repo_memory gate failures Aug 3, 2026

Copilot finished work on behalf of pelikhan August 3, 2026 12:45

Copilot AI requested a review from pelikhan August 3, 2026 12:45

Copilot started work on behalf of pelikhan August 3, 2026 13:05 View session

Copilot AI and others added 2 commits August 3, 2026 13:10

Plan patch-size computation fix

4c8f314

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Scope repo-memory patch size to managed diff

154bd8c

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan August 3, 2026 13:20

pelikhan marked this pull request as ready for review August 3, 2026 13:22

Copilot AI review requested due to automatic review settings August 3, 2026 13:22

Copilot started reviewing on behalf of pelikhan August 3, 2026 13:23 View session

github-actions Bot added pr-action:defer pr-agent:github-copilot pr-priority:medium pr-risk:low pr-type:chore labels Aug 3, 2026

github-actions Bot mentioned this pull request Aug 3, 2026

[PR Triage Report] PR Triage Report — 2026-08-03 (Run 30816946909) #49993

Closed

Copilot AI reviewed Aug 3, 2026

View reviewed changes

github-actions Bot approved these changes Aug 3, 2026

View reviewed changes

github-actions Bot reviewed Aug 3, 2026

View reviewed changes

Merge branch 'main' into copilot/aw-failures-fix-push-repo-memory

35366a9

github-actions Bot mentioned this pull request Aug 3, 2026

[pr-sous-chef] PR Sous Chef run report - 2026-08-03T00:15:52Z #49872

Closed

Copilot started work on behalf of gh-aw-bot August 3, 2026 14:06 View session

Apply remaining changes

b0889c4

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 3, 2026 14:22

Copilot AI requested a review from gh-aw-bot August 3, 2026 14:22

Merge branch 'main' into copilot/aw-failures-fix-push-repo-memory

f8c6f45

pelikhan merged commit 7570484 into main Aug 3, 2026
9 checks passed

pelikhan deleted the copilot/aw-failures-fix-push-repo-memory branch August 3, 2026 15:12

Uh oh!

Conversation

Copilot AI commented Aug 3, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan commented Aug 3, 2026

Uh oh!

Copilot AI commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 3, 2026

🔍 PR Triage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 3, 2026

🧪 Test Quality Sentinel Report

Key Observations

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

github-actions Bot Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Aug 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 3, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading