Suppress RGS-012 false positive on the gVisor install step - #51322
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix secret exfiltration via outbound HTTP request
Suppress RGS-012 false positive on the gVisor install step
Aug 8, 2026
pelikhan
marked this pull request as ready for review
August 8, 2026 06:18
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses #51309 by suppressing false-positive RGS-012 findings for generated gVisor installation steps.
Changes:
- Adds generated inline suppression comments.
- Adds a gVisor-specific Runner Guard filter and tests.
- Regenerates affected workflow lock files.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/copilot_engine_installation.go |
Emits suppression comments. |
pkg/cli/runner_guard.go |
Applies the new filter. |
pkg/cli/runner_guard_gvisor_exfiltration.go |
Implements gVisor finding filtering. |
pkg/cli/runner_guard_gvisor_exfiltration_test.go |
Tests filtering behavior. |
.github/workflows/code-simplifier.lock.yml |
Regenerated suppression directives. |
.github/workflows/code-scanning-fixer.lock.yml |
Regenerated suppression directives. |
.github/workflows/cloclo.lock.yml |
Regenerated suppression directives. |
.github/workflows/cli-version-checker.lock.yml |
Regenerated suppression directives. |
.github/workflows/cli-consistency-checker.lock.yml |
Regenerated suppression directives. |
.github/workflows/claude-code-user-docs-review.lock.yml |
Regenerated suppression directives. |
.github/workflows/ci-coach.lock.yml |
Regenerated suppression directives. |
.github/workflows/chaos-pr-bundle-fuzzer.lock.yml |
Regenerated suppression directives. |
.github/workflows/changeset.lock.yml |
Regenerated suppression directives. |
.github/workflows/breaking-change-checker.lock.yml |
Regenerated suppression directives. |
.github/workflows/bot-detection.lock.yml |
Regenerated suppression directives. |
.github/workflows/blog-auditor.lock.yml |
Regenerated suppression directives. |
.github/workflows/aw-failure-investigator.lock.yml |
Regenerated suppression directives. |
.github/workflows/avenger.lock.yml |
Regenerated suppression directives. |
.github/workflows/auto-triage-issues.lock.yml |
Regenerated suppression directives. |
.github/workflows/audit-workflows.lock.yml |
Regenerated suppression directives. |
.github/workflows/artifacts-summary.lock.yml |
Regenerated suppression directives. |
.github/workflows/archivx-agentic-workflows-analyzer.lock.yml |
Regenerated suppression directives. |
.github/workflows/architecture-guardian.lock.yml |
Regenerated suppression directives. |
.github/workflows/archie.lock.yml |
Regenerated suppression directives. |
.github/workflows/approach-validator.lock.yml |
Regenerated suppression directives. |
.github/workflows/api-consumption-report.lock.yml |
Regenerated suppression directives. |
.github/workflows/ai-moderator.lock.yml |
Regenerated suppression directives. |
.github/workflows/agentic-token-trend-audit.lock.yml |
Regenerated suppression directives. |
.github/workflows/agent-persona-explorer.lock.yml |
Regenerated suppression directives. |
.github/workflows/agent-performance-analyzer.lock.yml |
Regenerated suppression directives. |
.github/workflows/ace-editor.lock.yml |
Regenerated suppression directives. |
.github/workflows/ab-testing-advisor.lock.yml |
Regenerated suppression directives. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 32/32 changed files
- Comments generated: 3
- Review effort level: Balanced
Comment on lines
+81
to
+88
| if lineNum <= 1 { | ||
| for _, line := range lines { | ||
| if isStepNameLine(line, gvisorStepNameMarker) { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } |
| if !isStepBoundaryLine(line) { | ||
| continue | ||
| } | ||
| return isStepNameLine(line, gvisorStepNameMarker) |
| ` ARCH=$(uname -m)`, | ||
| ` URL="https://storage.googleapis.com/gvisor/releases/release/` + version + `/${ARCH}"`, | ||
| ` echo "Downloading runsc ` + version + ` for ${ARCH}..."`, | ||
| ` # runner-guard:ignore RGS-012 -- pinned version + SHA-512-verified download of a fixed artifact into a file; no data leaves the runner.`, |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runner-guard's RGS-012 rule (secret exfiltration via outbound HTTP) flagged the compiler-generated "Install gVisor (runsc)" step across 59 workflow files. The step downloads a pinned gVisor release from
storage.googleapis.comand verifies it via SHA-512 before install — no secrets ever leave the runner — so this is a false positive that will keep re-triggering on every new/changed workflow that enables the sandbox.Suppress at the source
# runner-guard:ignore RGS-012comments above the curl download lines ingenerateGVisorInstallStep(pkg/workflow/copilot_engine_installation.go), documenting the pinned-version + SHA-512-verified rationale..lock.yml.Defense-in-depth in gh-aw's own runner-guard integration
filterGvisorInstallFindings(pkg/cli/runner_guard_gvisor_exfiltration.go), following the same pattern as the existing RGS-004 activation-gate filter.parseAndDisplayRunnerGuardOutput, applied whenevergh-aw compile --runner-guardruns (including the daily static-analysis-report workflow).