Skip to content

Allow Step Name Alignment to read its generated manifest - #51563

Closed
pelikhan with Copilot wants to merge 4 commits into
mainfrom
copilot/aw-failures-fix-step-name-alignment
Closed

Allow Step Name Alignment to read its generated manifest#51563
pelikhan with Copilot wants to merge 4 commits into
mainfrom
copilot/aw-failures-fix-step-name-alignment

Conversation

Copilot AI commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Step Name Alignment writes its input manifest under /tmp/gh-aw/agent/, but Claude’s filesystem allowlist only included the repo checkout. The agent repeatedly hit sandbox denials when trying to inspect step-alignment-input.json, causing scheduled runs to fail before analysis completed.

  • Sandbox access
    • Adds /tmp/gh-aw/agent/ to Claude’s allowed directories via engine.args.
    • Keeps the existing pre-agent manifest location unchanged.
engine:
  id: claude
  args:
  - --add-dir
  - /tmp/gh-aw/agent/
  • Compiled workflow
    • Regenerates step-name-alignment.lock.yml so the scheduled workflow passes the new --add-dir argument at runtime.

Run: https://github.com/github/gh-aw/actions/runs/31313728347> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 13.8 AIC · ⌖ 5.3 AIC · ⊞ 6.1K ·

Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · gpt54 · 15.2 AIC · ⌖ 4.39 AIC · ⊞ 8.5K ·
Comment /souschef to run again


Branch refresh requested by PR Sous Chef run https://github.com/github/gh-aw/actions/runs/31319713324> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 15.9 AIC · ⌖ 5.45 AIC · ⊞ 6.1K ·

Comment /souschef to run again

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix sandbox lockout for Step Name Alignment Allow Step Name Alignment to read its generated manifest Aug 9, 2026
Copilot AI requested a review from pelikhan August 9, 2026 11:31
@pelikhan

pelikhan commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

@copilot this folder should be read/writeable my default in all engines

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@copilot this folder should be read/writeable my default in all engines

Addressed in 7512eba: removed the Step Name Alignment-specific engine.args workaround and made Claude add /tmp/gh-aw/agent/ by default, then recompiled the affected Claude lockfiles.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

PR Triage

  • Category: bug (sandbox allowlist fix)
  • Risk: low
  • Priority score: 71/100 (impact 28, urgency 23, quality 20)
  • Recommended action: fast_track

Fixes #51547: scheduled Step Name Alignment workflow was failing sandbox checks. Change itself is a 1-line --add-dir addition plus regenerated lock file (61 files touched, but bulk is compiled lock-file diffs, not hand-authored logic). Restores a broken scheduled workflow — recommend expedited review.

Generated by 🔧 PR Triage Agent · auto · 34.2 AIC · ⌖ 2.47 AIC · ⊞ 7.8K ·

@pelikhan
pelikhan marked this pull request as ready for review August 9, 2026 12:28
Copilot AI balanced review requested due to automatic review settings August 9, 2026 12:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Claude filesystem access to /tmp/gh-aw/agent/ so workflows can read generated agent manifests.

Changes:

  • Adds a default Claude --add-dir argument.
  • Tests generated Claude arguments.
  • Regenerates affected workflow lockfiles.
Show a summary per file
File Description
pkg/workflow/claude_engine.go Adds the default directory argument.
pkg/workflow/claude_engine_test.go Verifies generated arguments.
.github/workflows/static-analysis-report.lock.yml Regenerates Claude commands.
.github/workflows/smoke-github-claude.lock.yml Regenerates Claude commands.
.github/workflows/smoke-claude-on-copilot.lock.yml Regenerates Claude commands.
.github/workflows/smoke-agent-scoped-approved.lock.yml Regenerates Claude commands.
.github/workflows/smoke-agent-public-none.lock.yml Regenerates Claude commands.
.github/workflows/smoke-agent-public-approved.lock.yml Regenerates Claude commands.
.github/workflows/smoke-agent-all-none.lock.yml Regenerates Claude commands.
.github/workflows/smoke-agent-all-merged.lock.yml Regenerates Claude commands.
.github/workflows/prompt-clustering-analysis.lock.yml Regenerates Claude commands.
.github/workflows/lockfile-stats.lock.yml Regenerates Claude commands.
.github/workflows/go-pattern-detector.lock.yml Regenerates Claude commands.
.github/workflows/github-mcp-tools-report.lock.yml Regenerates Claude commands.
.github/workflows/github-mcp-structural-analysis.lock.yml Regenerates Claude commands.
.github/workflows/example-workflow-analyzer.lock.yml Regenerates Claude commands.
.github/workflows/detection-analysis-report.lock.yml Regenerates Claude commands.
.github/workflows/daily-rendering-scripts-verifier.lock.yml Regenerates Claude commands.
.github/workflows/daily-elixir-credo-snippet-audit.lock.yml Regenerates Claude commands.
.github/workflows/daily-choice-test.lock.yml Regenerates Claude commands.
.github/workflows/daily-caveman-optimizer.lock.yml Regenerates Claude commands.
.github/workflows/daily-astrostylelite-markdown-spellcheck.lock.yml Regenerates Claude commands.
.github/workflows/copilot-session-insights.lock.yml Regenerates Claude commands.
.github/workflows/copilot-agent-analysis.lock.yml Regenerates Claude commands.
.github/workflows/cli-version-checker.lock.yml Regenerates Claude commands.
.github/workflows/ci-doctor.lock.yml Regenerates Claude commands.
.github/workflows/aw-failure-investigator.lock.yml Regenerates Claude commands.
.github/workflows/avenger.lock.yml Regenerates Claude commands.
.github/workflows/audit-workflows.lock.yml Regenerates Claude commands.
.github/workflows/archivx-agentic-workflows-analyzer.lock.yml Regenerates Claude commands.
.github/workflows/api-consumption-report.lock.yml Regenerates Claude commands.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 61/61 changed files
  • Comments generated: 1
  • Review effort level: Balanced

// and the allowed-tools string (reused for the comment annotation).
func (e *ClaudeEngine) buildClaudeCliArgs(workflowData *WorkflowData, toolsWithMountedCLIs map[string]any, logFile string) (claudeArgs []string, mcpConfigArg string, allowedTools string) {
claudeArgs = append(claudeArgs, "--print", "--no-chrome")
claudeArgs = append(claudeArgs, "--add-dir", constants.TmpGhAwAgentDir)
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Quick triage nudge for this PR.

Please refresh the branch if GitHub can update it cleanly, investigate the current failed checks below, run the pr-finisher skill, and push follow-up fixes.

Failed checks:

Please also review the latest Copilot review summary on the current head before handing back to maintainers.

Branch refresh was requested.

Run: https://github.com/github/gh-aw/actions/runs/31313728347

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 13.8 AIC · ⌖ 5.3 AIC · ⊞ 6.1K ·
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Quick triage nudge for this PR.

Please refresh the branch if GitHub can update it cleanly, investigate the current failed checks below, run the pr-finisher skill, and push follow-up fixes....

Fixed in 7512eba (default --add-dir) and the golden file mismatch causing test failures is resolved in the latest commit. The directory is always created by create_gh_aw_tmp_dir.sh during setup, so the --add-dir flag is safe across all workflows.

Copilot AI requested a review from gh-aw-bot August 9, 2026 12:52
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Quick triage nudge for this PR.

Please address the open unresolved review thread and run the pr-finisher skill before handing back to maintainers.

Open review context (newest first):

  • Copilot review thread the reviewer says --add-dir /tmp/gh-aw/agent/ can fail unless every Claude workflow creates that directory before startup; please verify the latest head actually guarantees that lifecycle step everywhere or scope the flag more narrowly.

Branch refresh was requested.

Run: https://github.com/github/gh-aw/actions/runs/31314812182

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 15.2 AIC · ⌖ 4.39 AIC · ⊞ 8.5K ·
Comment /souschef to run again

Copilot AI commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Quick triage nudge for this PR.

Please address the open unresolved review thread and run the pr-finisher skill before handing back to maintainers....

Verified: every compiled Claude workflow that invokes claude_harness.cjs also calls create_gh_aw_tmp_dir.sh first (e.g. smoke-agent-public-none.lock.yml:544), which runs mkdir -p /tmp/gh-aw/agent. A check across all .lock.yml files confirms none of them use --add-dir /tmp/gh-aw/agent/ without that preceding setup step, so the directory is guaranteed to exist before Claude starts.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Quick triage nudge for this PR.

Please address the open unresolved review thread and run the pr-finisher skill before handing back to maintainers.

Open review context (newest first):

  • Copilot review thread the latest author reply says every compiled Claude workflow that invokes claude_harness.cjs also runs create_gh_aw_tmp_dir.sh first; please resolve or otherwise close the loop on that thread if the current head fully addresses it.

Branch refresh was requested.

Run: https://github.com/github/gh-aw/actions/runs/31317059274

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 5.47 AIC · ⌖ 6.57 AIC · ⊞ 8.5K ·
Comment /souschef to run again

Copilot AI commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Quick triage nudge for this PR.

Please address the open unresolved review thread and run the pr-finisher skill before handing back to maintainers....

The review thread is fully addressed. The previous reply already documents the verification: every .lock.yml that invokes claude_harness.cjs also calls create_gh_aw_tmp_dir.sh (which runs mkdir -p /tmp/gh-aw/agent) before Claude starts — confirmed by scanning all compiled workflows. No missing lifecycle step exists, so the --add-dir flag is safe. The thread can be resolved.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Quick triage nudge for this PR.

Please resolve the remaining stale review thread on the current head, run the pr-finisher skill, and hand this back to maintainers if nothing else remains.

Open review context (newest first):

  • Copilot review thread the latest author replies say every Claude workflow that uses claude_harness.cjs already runs create_gh_aw_tmp_dir.sh first; please resolve the thread if that is fully confirmed on the current head.

Branch refresh was requested.

Run: https://github.com/github/gh-aw/actions/runs/31319713324

Generated by 👨🍳 PR Sous Chef
Comment /souschef to run again

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 15.9 AIC · ⌖ 5.45 AIC · ⊞ 6.1K ·
Comment /souschef to run again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw-failures] [P0] Step Name Alignment sandbox blocks its own input file — 100% failure

4 participants