Consolidate JobStep/JobStepData identical structs in pkg/cli - #52120
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Consolidates duplicate job-step types while preserving existing package usage.
Changes:
- Aliases
JobStepDatatoJobStep. - Removes redundant step conversion.
- Unintentionally replaces the slide deck with an LFS pointer.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/audit_report.go |
Adds alias and direct step assignment. |
pkg/cli/README.md |
Documents the alias. |
docs/slides/index.md |
Replaces slide content with an unrelated LFS pointer. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
| version https://git-lfs.github.com/spec/v1 | ||
| oid sha256:6dff7f23b04f978e62d3477279efb1ff7712e51495f0c54f3616daef510c2574 | ||
| size 10889 |
PR Triage: #52120
Automated triage — see labels for machine-readable classification.
|
|
@copilot Please refresh this branch, verify checks, and use the pr-finisher skill before handing back. Reviewer follow-up: copilot-pull-request-reviewer flagged that No failed checks were reported in the compact candidate set for this run.
|
pkg/cli/logs_models.goandpkg/cli/audit_report.goeach defined a structurally identical struct (JobStepandJobStepData), requiring a manual conversion (JobStepData(step)) every time data crossed between them.Changes
JobStepDatastruct definition inpkg/cli/audit_report.gowith a type alias toJobStep:sliceutil.Mapconversion inbuildAuditJobs, assigningjobDetail.Stepsdirectly instead of mapping each step throughJobStepData(step).pkg/cli/README.mdpackage reference table entry forJobStepDatato reflect the alias.