Reduce pkg/cli package manifest largefunc backlog by Copilot · Pull Request #52218 · github/gh-aw

Copilot · 2026-08-12T03:54:36Z

Daily custom lint flagged oversized pkg/cli helpers. This PR takes a focused first slice by reducing the add_package_manifest.go function-length findings without broad rewrites.

Repository package resolution
- Extracts repo slug parsing, ref resolution, extension-file resolution, and result construction from resolveRepositoryPackage.
Manifest parsing
- Splits YAML/root validation, version checks, and metadata population out of parseRepositoryPackageManifest.
Skill file resolution
- Separates skill directory normalization, manifest/auto-scan merging, marker validation, and recursive file listing.

manifest, warnings, err := parseRepositoryPackageManifest(manifestPath, manifestContent)
installationSources, includeSkillDirs, includeAgentFiles, err :=
	resolveRepositoryPackageInstallablePaths(ctx, owner, repo, packagePath, ref, host, manifest, manifestPath)
extensionFiles, err := resolveRepositoryPackageExtensionFiles(ctx, repositoryPackageExtensionFilesRequest{...})

Fixes [lint-monster] reduce pkg/cli function-length backlog (first slice) #52208

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 26 AIC · ⌖ 5.66 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 37.2 AIC · ⌖ 6.36 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 14.4 AIC · ⌖ 5.73 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.25 AIC · ⌖ 5.07 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-08-12T06:49:13Z

Triage: pr-type:refactor · pr-risk:low · Score 35/100 (impact 10, urgency 10, quality 15)

Recommended action: batch_review (batch: lintmonster-refactor)

Function-length reduction in add_package_manifest.go (1 file, +217/-108). Single-file, mechanical extraction. Draft, CI not yet run. Grouped with #52220, #52219, #52212.

Generated by 🔧 PR Triage Agent · auto · 44.6 AIC · ⌖ 2.44 AIC · ⊞ 7.8K · ◷

github-actions · 2026-08-12T12:37:00Z

Triage

Category: refactor
Risk: low
Priority score: 36/100 (impact 15, urgency 9, quality 12)
Action: batch_review
Batch: lintmonster-refactor (with Refactor duplicate console format helpers and unify integer tag dispatch; add MCPServerID validity API #52220, Reduce pkg/workflow largefunc backlog via frontmatter parser helper extraction #52219, Refactor nested YAML value extraction #52212)

Largest diff in the batch (217 additions) targeting add_package_manifest.go largefunc backlog. CI unstable — recheck before merge.

Generated by 🔧 PR Triage Agent · auto · 41.1 AIC · ⌖ 2.53 AIC · ⊞ 7.8K · ◷

github-actions · 2026-08-12T18:36:19Z

PR Triage

Category: refactor
Risk: low
Score: 30/100 (impact 10 + urgency 10 + quality 10)
Recommended action: batch_review
Batch: lintmonster-refactor
Note: refactor, part of lintmonster batch

Generated by 🔧 PR Triage Agent · auto · 39.1 AIC · ⌖ 2.59 AIC · ⊞ 7.8K · ◷

github-actions · 2026-08-13T00:47:05Z

PR Triage Summary

Total score: 34/100
Breakdown: Impact 15 + Urgency 8 + Quality 11 (draft, no CI yet) -> DEFER (batch: lintmonster-refactor)

Automated triage — see labels applied for classification. Full report in the triage issue.

Generated by 🔧 PR Triage Agent · auto · 43.1 AIC · ⌖ 2.43 AIC · ⊞ 7.8K · ◷

github-actions · 2026-08-13T06:51:54Z

PR Triage

Category: refactor | Risk: low | Priority: low | Score: 30/100

Score breakdown: impact 15/50, urgency 5/30, quality 10/20

CI: unknown (draft)

Recommended action: batch_review
Batch: lintmonster-refactor

Same batch as 52219/52220 but still draft, mergeable unknown.

_{Automated triage — run 52218}

Generated by 🔧 PR Triage Agent · auto · 67.2 AIC · ⌖ 2.77 AIC · ⊞ 7.8K · ◷

github-actions

Generated by ✂️ Ponytail Reviewer for #52218 · auto · 27.6 AIC · ⌖ 3.17 AIC · ⊞ 6.8K
_{Comment /ponytail to run again}

github-actions · 2026-08-13T17:56:52Z

-	if err != nil {
-		return nil, err
-	}
+type repositoryPackageExtensionFilesRequest struct {


L177-186: yagni: request struct with 8 fields, built once and read once between one caller and one callee. Pass the params directly to resolveRepositoryPackageExtensionFiles instead.

github-actions

Clean refactoring that extracts large functions in add_package_manifest.go into well-named helpers. Logic is preserved faithfully across all extraction sites. No correctness, security, or reliability issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 22.1 AIC · ⌖ 6.26 AIC · ⊞ 5.4K

gh-aw-bot · 2026-08-13T18:18:36Z

@copilot Triage nudge from sous-chef. Please address the remaining review feedback, refresh the branch if needed, and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items (newest first):

github-actions: Reduce pkg/cli package manifest largefunc backlog #52218 (comment)

Failed checks from the candidate set:

Design Decision Gate 🏗️ — https://github.com/github/gh-aw/actions/runs/31726889123

Branch update was requested automatically for this run.
Run: https://github.com/github/gh-aw/actions/runs/31729392187

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 26 AIC · ⌖ 5.66 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-13T18:25:25Z

@copilot Triage nudge from sous-chef. Please address the remaining review feedback, refresh the branch if needed, and run the pr-finisher skill before handing this PR back to maintainers.

Outstandi...

Addressed the outstanding review item (removed the yagni request struct, passing params directly) in ed7aa88.

github-actions · 2026-08-13T18:39:53Z

🔍 PR Triage

Category: refactor · Risk: low · Priority score: 32/100 (impact 10, urgency 7, quality 15)
Recommended action: batch_review
Batch: lintmonster-refactor (with #52220, #52212)

Score breakdown:

Impact: Extracts helper functions from add_package_manifest.go to reduce function-length lint backlog.
Urgency: Low — pure internal refactor.
Quality: APPROVED review; mergeable_state=unstable and no check-run data returned — verify CI before merge.

Grouped with other lint-monster function-length refactors for a single batched review pass.

Generated by 🔧 PR Triage Agent · auto · 71.4 AIC · ⌖ 2.63 AIC · ⊞ 7.8K · ◷

gh-aw-bot · 2026-08-13T18:48:09Z

@copilot Triage nudge from sous-chef. Please inspect the latest branch state, review any remaining blockers, refresh the branch if needed, and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items (newest first):

github-actions: Reduce pkg/cli package manifest largefunc backlog #52218 (comment)

No failed checks were included in the compact candidate set.
Branch update was requested by sous-chef for run https://github.com/github/gh-aw/actions/runs/31731945833.

Generated by 👨🍳 PR Sous Chef
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 37.2 AIC · ⌖ 6.36 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Copilot · 2026-08-13T18:53:10Z

@copilot Triage nudge from sous-chef. Please inspect the latest branch state, review any remaining blockers, refresh the branch if needed, and run the pr-finisher skill before handing this PR back t...

That review item was already addressed in ed7aa88. Branch is up to date with main (merge commit ffef5a7) and build/tests pass; no further changes needed.

gh-aw-bot · 2026-08-13T19:23:02Z

@copilot Triage nudge from sous-chef. Please verify whether the previously addressed review item now needs follow-up, refresh the branch if needed, and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items (newest first):

github-actions: Reduce pkg/cli package manifest largefunc backlog #52218 (comment)

Failed checks from the candidate set:

None listed in the compact candidate set.

Branch update was requested automatically for this run.
Run: https://github.com/github/gh-aw/actions/runs/31734986091

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 14.4 AIC · ⌖ 5.73 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Copilot · 2026-08-13T19:29:21Z

@copilot Triage nudge from sous-chef. Please verify whether the previously addressed review item now needs follow-up, refresh the branch if needed, and run the pr-finisher skill before handing this ...

No follow-up needed — the review item remains resolved (ed7aa88). Branch is current with main (merge commit a85f4d8) and builds cleanly.

gh-aw-bot · 2026-08-13T20:48:16Z

@copilot Please verify the remaining gate state on this PR, refresh the branch if needed, and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items (newest first):

github-actions: Reduce pkg/cli package manifest largefunc backlog #52218 (comment)
github-actions: Design Decision Gate requires the ADR linked in the PR body before merge.

Failed checks from the compact candidate set:

None listed.

Branch update was requested automatically for this run.
Run: https://github.com/github/gh-aw/actions/runs/31742164290

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.25 AIC · ⌖ 5.07 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

gh-aw-bot · 2026-08-13T21:43:16Z

@copilot Please verify the remaining gate state on this PR, refresh the branch if needed, and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items (newest first):

github-actions: Design Decision Gate still requires the ADR linked in the PR body before merge.
github-actions: please confirm the previously addressed review discussion at discussion_r3777833034 still needs no follow-up.

Failed checks from the compact candidate set:

None listed.

Branch update could not be requested automatically in this run because the local gh aw checks helper was unavailable.
Run: https://github.com/github/gh-aw/actions/runs/31746457772

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 10.9 AIC · ⌖ 7.21 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

gh-aw-bot · 2026-08-13T22:28:42Z

@copilot Please link the required ADR in the PR body, confirm the previously addressed review thread no longer needs follow-up, refresh the branch if needed, and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items (newest first):

github-actions: Design Decision Gate still requires the ADR linked in the PR body before merge.
github-actions: Reduce pkg/cli package manifest largefunc backlog #52218 (comment)

Failed checks from the compact candidate set:

None listed.

Branch update was not requested in this run because the latest recent checks were already completed.
Run: https://github.com/github/gh-aw/actions/runs/31749685094

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 13.8 AIC · ⌖ 8.11 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

Initial plan

b7944ad

Copilot AI assigned Copilot and pelikhan Aug 12, 2026

Copilot AI linked an issue Aug 12, 2026 that may be closed by this pull request

[lint-monster] reduce pkg/cli function-length backlog (first slice) #52208

Open

7 tasks

Copilot started work on behalf of pelikhan August 12, 2026 03:55 View session

Refactor package manifest CLI helpers

4219d9f

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Reduce function length in pkg/cli~~ Reduce pkg/cli package manifest largefunc backlog Aug 12, 2026

Copilot AI requested a review from pelikhan August 12, 2026 04:12

Copilot finished work on behalf of pelikhan August 12, 2026 04:12

github-actions Bot mentioned this pull request Aug 12, 2026

[pr-review] Daily PR Code Quality Review — 31568786443 #52246

Closed

github-actions Bot added pr-action:batch_review pr-agent:copilot pr-batch:lintmonster-refactor pr-priority:low pr-risk:low pr-type:refactor labels Aug 12, 2026

github-actions Bot mentioned this pull request Aug 12, 2026

[PR Triage Report] PR Triage Report — 2026-08-12 #52293

Closed

github-actions Bot mentioned this pull request Aug 12, 2026

[PR Triage Report] PR Triage Report — 2026-08-12 #52339

Closed

github-actions Bot added the pr-action:defer label Aug 13, 2026

github-actions Bot mentioned this pull request Aug 13, 2026

[PR Triage Report] PR Triage Report — 2026-08-13 (Run 31655049891) #52394

Closed

github-actions Bot mentioned this pull request Aug 13, 2026

[PR Triage Report] PR Triage Report — 15 open Copilot PRs (Run 31674716154) #52458

Closed

github-actions Bot reviewed Aug 13, 2026

View reviewed changes

github-actions Bot approved these changes Aug 13, 2026

View reviewed changes

github-actions Bot mentioned this pull request Aug 13, 2026

[aw] Design Decision Gate 🏗️ failed #52536

Open

Merge branch 'main' into copilot/lint-monster-reduce-function-length

735e002

Copilot started work on behalf of gh-aw-bot August 13, 2026 18:19 View session

github-actions Bot mentioned this pull request Aug 13, 2026

[pr-sous-chef] PR Sous Chef run report #52387

Open

Pass extension-file resolution params directly instead of request struct

ed7aa88

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 13, 2026 18:25

Copilot AI requested a review from gh-aw-bot August 13, 2026 18:25

github-actions Bot mentioned this pull request Aug 13, 2026

[PR Triage Report] PR Triage Report — 2026-08-13 (Run 31730872872) #52545

Open

Merge branch 'main' into copilot/lint-monster-reduce-function-length

ffef5a7

Copilot started work on behalf of gh-aw-bot August 13, 2026 18:48 View session

Copilot finished work on behalf of gh-aw-bot August 13, 2026 18:53

Merge branch 'main' into copilot/lint-monster-reduce-function-length

a85f4d8

Copilot started work on behalf of gh-aw-bot August 13, 2026 19:23 View session

Copilot finished work on behalf of gh-aw-bot August 13, 2026 19:29

Merge branch 'main' into copilot/lint-monster-reduce-function-length

7015d4e

Copilot started work on behalf of gh-aw-bot August 13, 2026 20:48 View session

Copilot started work on behalf of gh-aw-bot August 13, 2026 21:43 View session

Copilot started work on behalf of gh-aw-bot August 13, 2026 22:29 View session

Uh oh!

Conversation

Copilot AI commented Aug 12, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 12, 2026

Triage: pr-type:refactor · pr-risk:low · Score 35/100 (impact 10, urgency 10, quality 15)

Uh oh!

github-actions Bot commented Aug 12, 2026

Triage

Uh oh!

github-actions Bot commented Aug 12, 2026

PR Triage

Uh oh!

github-actions Bot commented Aug 13, 2026

PR Triage Summary

Uh oh!

github-actions Bot commented Aug 13, 2026

PR Triage

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Aug 13, 2026

Uh oh!

Copilot AI commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

🔍 PR Triage

Uh oh!

gh-aw-bot commented Aug 13, 2026

Uh oh!

Copilot AI commented Aug 13, 2026

Uh oh!

gh-aw-bot commented Aug 13, 2026

Uh oh!

Copilot AI commented Aug 13, 2026

Uh oh!

gh-aw-bot commented Aug 13, 2026

Uh oh!

gh-aw-bot commented Aug 13, 2026

Uh oh!

gh-aw-bot commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 12, 2026 •

edited by github-actions Bot

Loading