Skip to content

[test-parallel] Add t.Parallel() to safe subtests in TestAnalyzeAccessLogsDirectory #52250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Aug 13, 2026
+3 −0
Merged

[test-parallel] Add t.Parallel() to safe subtests in TestAnalyzeAccessLogsDirectory #52250

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db26cac
Add t.Parallel() to independent subtests in TestAnalyzeAccessLogsDire…
github-actions[bot] Aug 12, 2026
a2df00e
Merge branch 'main' into test-parallelizer/access-log-subtests-a0ec5c…
github-actions[bot] Aug 13, 2026
243014f
Merge branch 'main' into test-parallelizer/access-log-subtests-a0ec5c…
github-actions[bot] Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/cli/access_log_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ func TestAnalyzeAccessLogsDirectory(t *testing.T) {
tempDir := testutil.TempDir(t, "test-*")

t.Run("multiple access logs in subdirectory", func(t *testing.T) {
t.Parallel()
// Test case 1: Multiple access logs in access-logs subdirectory
accessLogsDir := filepath.Join(tempDir, "run1", "access.log")
err := os.MkdirAll(accessLogsDir, 0755)
Expand All @@ -111,6 +112,7 @@ func TestAnalyzeAccessLogsDirectory(t *testing.T) {
})

t.Run("no access logs - returns nil", func(t *testing.T) {
t.Parallel()
// Test case 2: No access logs
run2Dir := filepath.Join(tempDir, "run2")
err := os.MkdirAll(run2Dir, 0755)
Expand All @@ -122,6 +124,7 @@ func TestAnalyzeAccessLogsDirectory(t *testing.T) {
})

t.Run("access logs in sandbox/firewall/logs/ (new path)", func(t *testing.T) {
t.Parallel()
// Test case 3: Access logs in sandbox/firewall/logs/ directory after artifact download
sandboxLogsDir := filepath.Join(tempDir, "run3", "sandbox", "firewall", "logs")
err := os.MkdirAll(sandboxLogsDir, 0755)
Expand Down
Loading