Extract shared smoke-test brevity prompt and import across 21 smoke workflows - #52565
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor to extract shared smoke-test brevity prompt block
Extract shared smoke-test brevity prompt and import across 21 smoke workflows
Aug 13, 2026
pelikhan
marked this pull request as ready for review
August 13, 2026 19:27
Collaborator
|
@copilot resolve the merge conflicts on this branch. |
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes smoke-test brevity guidance in one reusable prompt fragment, reducing duplication across 21 workflows.
Changes:
- Added the shared brevity prompt.
- Replaced inline guidance with imports in 21 workflows.
- Regenerated corresponding lock files.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/shared/smoke-test-brevity.md |
Defines canonical brevity guidance. |
.github/workflows/smoke-aider.md |
Imports shared guidance. |
.github/workflows/smoke-aider.lock.yml |
Regenerates Aider workflow. |
.github/workflows/smoke-claude.md |
Imports shared guidance. |
.github/workflows/smoke-claude.lock.yml |
Regenerates Claude workflow. |
.github/workflows/smoke-codex.md |
Imports shared guidance. |
.github/workflows/smoke-codex.lock.yml |
Regenerates Codex workflow. |
.github/workflows/smoke-copilot-aoai-apikey.md |
Imports shared guidance. |
.github/workflows/smoke-copilot-aoai-apikey.lock.yml |
Regenerates API-key workflow. |
.github/workflows/smoke-copilot-aoai-entra.md |
Imports shared guidance. |
.github/workflows/smoke-copilot-aoai-entra.lock.yml |
Regenerates Entra workflow. |
.github/workflows/smoke-copilot-arm.md |
Imports shared guidance. |
.github/workflows/smoke-copilot-arm.lock.yml |
Regenerates ARM workflow. |
.github/workflows/smoke-copilot-auto.md |
Imports shared guidance. |
.github/workflows/smoke-copilot-auto.lock.yml |
Regenerates auto-model workflow. |
.github/workflows/smoke-copilot-mai.md |
Imports shared guidance. |
.github/workflows/smoke-copilot-mai.lock.yml |
Regenerates MAI workflow. |
.github/workflows/smoke-copilot-sdk.md |
Imports shared guidance. |
.github/workflows/smoke-copilot-sdk.lock.yml |
Regenerates SDK workflow. |
.github/workflows/smoke-copilot-small.md |
Imports shared guidance. |
.github/workflows/smoke-copilot-small.lock.yml |
Regenerates small-model workflow. |
.github/workflows/smoke-copilot.md |
Imports shared guidance. |
.github/workflows/smoke-copilot.lock.yml |
Regenerates Copilot workflow. |
.github/workflows/smoke-create-cross-repo-pr.md |
Imports shared guidance. |
.github/workflows/smoke-create-cross-repo-pr.lock.yml |
Regenerates PR-creation workflow. |
.github/workflows/smoke-crush.md |
Imports shared guidance. |
.github/workflows/smoke-crush.lock.yml |
Regenerates Crush workflow. |
.github/workflows/smoke-cursor.md |
Imports shared guidance. |
.github/workflows/smoke-cursor.lock.yml |
Regenerates Cursor workflow. |
.github/workflows/smoke-gemini.md |
Imports shared guidance. |
.github/workflows/smoke-gemini.lock.yml |
Regenerates Gemini workflow. |
.github/workflows/smoke-goose.md |
Imports shared guidance. |
.github/workflows/smoke-goose.lock.yml |
Regenerates Goose workflow. |
.github/workflows/smoke-kiro.md |
Imports shared guidance. |
.github/workflows/smoke-kiro.lock.yml |
Regenerates Kiro workflow. |
.github/workflows/smoke-opencode.md |
Imports shared guidance. |
.github/workflows/smoke-opencode.lock.yml |
Regenerates OpenCode workflow. |
.github/workflows/smoke-pi.md |
Imports shared guidance. |
.github/workflows/smoke-pi.lock.yml |
Regenerates Pi workflow. |
.github/workflows/smoke-pydantic.md |
Imports shared guidance. |
.github/workflows/smoke-pydantic.lock.yml |
Regenerates Pydantic workflow. |
.github/workflows/smoke-update-cross-repo-pr.md |
Imports shared guidance. |
.github/workflows/smoke-update-cross-repo-pr.lock.yml |
Regenerates PR-update workflow. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 43/43 changed files
- Comments generated: 0
- Review effort level: Balanced
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Resolved and pushed in commit |
Collaborator
|
@copilot Triage nudge from sous-chef. This branch is/was conflicting; please run Context:
Run: https://github.com/github/gh-aw/actions/runs/31737307049
|
github-actions Bot
added a commit
that referenced
this pull request
Aug 14, 2026
Extract a writeIfValid helper to remove repeated if(isValid...) writeEnvLine(...) patterns for trace-id/span-id/parent-span-id output and env propagation. Behavior unchanged; all log messages and file writes are identical. Source: recent activity around #52565 (shared prompt extraction) and #52542 (shared reporting import) motivated looking for similar duplication-reduction opportunities in actions/setup/js. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor removes duplicated “keep output short” prompt text repeated across smoke/conformance workflows and replaces it with a single shared prompt fragment. It standardizes brevity guidance for high-frequency CI smoke tests while reducing maintenance overhead.
What changed
.github/workflows/shared/smoke-test-brevity.md.imports.Canonical shared prompt
Workflow updates
.lock.ymlfiles were updated to reflect the new import composition.