Skip to content

Fix shellcheck SC2086 quoting issues in shell scripts #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Dec 2, 2025
Merged

Fix shellcheck SC2086 quoting issues in shell scripts #5310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e497ee
Initial plan
Copilot Dec 2, 2025
ddcc873
Fix shellcheck SC2086 quoting issues in shell scripts
Copilot Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/go-pattern-detector.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/go-pattern-detector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
run: |
# Install ast-grep using cargo for better version control and security
cargo install ast-grep --locked
echo "$HOME/.cargo/bin" >> $GITHUB_PATH
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
- name: Detect Go patterns
id: detect
run: |
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/release.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions .github/workflows/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
RELEASE_TAG="${GITHUB_REF#refs/tags/}"
echo "Getting release ID for tag: $RELEASE_TAG"
RELEASE_ID=$(gh release view "$RELEASE_TAG" --json databaseId --jq '.databaseId')
echo "release_id=$RELEASE_ID" >> $GITHUB_OUTPUT
echo "release_id=$RELEASE_ID" >> "$GITHUB_OUTPUT"
echo "✓ Release ID: $RELEASE_ID"
steps:
- name: Setup environment and fetch release data
Expand All @@ -76,7 +76,7 @@ steps:
RELEASE_TAG="${GITHUB_REF#refs/tags/}"
echo "Processing release: $RELEASE_TAG"

echo "RELEASE_TAG=$RELEASE_TAG" >> $GITHUB_ENV
echo "RELEASE_TAG=$RELEASE_TAG" >> "$GITHUB_ENV"

# Get the current release information
gh release view "$RELEASE_TAG" --json name,tagName,createdAt,publishedAt,url,body > /tmp/gh-aw/release-data/current_release.json
Expand All @@ -87,12 +87,12 @@ steps:

if [ -z "$PREV_RELEASE_TAG" ]; then
echo "No previous release found. This appears to be the first release."
echo "PREV_RELEASE_TAG=" >> $GITHUB_ENV
echo "PREV_RELEASE_TAG=" >> "$GITHUB_ENV"
touch /tmp/gh-aw/release-data/pull_requests.json
echo "[]" > /tmp/gh-aw/release-data/pull_requests.json
else
echo "Previous release: $PREV_RELEASE_TAG"
echo "PREV_RELEASE_TAG=$PREV_RELEASE_TAG" >> $GITHUB_ENV
echo "PREV_RELEASE_TAG=$PREV_RELEASE_TAG" >> "$GITHUB_ENV"

# Get commits between releases
echo "Fetching commits between $PREV_RELEASE_TAG and $RELEASE_TAG..."
Expand All @@ -109,7 +109,7 @@ steps:
--jq "[.[] | select(.mergedAt >= \"$PREV_PUBLISHED_AT\" and .mergedAt <= \"$CURR_PUBLISHED_AT\")]" \
> /tmp/gh-aw/release-data/pull_requests.json

PR_COUNT=$(jq length /tmp/gh-aw/release-data/pull_requests.json)
PR_COUNT=$(jq length "/tmp/gh-aw/release-data/pull_requests.json")
echo "✓ Fetched $PR_COUNT pull requests"
fi

Expand Down