Skip to content

Replace gh repo view shell-out with repository.Current() #5901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 5 commits into from
Dec 8, 2025
Merged

Replace gh repo view shell-out with repository.Current() #5901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7416b65
Initial plan
Copilot Dec 8, 2025
3bae8a9
Initial plan: Replace gh repo view with repository.Current()
Copilot Dec 8, 2025
8679b9b
Replace gh repo view with repository.Current()
Copilot Dec 8, 2025
41f645f
Recompile workflows after repository.Current() changes
Copilot Dec 8, 2025
950e5cf
Add validation for empty owner/name in repository.Current()
Copilot Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 15 additions & 63 deletions .github/aw/github-agentic-workflows.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/release.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 11 additions & 9 deletions pkg/workflow/repository_features_validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import (
"sync"

"github.com/cli/go-gh/v2"
"github.com/cli/go-gh/v2/pkg/repository"
"github.com/githubnext/gh-aw/pkg/console"
"github.com/githubnext/gh-aw/pkg/logger"
)
Expand Down Expand Up @@ -175,22 +176,23 @@ func getCurrentRepository() (string, error) {

// getCurrentRepositoryUncached fetches the current repository from gh CLI (no caching)
func getCurrentRepositoryUncached() (string, error) {
repositoryFeaturesLog.Print("Fetching current repository from gh CLI")
repositoryFeaturesLog.Print("Fetching current repository using repository.Current()")

// Use gh CLI to get the current repository
// This works when in a git repository with GitHub remote
stdOut, _, err := gh.Exec("repo", "view", "--json", "nameWithOwner", "-q", ".nameWithOwner")
// Use native repository.Current() to get the current repository
// This works when in a git repository with GitHub remote and respects GH_REPO
repo, err := repository.Current()
if err != nil {
return "", fmt.Errorf("failed to get current repository: %w", err)
}

repo := strings.TrimSpace(stdOut.String())
if repo == "" {
return "", fmt.Errorf("repository name is empty")
// Validate that owner and name are not empty
if repo.Owner == "" || repo.Name == "" {
return "", fmt.Errorf("repository owner or name is empty (owner: %q, name: %q)", repo.Owner, repo.Name)
}

repositoryFeaturesLog.Printf("Cached current repository: %s", repo)
return repo, nil
repoName := fmt.Sprintf("%s/%s", repo.Owner, repo.Name)
repositoryFeaturesLog.Printf("Cached current repository: %s", repoName)
return repoName, nil
}

// getRepositoryFeatures gets repository features with caching to amortize API calls
Expand Down