Skip to content

[security-fix] Fix unhandled errors in mcp_inspect.go cleanup operations #7969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Dec 28, 2025
Merged

[security-fix] Fix unhandled errors in mcp_inspect.go cleanup operations #7969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/cli/mcp_inspect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,9 @@ func startSafeInputsServer(safeInputsConfig *workflow.SafeInputsConfig, verbose
// Find an available port for the HTTP server
port := findAvailablePort(safeInputsStartPort, verbose)
if port == 0 {
os.RemoveAll(tmpDir)
if err := os.RemoveAll(tmpDir); err != nil && verbose {
mcpInspectLog.Printf("Warning: failed to clean up temporary directory %s: %v", tmpDir, err)
}
return nil, nil, "", fmt.Errorf("failed to find an available port for the HTTP server")
}

Expand All @@ -534,7 +536,9 @@ func startSafeInputsServer(safeInputsConfig *workflow.SafeInputsConfig, verbose
if serverCmd.Process != nil {
_ = serverCmd.Process.Kill()
}
os.RemoveAll(tmpDir)
if err := os.RemoveAll(tmpDir); err != nil && verbose {
mcpInspectLog.Printf("Warning: failed to clean up temporary directory %s: %v", tmpDir, err)
}
return nil, nil, "", fmt.Errorf("safe-inputs HTTP server failed to start within timeout")
}

Expand Down