Skip to content

Fix read-only filesystem errors in check_workflow_recompile_needed tests #9979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Jan 14, 2026
Merged

Fix read-only filesystem errors in check_workflow_recompile_needed tests #9979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b383d6b
Initial plan
Copilot Jan 14, 2026
b778f2f
Plan fixes for JavaScript test failures
Copilot Jan 14, 2026
425e968
Fix read-only filesystem issue in check_workflow_recompile_needed tests
Copilot Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/repository-quality-improver.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion actions/setup/js/check_workflow_recompile_needed.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ async function main() {
const runUrl = context.payload.repository ? `${context.payload.repository.html_url}/actions/runs/${context.runId}` : `${githubServer}/${owner}/${repo}/actions/runs/${context.runId}`;

// Read the issue template from the prompts directory
const templatePath = "/opt/gh-aw/prompts/workflow_recompile_issue.md";
// Allow override via environment variable for testing
const promptsDir = process.env.GH_AW_PROMPTS_DIR || "/opt/gh-aw/prompts";
const templatePath = `${promptsDir}/workflow_recompile_issue.md`;
let issueTemplate;
try {
issueTemplate = fs.readFileSync(templatePath, "utf8");
Expand Down
25 changes: 21 additions & 4 deletions actions/setup/js/check_workflow_recompile_needed.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,25 @@
import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
import fs from "fs";
import path from "path";
import os from "os";

describe("check_workflow_recompile_needed", () => {
let mockCore;
let mockGithub;
let mockContext;
let mockExec;
let originalGlobals;
const templatePath = "/opt/gh-aw/prompts/workflow_recompile_issue.md";
let originalEnv;
const testPromptsDir = path.join(os.tmpdir(), "gh-aw-test", "prompts");
const templatePath = path.join(testPromptsDir, "workflow_recompile_issue.md");

beforeEach(() => {
// Save original environment
originalEnv = process.env.GH_AW_PROMPTS_DIR;

// Set test prompts directory
process.env.GH_AW_PROMPTS_DIR = testPromptsDir;

// Create the template file for testing
const templateDir = path.dirname(templatePath);
if (!fs.existsSync(templateDir)) {
Expand Down Expand Up @@ -140,9 +149,17 @@ The following workflow lock files have changes:
});

afterEach(() => {
// Clean up the template file
if (fs.existsSync(templatePath)) {
fs.unlinkSync(templatePath);
// Restore environment variable
if (originalEnv !== undefined) {
process.env.GH_AW_PROMPTS_DIR = originalEnv;
} else {
delete process.env.GH_AW_PROMPTS_DIR;
}

// Clean up the test directory
const testDir = path.join(os.tmpdir(), "gh-aw-test");
if (fs.existsSync(testDir)) {
fs.rmSync(testDir, { recursive: true, force: true });
}

// Restore original globals
Expand Down